libosmo-gprs/src/rlcmac
Pau Espin 27d2c697e5 tbf_ul: Clean and assert code path generating new UL data block
Clarify the several paths when generating a new BSN (UL data block).
The function create_new_bsn() is only called if there's some LLC frame
ready to be transmitted and put in ul_tbf->llc_tx_msg, so the do while
{} condition checking for no llc_tx_msg is guaranteed to only be run in
the event some LLC frame chunks have been included in the UL RLC block.
This fact allows simplifying the code and at the same time fix a
Coverity CID regarding a code path which could not really happen. We now
guard this case with an ASSERT.

Related: Coverity CID#345063
Change-Id: I6d4ae377a60839f76295c0e7e6aaa1fe53e37315
2024-02-06 11:43:29 +01:00
..
Makefile.am {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS 2023-03-13 10:46:01 +00:00
codel.c rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI 2023-01-30 17:56:09 +01:00
coding_scheme.c rlcmac: Introduce DL TBF creation through PCH ImmAss 2023-02-20 12:31:25 +01:00
csn1_ts_24_008.c rlcmac: Rename ts_*.c -> csn1_ts_*.c 2023-02-01 18:23:17 +01:00
csn1_ts_44_018.c rlcmac: tbf_ul: Handle SBA from CCCH Imm Ass 2023-06-06 12:54:53 +02:00
csn1_ts_44_060.c rlcmac: Refactor msg_type enums and value_string 2023-02-01 18:28:11 +01:00
gre.c rlcmac: Implement RLC_OCTET_COUNT in DL ACK/NACK 2024-02-05 16:02:32 +01:00
llc_queue.c rlcmac: Initial selection of packet-access-procedure mode based on originating cause 2023-07-28 17:56:45 +02:00
misc.c rlcmac: Implement DL TBF CCCH & PACCH allocation with TBF Starting Time 2023-03-09 10:25:37 +01:00
pdch_ul_controller.c rlcmac: migrate from fn_cmp() to gsm0502_fncmp() 2023-10-04 11:40:57 +00:00
rlc.c rlcmac: Initial ul_tbf data support 2023-02-13 10:51:07 +01:00
rlc_window.c rlcmac: Implement Rx of UL ACK/NACK 2023-02-20 12:31:25 +01:00
rlc_window_dl.c rlcmac: Mark received BSNs falling out of the V(N)/RBB when V(R) is raised 2023-07-21 17:59:45 +02:00
rlc_window_ul.c rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() 2024-02-05 23:31:37 +07:00
rlcmac.c rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM 2024-02-02 23:49:53 +01:00
rlcmac_dec.c rlcmac: Fix Starting Time rfn->fn calculation 2023-08-21 18:09:45 +02:00
rlcmac_enc.c rlcmac: Fix Last RLC block (CV=0) not encoding >1 LLC frames 2024-02-05 16:04:06 +01:00
rlcmac_prim.c Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted 2024-02-05 16:00:32 +01:00
sched.c Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted 2024-02-05 16:00:32 +01:00
tbf.c rlcmac: Rework tbf destructor to signal free() to its gre object 2023-07-04 14:13:02 +02:00
tbf_dl.c rlcmac: tbf_dl: Log with FN request of UL TBF through PKT DL ACK/NACK 2023-09-05 19:03:52 +02:00
tbf_dl_ass_fsm.c rlcmac: migrate from fn_cmp() to gsm0502_fncmp() 2023-10-04 11:40:57 +00:00
tbf_dl_fsm.c rlcmac: tbf_dl: Implement T3192 2023-07-05 13:49:20 +02:00
tbf_ul.c tbf_ul: Clean and assert code path generating new UL data block 2024-02-06 11:43:29 +01:00
tbf_ul_ass_fsm.c rlcmac: tbf_ul_ass_fsm: Fix logic delay starting time 2023-10-05 17:49:01 +02:00
tbf_ul_fsm.c Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted 2024-02-05 16:00:32 +01:00
ts_44_060.c rlcmac: Refactor msg_type enums and value_string 2023-02-01 18:28:11 +01:00
ts_44_064.c rlcmac: Move spec related definitions for general use to types.h 2023-02-01 18:23:41 +01:00