libosmo-gprs/src
Pau Espin 27d2c697e5 tbf_ul: Clean and assert code path generating new UL data block
Clarify the several paths when generating a new BSN (UL data block).
The function create_new_bsn() is only called if there's some LLC frame
ready to be transmitted and put in ul_tbf->llc_tx_msg, so the do while
{} condition checking for no llc_tx_msg is guaranteed to only be run in
the event some LLC frame chunks have been included in the UL RLC block.
This fact allows simplifying the code and at the same time fix a
Coverity CID regarding a code path which could not really happen. We now
guard this case with an ASSERT.

Related: Coverity CID#345063
Change-Id: I6d4ae377a60839f76295c0e7e6aaa1fe53e37315
2024-02-06 11:43:29 +01:00
..
common sm: Introduce APIs to enc/dec QoS Profile 2023-07-28 13:49:46 +02:00
csn1 csn1: add -export-symbols-regex '^osmo_' to LDFLAGS 2022-08-07 17:51:26 +07:00
gmm gmm: Several fixes for radio_prio 2023-07-31 14:37:34 +02:00
llc llc: fix l3par check in gprs_llc_lle_generate_xid() 2023-12-09 05:19:55 +07:00
rlcmac tbf_ul: Clean and assert code path generating new UL data block 2024-02-06 11:43:29 +01:00
sm sm_ms_fsm: fix double timer_cb assignment 2023-10-17 08:12:58 +07:00
sndcp llc,sndcp: Add missing hex prefix to log line printing TLLI 2023-07-31 18:24:10 +02:00
Makefile.am sm: Introduce APIs to enc/dec QoS Profile 2023-07-28 13:49:46 +02:00