osmocom
/
libosmo-abis
mirror of https://gerrit.osmocom.org/libosmo-abis
11
0
Fork 0
Code Issues Releases Wiki Activity

ipaccess: do not block ipaccess_line_update on failure 

The function ipaccess_line_update (called when the API user calls
e1inp_line_update and the line is of type ipaccess) internally sets
the line_already_initialized regardless whether the initalization is
successful or not.

This also means that if the initalization fails the API user is unable
to retry the initalition with corrected line options.

Change-Id: I90d330e2864f85b964628502afdb0c38eb54f15d
Related: SYS#4971
This commit is contained in:
Philipp Maier 2021-05-20 21:01:23 +02:00
parent df088b0ea9
commit ea0f1bd49e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/input/ipaccess.c
View File

@ -1025,8 +1025,6 @@ static int ipaccess_line_update(struct e1inp_line *line)
if (il->line_already_initialized)
return 0;
il->line_already_initialized = true;
switch(line->ops->cfg.ipa.role) {
case E1INP_LINE_R_BSC: {
struct ipa_server_link *oml_link, *rsl_link;
@ -1112,6 +1110,8 @@ static int ipaccess_line_update(struct e1inp_line *line)
default:
break;
}
il->line_already_initialized = true;
return ret;
}