osmocom
/
libosmo-abis
mirror of https://gerrit.osmocom.org/libosmo-abis
11
0
Fork 0
Code Issues Releases Wiki Activity

Migrate from ipa_ccm_idtag_parse to ipa_ccm_id_resp_parse() 

In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f
we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement
of ipa_ccm_idtag_parse().

The main difference is that the returned "value" parts now have
a correct reported "length", whereas before this commit they all
reported a one-byte too-long "length" for each IE.

Change-Id: Id4c9ff821a43a37cbacce905d44fee43d1b2c879
This commit is contained in:
Harald Welte 2018-08-01 13:22:55 +02:00
parent 4c57eef663
commit 82eb55e5a1
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/input/ipa.c
View File

@ -459,8 +459,7 @@ int ipa_server_conn_ccm(struct ipa_server_conn *conn, struct msgb *msg)
switch (msg_type) {
case IPAC_MSGT_ID_RESP:
rc = ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,
msgb_l2len(msg)-2);
rc = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);
if (rc < 0) {
LOGIPA(conn, LOGL_ERROR, "IPA CCM RESPonse with "
"malformed TLVs\n");

3
src/input/ipaccess.c
View File

@ -119,8 +119,7 @@ static int ipaccess_rcvmsg(struct e1inp_line *line, struct msgb *msg,
case IPAC_MSGT_ID_RESP:
DEBUGP(DLMI, "ID_RESP\n");
/* parse tags, search for Unit ID */
ret = ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,
msgb_l2len(msg)-2);
ret = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);
DEBUGP(DLMI, "\n");
if (ret < 0) {
LOGP(DLINP, LOGL_ERROR, "IPA response message "