osmocom
/
libosmo-abis
mirror of https://gerrit.osmocom.org/libosmo-abis
11
0
Fork 0
Code Issues Releases Wiki Activity

ipa_keepalive: Make FSM a bit less quiet 

Let's make sure we log meaningful log messages whenever an IPA keepalive
FSM is started, stopped or if it times out.  This allows the user to
observe whether IPA keepalive is actually enabled (using what timeout),
and also to learn why exactly the connection was dropped.

Change-Id: Iad20b86f893c1036affaf14f978099fa858a0031
Related: SYS#6801
This commit is contained in:
Harald Welte 2024-02-21 17:20:52 +01:00
parent 1645a2a261
commit 240a0f0d7a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/input/ipa_keepalive.c
View File

@ -147,6 +147,7 @@ static int ipa_ka_fsm_timer_cb(struct osmo_fsm_inst *fi)
ifp->params.wait_for_resp, T_PONG_NOT_RECEIVED);
return 0;
case T_PONG_NOT_RECEIVED:
LOGPFSML(fi, LOGL_NOTICE, "IPA keep-alive FSM timed out: PONG not received\n");
/* PONG not received within time */
if (ifp->srv_conn)
conn = ifp->srv_conn;
@ -320,7 +321,10 @@ void ipa_keepalive_fsm_pong_received(struct osmo_fsm_inst *fi)
/*! Start the ping/pong procedure of the IPA Keepalive FSM. */
void ipa_keepalive_fsm_start(struct osmo_fsm_inst *fi)
{
struct ipa_fsm_priv *ifp = fi->priv;
OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm);
LOGPFSML(fi, LOGL_INFO, "Starting IPA keep-alive FSM (interval=%u wait=%u)\n",
ifp->params.interval, ifp->params.wait_for_resp);
osmo_fsm_inst_dispatch(fi, OSMO_IPA_KA_E_START, NULL);
}
@ -328,5 +332,6 @@ void ipa_keepalive_fsm_start(struct osmo_fsm_inst *fi)
void ipa_keepalive_fsm_stop(struct osmo_fsm_inst *fi)
{
OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm);
LOGPFSML(fi, LOGL_INFO, "Stopping IPA keep-alive FSM\n");
osmo_fsm_inst_dispatch(fi, OSMO_IPA_KA_E_STOP, NULL);
}