From ef5c43531a2b4d57ed07d4416f276637e5af40df Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sun, 1 Dec 2019 22:07:24 +0100 Subject: [PATCH] remsim: Ensure non-overlapping junit-xml filenames The default filename pattern of the JUnit log plugins of TTCN-3 is "junit-xml-%u.xml" where %u represents the PID of the process. This is typically a good idea as the PID doesn't wrap that quickly. However, if you're executing a new docker container for every test suite run, then chances are high that two subsequent runs of the test suite container might end up with the same PID and hence the smae filename. This results in the output file being overwritten, which is what's responsible for many missing RemsimServer_Tests results on the jenkins.osmocom.org test results analyzer. Change-Id: I9b6d1b5a943eb4e058ad2bf7cf8acee7b70e68b6 Closes: OS#4205 --- ttcn3-remsim-test/REMSIM_Tests.cfg | 1 + ttcn3-remsim-test/bankd/REMSIM_Tests.cfg | 1 + ttcn3-remsim-test/client/REMSIM_Tests.cfg | 1 + 3 files changed, 3 insertions(+) diff --git a/ttcn3-remsim-test/REMSIM_Tests.cfg b/ttcn3-remsim-test/REMSIM_Tests.cfg index 5a9f0264..837f12bc 100644 --- a/ttcn3-remsim-test/REMSIM_Tests.cfg +++ b/ttcn3-remsim-test/REMSIM_Tests.cfg @@ -3,6 +3,7 @@ "/osmo-ttcn3-hacks/remsim/REMSIM_Tests.default" [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-server" [TESTPORT_PARAMETERS] diff --git a/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg b/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg index 2e775904..ca83346d 100644 --- a/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg +++ b/ttcn3-remsim-test/bankd/REMSIM_Tests.cfg @@ -3,6 +3,7 @@ "/osmo-ttcn3-hacks/remsim/REMSIM_Tests.default" [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-bankd" [TESTPORT_PARAMETERS] diff --git a/ttcn3-remsim-test/client/REMSIM_Tests.cfg b/ttcn3-remsim-test/client/REMSIM_Tests.cfg index d3f8d423..2484c733 100644 --- a/ttcn3-remsim-test/client/REMSIM_Tests.cfg +++ b/ttcn3-remsim-test/client/REMSIM_Tests.cfg @@ -3,6 +3,7 @@ "/osmo-ttcn3-hacks/remsim/REMSIM_Tests.default" [LOGGING] +*.JUnitLogger.filename_stem := "junit-xml-client" [TESTPORT_PARAMETERS] # IP address to which ATS binds emulated remsim-server