Commit Graph

548 Commits

Author SHA1 Message Date
Simo Sorce 798bacfbbe Remove misleading continue statement
The RETURN macro unconditionally returns so there is no chance to "continue".
Unreachable, fund by coverity.

Signed-off-by: Simo Sorce <simo@redhat.com>
2017-03-26 05:00:01 -07:00
Simo Sorce cd943c243d The Left variable should be a positive integer
The variable Left is supposed to hold only a positive quantity and was
being passed into functions that accept only size_t as input causing coverity
to throw a fit. Using a size_t type for Left works just fine.
Negative Returns, found by coverity.
2017-03-26 05:00:01 -07:00
Simo Sorce e6b650a0d9 Check and propagate error
per_put_few_bits should be checked for errors.
Checked return, fund by coverity.

Signed-off-by: Simo Sorce <simo@redhat.com>
2017-03-26 05:00:01 -07:00
Simo Sorce 9cbd9b850e Remove dead code.
On the previous line we return if cb is Null, so testing cb is worthless.
Dead code, found by coverity.

Signed-off-by: Simo Sorce <simo@redhat.com>
2017-03-26 04:58:06 -07:00
Vasil Velichkov adf6594053 Fix "_BSD_SOURCE" redefined warning
../../skeletons/GeneralizedTime.c:7:0: warning: "_BSD_SOURCE" redefined [enabled by default]
 #define _BSD_SOURCE     /* for timegm(3) */
2017-03-26 04:47:14 -07:00
Vasil Velichkov d82f77b2d2 Fix few duplicate 'const' warnings
error: duplicate 'const' [-Werror=edantic]
2017-03-26 04:46:00 -07:00
Vasil Velichkov e318759ef2 Add code coverage using lcov and gcov
To generate the code coverage report you need gcov and lcov installed
and then execute

 ./configure --enable-code-coverage
 make check-code-coverage

 Writing directory view page.
 Overall coverage rate:
   lines......: 76.5% (10519 of 13759 lines)
   functions..: 85.5% (491 of 574 functions)
   branches...: 57.5% (7040 of 12250 branches)
 file:///home/user/asn1c/asn1c-0.9.28-coverage/index.html

Open the index.html with a web browser
2017-03-26 04:42:26 -07:00
Lev Walkin e088a2b07a Merge branch 'master' into windows-universal-build 2017-03-26 04:04:32 -07:00
Lev Walkin 9e0bf1b87a refer to defined macro 2017-03-26 04:03:43 -07:00
Lev Walkin d27d5b5e72 Merge pull request #89 from brchiu/unify_specs_variable_name
Unify the naming of asn_OCTET_STRING_specifics_t variables
2017-03-26 03:50:37 -07:00
Lev Walkin 9413414cdd better dir 2017-03-26 03:11:02 -07:00
Lev Walkin f3ecbcaaf2 Merge pull request #75 from devjoa/master
Fixed debug logging bug in per_get_few_bits.
2016-12-02 11:25:05 -08:00
Erika Thorsen 2aa10de1a8 Only remove __attributes__ in Windows builds 2016-11-28 08:35:08 +01:00
Erika Thorsen afea72f494 Include stdint.h instead of typedef types if Visual Studio 2010 or newer. 2016-11-14 07:55:19 +01:00
Erika Thorsen 8723dc7337 Removed __attribute__ since its not Windows compliant 2016-11-14 07:54:43 +01:00
Bi-Ruei, Chiu 419ac3a6ce Unify the naming of asn_OCTET_STRING_specifics_t with code-generated
'_specifics_t' variables to have 'asn_SPC_' prefix instead of 'asn_DEF_'
prefix.
2016-11-09 20:38:41 +08:00
Lev Walkin bce0ce4351 _BSD_SOURCE moved to a more global location 2016-07-02 23:51:32 -07:00
Lev Walkin eabd277f06 _BSD_SOURCE might be defined in unber.c 2016-07-02 23:22:58 -07:00
Lev Walkin 74757c8be3 avoid shifting negative value 2016-07-02 23:02:59 -07:00
Lev Walkin a6040115b3 unlock snprintf on some systems 2016-07-02 23:01:30 -07:00
Lev Walkin 619f0cd736 alloca.h is not universally available 2016-07-02 19:55:23 +00:00
Lev Walkin 0ec6b19a78 try to move it around for travis 2016-03-14 05:17:34 -07:00
Lev Walkin d60414d957 leave only skeleton flags 2016-03-14 05:11:57 -07:00
Lev Walkin 25307f6eb6 explicit stdio for snprintf 2016-03-14 04:44:03 -07:00
Lev Walkin 681f0590d0 DBL_TRUE_MIN is C11, make it portable 2016-03-14 04:21:26 -07:00
Lev Walkin 19a2118f3c alloca.h for alloca (c89) 2016-03-14 04:15:32 -07:00
Lev Walkin 7623d8c33e try to fetch timegm from the environment 2016-03-14 03:55:21 -07:00
Lev Walkin 7c1dc05f0e do not use reserved identifiers, contd 2016-03-14 03:08:19 -07:00
Lev Walkin c6cac8e958 do not use reserved identifiers 2016-03-14 02:57:34 -07:00
Lev Walkin 034ee194f4 no dereference before check 2016-03-14 02:28:33 -07:00
Lev Walkin 1ec7605500 do not use reserved identifiers for variables 2016-03-13 17:13:20 -07:00
Lev Walkin 8ca13c8a98 test subnormals 2016-01-24 22:40:00 -08:00
Lev Walkin 104af19d65 pedantic c89 safety 2016-01-24 22:13:27 -08:00
Lev Walkin 9736348c47 remove compiler warnings 2016-01-24 19:23:02 -08:00
devjoa 878c8b7311 Updated debug logging output in per_get_few_bits, because in some cases this caused a segment fault in the framework, due to a malformed message. 2015-12-17 11:11:13 +01:00
Lev Walkin 9d59a402a6 Merge pull request #50 from jariq/master
C89 compliant variable declaration
2015-09-14 13:49:35 -07:00
Lev Walkin 88152c8bd8 Merge pull request #66 from simo5/memleak
Avoid memory leak on error
2015-09-14 12:55:11 -07:00
Simo Sorce 4f47bf56d4 Keep static analyzers happy
Make it clear fall through is intentional.

Signed-off-by: Simo Sorce <simo@redhat.com>
2015-09-03 17:36:12 -04:00
Simo Sorce ce71d91898 Avoid memory leak on error
This was found on an internal Red Hat scan with multiple fuzzers.

Signed-off-by: Simo Sorce <simo@redhat.com>
2015-09-03 16:49:22 -04:00
Jaroslav Imrich 2253e6b45a C89 compliant variable declaration 2014-10-31 23:05:21 +01:00
Lev Walkin 33bab88802 Makefile.am is not needed here 2014-10-12 18:55:22 -07:00
Lev Walkin 3278995748 merged patch #31 2014-10-12 18:51:52 -07:00
Lev Walkin a7591b5c7f regenerated tests based on Wim L patch 2014-10-12 18:37:35 -07:00
Lev Walkin 78d604fe9e Merge pull request #46 from wiml/constify
Move as much data as possible into non-writable text by declaring it const
2014-10-12 18:30:33 -07:00
Lev Walkin 1b03c79368 removed autotools intermediate files from source code; use autoreconf -iv. 2014-10-12 17:31:26 -07:00
Lev Walkin 04fbe62bbc check if timegm is present before emulating 2014-09-17 02:27:01 -07:00
Lev Walkin 15d38f45df limit debug output log 2014-09-17 01:19:31 -07:00
Lev Walkin e0d321a650 version 0.9.26 2014-09-11 01:28:57 -07:00
Wim Lewis 59e8d2847e It's actually more efficient *not* to create a mutable static variable to hold this constant string's address. 2014-08-04 12:39:35 -07:00
Wim Lewis ca15fc6550 Avoid an unnecessary table lookup and its accompanying table (final_chunk_type[]). 2014-07-30 12:30:34 -07:00