osmocom
/
asn1c
mirror of https://gerrit.osmocom.org/asn1c
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove static qualifier from var in SET_OF__encode_sorted 

The function `SET_OF__encode_sorted` stored the working element buffer
in a static variable. If called recursively (that is, when performing
encoding of a SET containing another SET) the outermost element buffer
is therefore clobbered by the innermost call.

This causes a SEGV on continuation of the outermost call.

Bug found during testing of [https://github.com/surevine/spiffing Spiffing],
fix verified with the same test suite.
This commit is contained in:
Dave Cridland 2018-05-23 21:01:44 +01:00 committed by Lev Walkin
parent 6ccf7437af
commit cffe1b112a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
skeletons/constr_SET_OF.c
View File

@ -356,7 +356,7 @@ static struct _el_buffer *
SET_OF__encode_sorted(const asn_TYPE_member_t *elm,
const asn_anonymous_set_ *list,
enum SET_OF__encode_method method) {
static struct _el_buffer *encoded_els;
struct _el_buffer *encoded_els;
int edx;
encoded_els =