osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/ui
History
Peter Wu f5e22a1487 codecs: Add support for G.722 and G.726 
Integrate the Spandsp library for G.722 and G.726 support. Adds support
for G.722 and all eight variants of G.726.

Note: this also fixes a crash in Qt (buffer overrun, reading too much
data) caused by confusion of the larger output buffer (resample_buff)
with the smaller input buffer (decode_buff). It was not triggered before
because the sample rate was always 8k, but with the addition of the new
codecs, a different sample rate became possible (16k).

Fix also a crash which occurs when the RTP_STREAM_DEBUG macro is enabled
and the VOIP Calls dialog is opened (the begin frame, start_fd, is not
yet known and therfore a NULL dereference could occur).

Passes testing (plays normally without bad RTP timing errors) with
SampleCaptures files: sip-rtp-g722.pcap and sip-rtp-g726.pcap. Tested
with cmake (Qt), autotools (Qt and GTK+) with ASAN enabled.

Bug: 5619
Change-Id: I5661908d193927bba50901079119eeff0c04991f
Reviewed-on: https://code.wireshark.org/review/18939
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
 		2016-12-06 17:51:47 +00:00
..
cli Put tap-exportobject.h into the release tarball. 2016-12-02 18:28:43 +00:00
gtk codecs: Add support for G.722 and G.726 2016-12-06 17:51:47 +00:00
qt codecs: Add support for G.722 and G.726 2016-12-06 17:51:47 +00:00
win32 Have "All Capture Files" match only capture files. 2016-09-10 06:45:08 +00:00
.editorconfig Add EditorConfig settings for most C files 2016-03-08 10:46:35 +00:00
CMakeLists.txt Enable exporting objects with tshark 2016-12-02 16:07:35 +00:00
Makefile.am Enable exporting objects with tshark 2016-12-02 16:07:35 +00:00
alert_box.c Make failure_alert_box() be printf-like. 2016-03-27 02:06:28 +00:00
alert_box.h Make failure_alert_box() be printf-like. 2016-03-27 02:06:28 +00:00
all_files_wildcard.h Add a #define for the wildcard pattern that matches all files. 2016-03-01 02:00:25 +00:00
capture.c Allow "capture info data" to not be a singleton. 2015-12-19 14:22:56 +00:00
capture.h capture(.h): fix api reference 2016-01-26 09:10:25 +00:00
capture_globals.h Allow "capture info data" to not be a singleton. 2015-12-19 14:22:56 +00:00
capture_ui_utils.c Qt: Use uniform interface display name 2015-12-02 09:57:35 +00:00
capture_ui_utils.h Qt: Update selected interface filter behavior. 2016-02-26 17:28:04 +00:00
commandline.c Handle -K, -n, -N, and -u in the common dissection option code. 2016-10-31 05:05:50 +00:00
commandline.h Have routines for parsing options that affect dissection. 2016-10-30 22:57:16 +00:00
console.c More checks for localtime() and gmtime() returning NULL. 2016-10-22 02:27:32 +00:00
console.h
…
decode_as_utils.c Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
decode_as_utils.h Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
dissect_opts.c Handle -K, -n, -N, and -u in the common dissection option code. 2016-10-31 05:05:50 +00:00
dissect_opts.h Handle -K, -n, -N, and -u in the common dissection option code. 2016-10-31 05:05:50 +00:00
doxygen.cfg.in
…
export_object_ui.c Enable exporting objects with tshark 2016-12-02 16:07:35 +00:00
export_object_ui.h Enable exporting objects with tshark 2016-12-02 16:07:35 +00:00
export_pdu_ui_utils.c Allow create_tempfile to support a suffix. 2016-06-01 06:24:05 +00:00
export_pdu_ui_utils.h Implement Export PDU for tshark 2016-05-03 10:17:46 +00:00
file_dialog.h Add JSON export to Qt/GTK UI 2016-06-20 01:22:57 +00:00
firewall_rules.c Firewall rule fixups. 2016-06-06 06:27:47 +00:00
firewall_rules.h Qt: Firewall Rules dialog. 2016-06-01 23:37:25 +00:00
help_url.c Qt: Make "Learn" on the welcome screen clickable. 2016-10-22 06:32:50 +00:00
help_url.h Qt: Make "Learn" on the welcome screen clickable. 2016-10-22 06:32:50 +00:00
iface_lists.c *_stdup_printf -> strdup for "single string only" formatting. 2016-06-06 06:03:58 +00:00
iface_lists.h ui: Update interfaces when when changing profile. 2015-12-02 11:33:24 +00:00
io_graph_item.c
…
io_graph_item.h Place variable declarations where they're used. 2016-09-07 01:43:22 +00:00
language.c Use "system" for "use system language", and don't try to print a null string. 2016-04-28 19:34:02 +00:00
language.h Use "system" for "use system language", and don't try to print a null string. 2016-04-28 19:34:02 +00:00
last_open_dir.h
…
main_statusbar.h
…
mcast_stream.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
mcast_stream.h Fix crash in UDP Multicast Streams dialog 2015-11-27 21:15:11 +00:00
packet_list_utils.c Qt: Support "Resolve Names" with multiple custom column fields 2016-08-27 11:15:34 +00:00
packet_list_utils.h
…
persfilepath_opt.c
…
persfilepath_opt.h
…
preference_utils.c Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
preference_utils.h Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
profile.c profile_name_is_valid() returns a malloced string [-Wcast-qual] 2016-01-21 02:32:46 +00:00
profile.h profile_name_is_valid() returns a malloced string [-Wcast-qual] 2016-01-21 02:32:46 +00:00
progress_dlg.h const gpointer -> gconstpointer 2016-02-16 05:10:49 +00:00
proto_hier_stats.c Walk up the tree view of Protocol Hierarchy Statistics to look for protocol matches. 2016-03-12 03:05:07 +00:00
proto_hier_stats.h
…
recent.c Fix two warnings when compiling with rpcap support on macOS. 2016-10-30 08:44:25 +00:00
recent.h Use separate main geometry settings for Qt and GTK+. 2016-06-08 03:41:32 +00:00
recent_utils.h
…
rtp_media.c Start moving RTP decoding routines to the ui directory. 2015-09-19 15:02:16 +00:00
rtp_media.h Qt: fix jitter buffer management 2016-02-10 20:26:21 +00:00
rtp_stream.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
rtp_stream.h RTP player: increase the maximum number of silence frames to 30 minutes worth. 2016-06-23 03:30:39 +00:00
service_response_time.c
…
service_response_time.h
…
simple_dialog.h simple_dialog(.h): fix parameter 'Type' not found in the function declaration [-Wdocumentation] 2016-12-02 11:30:23 +00:00
software_update.c
…
software_update.h
…
ssl_key_export.c
…
ssl_key_export.h
…
tap-iax2-analysis.c Add the packet number to the packet_info structure, and use it. 2016-01-24 03:41:28 +00:00
tap-iax2-analysis.h Add the IAX2 Analysis dialog. 2015-09-09 21:57:08 +00:00
tap-rlc-graph.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
tap-rlc-graph.h Always supply a g_mallocated error message from select_rlc_lte_session(). 2015-12-29 08:01:54 +00:00
tap-rtp-analysis.h Move IAX2 analysis to the ui directory. 2015-09-03 21:48:48 +00:00
tap-rtp-common.c Move the proto data stuff out of frame_data.[ch]. 2016-01-25 02:24:34 +00:00
tap-rtp-common.h
…
tap-sctp-analysis.c SCTP: find right assoc id 2016-10-25 16:24:51 +00:00
tap-sctp-analysis.h SCTP: find right assoc id 2016-10-25 16:24:51 +00:00
tap-sequence-analysis.c Qt: Only color sequence analysis items having color filter 2016-10-02 17:55:40 +00:00
tap-sequence-analysis.h Qt: Only color sequence analysis items having color filter 2016-10-02 17:55:40 +00:00
tap-tcp-stream.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
tap-tcp-stream.h Qt: add initializers (CID 1162824). 2016-07-06 06:48:10 +00:00
tap_export_pdu.c Ensure to have a valid string pointer when writing OS SHB option 2016-07-26 13:48:40 +00:00
tap_export_pdu.h Implement Export PDU for tshark 2016-05-03 10:17:46 +00:00
text_import.c More checks for localtime() and gmtime() returning NULL. 2016-10-22 02:27:32 +00:00
text_import.h Make the Flex scanners and YACC parser in libraries reentrant. 2016-04-03 22:21:29 +00:00
text_import_scanner.h
…
text_import_scanner.l Include config.h at the very beginning of all Flex scanners. 2016-12-02 21:02:10 +00:00
time_shift.c Avoid unnecessary replacement source file floorl.c 2016-04-04 23:58:31 +00:00
time_shift.h
…
traffic_table_ui.c Qt: Conversation time column updates. 2016-09-02 23:53:37 +00:00
traffic_table_ui.h Qt: Conversation time column updates. 2016-09-02 23:53:37 +00:00
ui_util.h No need for toolkit-dependent color initialization. 2016-01-01 04:15:29 +00:00
util.c Replace and remove host_ip_af() function 2016-04-08 20:49:22 +00:00
util.h
…
voip_calls.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
voip_calls.h Qt: various fixes to VoIP calls / RTP player windows 2015-12-09 16:54:33 +00:00