osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/ui
History
naf eee907aeb5 QT ByteViewText: calculate string widths consistently to prevent clipping 
For QT >5.11, stringWidth() uses horizontalAdvance, which gives different
(longer) widths than the old boundingRect().width() method.

Other locations use the boundRect().width() method directly, resulting
in underestimating line widths and clipping the last characters in
the byte view window.

Fix by forcing all width calculations to use stringWidth().
Closes #17087.

(cherry picked from commit 95f3d1b075)

Conflicts:
	ui/qt/widgets/byte_view_text.cpp
 		2021-04-19 20:08:17 +02:00
..
cli Fix conversation table when using epoch based time 2021-04-15 14:27:02 +02:00
macosx macOS: Expand a comment. 2020-02-28 16:40:02 +00:00
qt QT ByteViewText: calculate string widths consistently to prevent clipping 2021-04-19 20:08:17 +02:00
win32 Qt: Add missing break in Win32 file export init dialog function 2020-12-12 13:50:54 +00:00
CMakeLists.txt HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
alert_box.c Have WTAP_ERR_INTERNAL include an err_info string giving details. 2020-10-14 04:51:45 +00:00
alert_box.h Have WTAP_ERR_INTERNAL include an err_info string giving details. 2020-10-14 04:51:45 +00:00
all_files_wildcard.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
capture.c Have WTAP_ERR_INTERNAL include an err_info string giving details. 2020-10-14 04:51:45 +00:00
capture.h ui/capture.h: add missing include to fix build with GCC 9.3 2020-05-04 11:22:22 +00:00
capture_globals.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
capture_info.h Move the last of the routines from capture_info.c into ui/capture.c. 2019-09-15 14:09:41 +00:00
capture_ui_utils.c Generate a dummy description if we don't have an interface name. 2020-05-03 21:22:17 +00:00
capture_ui_utils.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
clopts_common.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
clopts_common.h Reorganize long option values 2019-12-15 20:02:09 +00:00
cmdarg_err.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
cmdarg_err.h Move some command-line-oriented routines from wsutil to ui. 2019-01-01 02:07:06 +00:00
commandline.c Docs+help: Remove "-m". 2020-04-25 13:57:11 +00:00
commandline.h Move more version-info-related stuff to version_info.c. 2018-12-13 03:16:13 +00:00
console.c Windows: Console log handler fixups. 2019-03-14 21:15:08 +00:00
console.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
decode_as_utils.c Add FT_STRINGZTRUNC. 2020-09-12 14:16:12 -07:00
decode_as_utils.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
dissect_opts.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
dissect_opts.h Reorganize long option values 2019-12-15 20:02:09 +00:00
export_object_ui.c Don't fall out of the loop on a write error. 2019-01-02 23:56:33 +00:00
export_object_ui.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
export_pdu_ui_utils.c Clean up "Export PDUs to File" code. 2021-03-14 07:21:53 -07:00
export_pdu_ui_utils.h Clean up "Export PDUs to File" code. 2021-03-14 07:21:53 -07:00
failure_message.c Give more detail for WTAP_ERR_INTERNAL when writing. 2020-10-14 00:01:49 -07:00
failure_message.h Have WTAP_ERR_INTERNAL include an err_info string giving details. 2020-10-14 04:51:45 +00:00
file_dialog.c Add a new record type REC_TYPE_SYSTEMD_JOURNAL. 2020-10-28 04:16:42 +00:00
file_dialog.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
filter_files.c FilterFiles: Remove GTK+-only filter lists 2019-10-25 13:46:44 +00:00
filter_files.h FilterFiles: Remove GTK+-only filter lists 2019-10-25 13:46:44 +00:00
firewall_rules.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
firewall_rules.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
help_url.c g_mallocate all strings returned from topic_action_url(). 2020-10-04 12:56:52 -07:00
help_url.h Clean up URLs. 2020-10-02 20:13:42 -07:00
iface_lists.c Write the if_hardware option, if available, to pcapng files when capturing. 2020-03-28 03:34:18 +00:00
iface_lists.h Get rid of unused routine. 2018-08-11 07:52:06 +00:00
iface_toolbar.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
iface_toolbar.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
io_graph_item.c IO Graph shows unsigned values correctly 2020-01-18 12:17:24 +00:00
io_graph_item.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
language.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
language.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
last_open_dir.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
main_statusbar.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
mcast_stream.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
mcast_stream.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
packet_list_utils.c Qt: Enable "Resolve Names" for boolean without TFS 2018-08-22 03:58:16 +00:00
packet_list_utils.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_range.c Qt: Multiselection in PacketList 2019-11-17 12:20:29 +00:00
packet_range.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
persfilepath_opt.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
persfilepath_opt.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
preference_utils.c Qt: Check if "Apply as Column" column already exists 2020-07-15 03:57:01 +00:00
preference_utils.h Qt: Check if "Apply as Column" column already exists 2020-07-15 03:57:01 +00:00
profile.c Qt: Prevent loop in renames of profiles 2019-08-13 08:16:12 +00:00
profile.h Qt: Prevent loop in renames of profiles 2019-08-13 08:16:12 +00:00
progress_dlg.h file: remove use of g_get_current_time 2019-07-17 06:25:28 +00:00
proto_hier_stats.c file: remove use of g_get_current_time 2019-07-17 06:25:28 +00:00
proto_hier_stats.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
recent.c Qt: Add a recent item for packet diagram field values. 2020-10-28 20:22:45 +00:00
recent.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
recent_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
rtp_media.c codecs API: Added description of API usage 2019-12-30 15:41:00 +00:00
rtp_media.h Moving glib.h out of extern C 2021-03-16 02:07:58 -07:00
rtp_stream.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
rtp_stream.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
rtp_stream_id.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
rtp_stream_id.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
service_response_time.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
service_response_time.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
simple_dialog.h Qt: Add asynchronous simple dialog 2019-05-20 12:53:38 +00:00
software_update.c macOS: Software update fixes. 2020-02-28 04:50:38 +00:00
software_update.h Test+Qt: Add an automatic update check. 2020-02-15 11:13:25 +00:00
ssl_key_export.c Rename packet-ssl* to packet-tls* 2018-09-25 13:24:17 +00:00
ssl_key_export.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
summary.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
summary.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-credentials.h credentials: don't use wmem file scope but a local copy. 2019-07-05 12:26:44 +00:00
tap-iax2-analysis.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-iax2-analysis.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-rlc-graph.c Some more issues spotted by PVS-Studio in bug 16335. 2020-02-23 21:43:51 +00:00
tap-rlc-graph.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
tap-rtp-analysis.c Update URLs pointing to the bug database. 2020-10-03 07:54:12 -07:00
tap-rtp-analysis.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-rtp-common.c rtp_player: Player is able to set start of audio play by double click 2020-01-07 09:38:14 +00:00
tap-rtp-common.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
tap-sctp-analysis.c [SCTP] ui: fix Analyse Association with correct number of endpoint streams 2019-06-13 18:01:43 +00:00
tap-sctp-analysis.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
tap-tcp-stream.c Qt: Fix memory leak in TCP Stream Dialog 2020-04-14 15:35:55 +00:00
tap-tcp-stream.h Qt: Fix memory leak in TCP Stream Dialog 2020-04-14 15:35:55 +00:00
tap_export_pdu.c tap_export_pdu: free err_info for WTAP_ERR_INTERNAL. 2021-03-14 09:37:35 +00:00
tap_export_pdu.h Have WTAP_ERR_INTERNAL include an err_info string giving details. 2020-10-14 04:51:45 +00:00
taps.h Moving glib.h out of extern C 2021-03-16 02:07:58 -07:00
text_import.c More changes arising from PVS-Studio output. 2020-05-06 08:35:11 +00:00
text_import.h Text Import: update code comments and help texts 2019-01-21 21:03:49 +00:00
text_import_scanner.h Put back EOF rule, but without exporting write_current_packet(). 2019-03-20 16:06:57 +00:00
text_import_scanner.l Put back EOF rule, but without exporting write_current_packet(). 2019-03-20 16:06:57 +00:00
time_shift.c TimeShiftDialog should be considered an "edit" operation 2018-12-21 13:59:32 +00:00
time_shift.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
traffic_table_ui.c Don't cast away constness if you don't have to. 2019-03-17 22:10:10 +00:00
traffic_table_ui.h Re-implement "Map" feature for Endpoints 2019-02-16 21:11:12 +00:00
urls.h g_mallocate all strings returned from topic_action_url(). 2020-10-04 12:56:52 -07:00
util.c HTTPS In More Places, update some URLs. 2019-07-27 07:55:36 +00:00
util.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
voip_calls.c voip_calls_dialog/voip_calls: Fix for #16952 2020-12-29 20:03:55 +00:00
voip_calls.h Move still *more* headers outside of extern "C". 2021-03-16 15:03:17 -07:00
ws_ui_util.h Allow Multiselection of packets to work during live captures 2020-01-12 22:33:42 +00:00