forked from osmocom/wireshark
![Peter Wu](/assets/img/avatar_default.png)
The WRETH dissector showed up some garbage in the column display. Upon further inspection, it turns out that the format string had a trailing percent sign which caused (unsigned)-1 to be returned by g_printf_string_upper_bound (in emem_strdup_vprintf). Then ep_alloc is called with (unsigned)-1 + 1 = 0 memory, no wonder that garbage shows up. ASAN could not even catch this error because EP is in charge of this. So, start adding G_GNUC_PRINTF annotations in each header that uses the "fmt" or "format" paramters (grepped + awk). This revealed some other errors. The NCP2222 dissector was missing a format string (not a security vuln though). Many dissectors used val_to_str with a constant (but empty) string, these have been replaced by val_to_str_const. ASN.1 dissectors were regenerated for this. Minor: the mate plugin used "%X" instead of "%p" for a pointer type. The ncp2222 dissector and wimax plugin gained modelines. Change-Id: I7f3f6a3136116f9b251719830a39a7b21646f622 Reviewed-on: https://code.wireshark.org/review/2881 Reviewed-by: Evan Huus <eapache@gmail.com>
77 lines
2 KiB
C
77 lines
2 KiB
C
/*
|
|
* Wireshark - Network traffic analyzer
|
|
* By Gerald Combs <gerald@wireshark.org>
|
|
* Copyright 2001 Gerald Combs
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#ifndef DFILTER_INT_H
|
|
#define DFILTER_INT_H
|
|
|
|
#include "dfilter.h"
|
|
#include "syntax-tree.h"
|
|
|
|
#include <epan/proto.h>
|
|
#include <stdio.h>
|
|
|
|
/* Passed back to user */
|
|
struct epan_dfilter {
|
|
GPtrArray *insns;
|
|
GPtrArray *consts;
|
|
guint num_registers;
|
|
guint max_registers;
|
|
GList **registers;
|
|
gboolean *attempted_load;
|
|
int *interesting_fields;
|
|
int num_interesting_fields;
|
|
GPtrArray *deprecated;
|
|
};
|
|
|
|
typedef struct {
|
|
/* Syntax Tree stuff */
|
|
stnode_t *st_root;
|
|
gboolean syntax_error;
|
|
GPtrArray *insns;
|
|
GPtrArray *consts;
|
|
GHashTable *loaded_fields;
|
|
GHashTable *interesting_fields;
|
|
int next_insn_id;
|
|
int next_const_id;
|
|
int next_register;
|
|
int first_constant; /* first register used as a constant */
|
|
} dfwork_t;
|
|
|
|
/* Constructor/Destructor prototypes for Lemon Parser */
|
|
void *DfilterAlloc(void* (*)(gsize));
|
|
|
|
void DfilterFree(void*, void (*)(void *));
|
|
void Dfilter(void*, int, stnode_t*, dfwork_t*);
|
|
|
|
/* Scanner's lval */
|
|
extern stnode_t *df_lval;
|
|
|
|
/* Return value for error in scanner. */
|
|
#define SCAN_FAILED -1 /* not 0, as that means end-of-input */
|
|
|
|
/* Set dfilter_error_msg_buf and dfilter_error_msg */
|
|
void
|
|
dfilter_fail(const char *format, ...) G_GNUC_PRINTF(1, 2);
|
|
|
|
void
|
|
DfilterTrace(FILE *TraceFILE, char *zTracePrompt);
|
|
|
|
#endif
|