osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/extcap
History
Mikael Kanstrup 282b59a853 [RFC]androiddump: Support extcap-dlts option 
According to README.extcap documentation all extcap tools must
support the --extcap-dlts option. For performance reasons support
for this option was removed by commit:

9328eb6 androiddump: Register interfaces when list interfaces

A side effect of not implementing the option is that dumpcap is
then also called to try to retrieve interface capabilities
for all androiddump interfaces. As extcap interfaces are not
local network interfaces errors like these are logged
whenever the interface list is refreshed:

 Capture Dbg  sync_if_capabilities_open
 Capture Info sync_pipe_run_command() starts
 Capture Dbg    argv[0]: /usr/local/bin/wireshark/dumpcap
 Capture Dbg    argv[1]: -i
 Capture Dbg    argv[2]: android-tcpdump-wlan0...
 Capture Dbg    argv[3]: -L
 Capture Dbg    argv[4]: -Z
 Capture Dbg    argv[5]: none
 Capture Dbg  sync_pipe_open_command
 Capture Dbg  read 25 ok indicator: E len: 333 msg: E
 Capture Dbg  sync_pipe_wait_for_child: wait till child closed
 Capture Dbg  sync_pipe_wait_for_child: capture child closed after 0.000s
 Capture Info sync_pipe_run_command() ends, taking 0.012s, result=-1
 Capture Msg  Capture Interface Capabilities failed. Error -1, The
              capabilities of the capture device "android-tcpdump-wlan0..."
              could not be obtained (android-tcpdump-wlan0...:
              SIOCETHTOOL(ETHTOOL_GET_TS_INFO) ioctl failed: No such device).
              Please check to make sure you have sufficient permissions, and
              that you have the proper interface or pipe specified. ()

To avoid error prints and to fulfil the documented equirements for extcap
tools register a fake interface with what would be the properties of such
an interface.

Change-Id: If174adbb64c66132be4225f854bbf9f66d2f5ed1
Reviewed-on: https://code.wireshark.org/review/23093
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2017-10-16 04:29:21 +00:00
..
.editorconfig Move extcap EditorConfig settings to source dir 2016-03-23 00:24:52 +00:00
Makefile.am autotools: make maintainer-clean should allow rerunning 'configure' 2017-10-15 14:17:20 +00:00
androiddump.c [RFC]androiddump: Support extcap-dlts option 2017-10-16 04:29:21 +00:00
ciscodump.c extcap: add debug log file feature to extcap-base. 2017-08-02 17:41:24 +00:00
extcap-base.c plugins: config.h must not be included by public headers 2017-09-06 08:10:56 +00:00
extcap-base.h extcap: add debug log file feature to extcap-base. 2017-08-02 17:41:24 +00:00
randpktdump.c extcap: add debug log file feature to extcap-base. 2017-08-02 17:41:24 +00:00
ssh-base.c Some trivial fixes from running cppcheck. 2017-10-14 20:51:18 +00:00
ssh-base.h extcap: make extcap use the ws_strtoi/u functions. 2016-09-16 14:21:16 +00:00
sshdump.c Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
udpdump.c udpdump: Add missing include for timeval struct. 2017-09-25 16:42:17 +00:00