wireshark/wsutil/sign_ext.h
Jaap Keuter df551b8cb7 No need to operate on full bit width (CID 1355344 / 1355348)
When giving the full bit width to sign extend there's nothing
left, so return the value straight away (a NULL op).

Change-Id: I48e6612b6a7c89c0a9ddad0974bb83e7c8e0c22d
Reviewed-on: https://code.wireshark.org/review/14390
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-16 01:08:27 +00:00

81 lines
2.2 KiB
C

/*
* sign_ext.h
*
* Wireshark - Network traffic analyzer
* By Gerald Combs <gerald@wireshark.org>
* Copyright 1998 Gerald Combs
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
#ifndef __WSUTIL_SIGN_EXT_H__
#define __WSUTIL_SIGN_EXT_H__
#include <glib.h>
/* sign extension routines */
static inline guint32
ws_sign_ext32(guint32 val, int no_of_bits)
{
g_assert (no_of_bits >= 0 && no_of_bits <= 32);
if ((no_of_bits == 0) || (no_of_bits == 32))
return val;
/*
* Don't shift signed values left; that's not valid in C99, at
* least, if the value is negative or if the shift count is
* the number of bits in the value - 1, and we might get
* compile-time or run-time complaints about that.
*/
if (val & (1U << (no_of_bits-1)))
val |= (0xFFFFFFFFU << no_of_bits);
return val;
}
static inline guint64
ws_sign_ext64(guint64 val, int no_of_bits)
{
g_assert (no_of_bits >= 0 && no_of_bits <= 64);
if ((no_of_bits == 0) || (no_of_bits == 64))
return val;
/*
* Don't shift signed values left; that's not valid in C99, at
* least, if the value is negative or if the shift count is
* the number of bits in the value - 1, and we might get
* compile-time or run-time complaints about that.
*/
if (val & (G_GUINT64_CONSTANT(1) << (no_of_bits-1)))
val |= (G_GUINT64_CONSTANT(0xFFFFFFFFFFFFFFFF) << no_of_bits);
return val;
}
/*
static inline guint64
ws_sign_ext64(guint64 val, int no_of_bits)
{
gint64 sval = (val << (64 - no_of_bits));
return (guint64) (sval >> (64 - no_of_bits));
}
*/
#endif /* __WSUTIL_SIGN_EXT_H__ */