forked from osmocom/wireshark
5c2eade45d
Valgrind considers the "cpuid" instruction to always depend on inputs from eax and ecx, even though it's only a subset of values of eax for which ecx is relevant. If ecx is undefined when cpuid is executed, the outputs of cpuid will be considered undefined. Instead of suppressing the resulting uninitialised-value warning (the suppression for which is now out-of-date anyway, now that register_all_protocols is moved to a worker thread), let's simply set ecx to zero in ws_cpuid. Testing done: Built Wireshark on Linux amd64. Before this change, running "tools/valgrind-wireshark.sh ./test/captures/dhcp.pcap" with valgrind-3.12.0.SVN on Debian 9.4 amd64 would yield the following Valgrind error: ==2416== Thread 2: ==2416== Conditional jump or move depends on uninitialised value(s) ==2416== at 0xACB8B22: ws_mempbrk_sse42_compile (ws_mempbrk_sse42.c:58) ==2416== by 0x74F4960: register_all_protocols_worker (register.c:37) ==2416== by 0xB1403D4: g_thread_proxy (gthread.c:784) ==2416== by 0xD438493: start_thread (pthread_create.c:333) ==2416== by 0xB4CAACE: clone (clone.S:97) With the change, the above message is gone. Inspected the disassembly of function ws_cpuid, and it looks sane -- just an added "xor ecx, ecx" at the top. Change-Id: I2fb382309cac234c400286a6e9fac7d922912c63 Reviewed-on: https://code.wireshark.org/review/26733 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com> |
||
|---|---|---|
| .. | ||
| cppcheck | ||
| dftestfiles | ||
| dftestlib | ||
| json2pcap | ||
| lemon | ||
| npl | ||
| oss-fuzzshark | ||
| pidl | ||
| .gitattributes | ||
| Get-HardenFlags.ps1 | ||
| Makefile.am | ||
| SkinnyProtocolOptimized.xml | ||
| WiresharkXML.py | ||
| asn2deb | ||
| asn2wrs.py | ||
| checkAPIs.pl | ||
| checkfiltername.pl | ||
| checkhf.pl | ||
| checklicenses.py | ||
| colorfilters2js.pl | ||
| commit-msg | ||
| compare-abis.sh | ||
| compress-pngs.sh | ||
| convert-proto-tree-new.awk | ||
| convert_expert_add_info_format.pl | ||
| convert_proto_tree_add_text.pl | ||
| debian-nightly-package.sh | ||
| debian-setup.sh | ||
| delete_includes.py | ||
| dfilter-test.py | ||
| extract_asn1_from_spec.pl | ||
| fix-encoding-args.pl | ||
| fixhf.pl | ||
| ftsanity.py | ||
| fuzz-test.sh | ||
| gen-bugnote | ||
| generate-bacnet-vendors.py | ||
| generate-nl80211-fields.py | ||
| generate-sysdig-event.py | ||
| generate_authors.pl | ||
| git-compare-abis.sh | ||
| git-export-release.sh | ||
| gtk.suppression | ||
| html2text.py | ||
| idl2deb | ||
| idl2wrs | ||
| indexcap.py | ||
| install_rpms_for_devel.sh | ||
| lex.py | ||
| licensecheck.pl | ||
| list_protos_in_cap.sh | ||
| macos-setup-brew.sh | ||
| macos-setup.sh | ||
| make-manuf | ||
| make-pixbuf-csource.pl | ||
| make-plugin-reg.py | ||
| make-services.py | ||
| make-sminmpec.pl | ||
| make-tls-ct-logids.py | ||
| make-usb.py | ||
| make_charset_table.c | ||
| msnchat | ||
| msvc2015AdminDeployment.xml | ||
| ncp2222.py | ||
| netscreen2dump.py | ||
| parse_xml2skinny_dissector.py | ||
| pkt-from-core.py | ||
| pre-commit | ||
| pre-commit-ignore.conf | ||
| pre-commit-ignore.py | ||
| process-x11-fields.pl | ||
| process-x11-xcb.pl | ||
| randpkt-test.sh | ||
| rdps.py | ||
| release-update-debian-soversions.sh | ||
| rpm_setup.sh | ||
| test-captures.sh | ||
| test-common.sh | ||
| textify.ps1 | ||
| update-tx | ||
| usb-ptp-extract-models.pl | ||
| usb-ptp-extract-models.txt | ||
| valgrind-wireshark.sh | ||
| validate-diameter-xml.sh | ||
| vg-suppressions | ||
| win-setup.ps1 | ||
| wireshark_be.py | ||
| wireshark_gen.py | ||
| ws-coding-style.cfg | ||
| yacc.py | ||