wireshark/ui/gtk
Jeff Morriss 89cfdc3559 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 -
make Save-As/Displayed/All-Packets save not only the displayed packets but
also any other packets needed (e.g., for reassembly) to fully dissect the
displayed packets.

This works only for the "All packets" case; choosing only the Selected packet,
the Marked packets, or a range of packets would require actually storing which
packets depend on which (too much memory) or going through the packet list many
times (too slow).  Also, this behavior is always the case: you can't save the
displayed packets without their dependencies (I don't see why this would be
desirable).

So far this is done for SCTP and things using the reassembly routines (TCP has
been tested).

The Win32 dialog was modified but hasn't been tested yet.

One confusing aspect of the UI is that the Displayed count in the Save-As
dialog does not match the number of displayed packets.  (I tried renaming the
button "Displayed + Dependencies" but it looked too big.)  The tooltip tries
to explain this and the fact that this works only in the All-Packets case;
suggestions for improvement are welcome.


Implementation details:

Dissectors (or the reassembly code) can list frames which were needed to
build the current frame's tree.  If the current frame passes the display
filter then each listed frame is marked as "depended upon" (this takes up the
last free frame_data flag).

When performing a Save-As/Displayed/All-Packets then choose packets which
passed the dfilter _or_ are depended upon.

svn path=/trunk/; revision=41216
2012-02-28 03:19:49 +00:00
..
ui Copy over rev 40874 to gtk3 2012-02-06 11:22:21 +00:00
CMakeLists.txt Add the edit packet comment menu entry and the empty files 2012-02-12 14:56:06 +00:00
Makefile.am Fix tpo. 2012-02-20 00:01:21 +00:00
Makefile.common We already have GENERATED_HEADER_FILES; use that instead of 2012-02-19 22:41:53 +00:00
Makefile.nmake CVARSDLL hasn't been used (is undefined) for a while.... 2012-02-24 16:23:38 +00:00
Makefile_custom.common
STATUS.gtk3 Update the list of problems with gtk3 and where to find 2012-02-03 10:27:26 +00:00
about_dlg.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
about_dlg.h
afp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
airpcap_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
airpcap_dlg.h
airpcap_gui_utils.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
airpcap_gui_utils.h
ansi_a_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
ansi_map_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
bootp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
camel_counter.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
camel_srt.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
capture_dlg.c Re-apply r40728 and fix Coverity CID 1371 UNINIT again. 2012-02-27 00:25:41 +00:00
capture_dlg.h From Irene Ruengeler: 2012-02-21 11:59:41 +00:00
capture_file_dlg.c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - 2012-02-28 03:19:49 +00:00
capture_file_dlg.h
capture_globals.h
capture_if_details_dlg_win32.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
capture_if_details_dlg_win32.h
capture_if_dlg.c From Irene Ruengeler: 2012-02-21 11:59:41 +00:00
capture_if_dlg.h From Irene Ruengeler: 2012-02-21 11:59:41 +00:00
capture_info_dlg.c
cfilter_combo_utils.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
cfilter_combo_utils.h Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
color_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
color_dlg.h
color_edit_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
color_edit_dlg.h
color_utils.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
color_utils.h
compare_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
conversations_eth.c
conversations_fc.c
conversations_fddi.c
conversations_ip.c
conversations_ipv6.c
conversations_ipx.c
conversations_jxta.c
conversations_ncp.c
conversations_rsvp.c
conversations_sctp.c
conversations_table.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
conversations_table.h
conversations_tcpip.c
conversations_tr.c
conversations_udpip.c
conversations_usb.c
conversations_wlan.c
dcerpc_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
decode_as_ber.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
decode_as_ber.h
decode_as_dcerpc.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
decode_as_dcerpc.h
decode_as_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
decode_as_dlg.h
dfilter_expr_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
dfilter_expr_dlg.h
diameter_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
dissector_tables_dlg.c
dissector_tables_dlg.h
dlg_utils.c From Irene Ruengeler: 2012-02-21 11:59:41 +00:00
dlg_utils.h
doxygen.cfg.in
drag_and_drop.c include "../util.h" -> include "ui/util.h" 2012-02-17 12:46:50 +00:00
drag_and_drop.h
edit_packet_comment_dlg.c Mark an unused parameter. 2012-02-13 18:50:31 +00:00
edit_packet_comment_dlg.h Add the edit packet comment menu entry and the empty files 2012-02-12 14:56:06 +00:00
expert_comp_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
expert_comp_dlg.h
expert_comp_table.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
expert_comp_table.h
expert_indicators.h
export_object.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
export_object.h
export_object_dicom.c
export_object_http.c
export_object_smb.c
export_sslkeys.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
export_sslkeys.h
fc_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
file_dlg.c
file_dlg.h Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
file_import_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
file_import_dlg.h
fileset_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
fileset_dlg.h
filter_autocomplete.c
filter_autocomplete.h
filter_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
filter_dlg.h
filter_expression_save_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
filter_expression_save_dlg.h
filter_utils.c
filter_utils.h
find_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
find_dlg.h
firewall_dlg.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
firewall_dlg.h
flow_graph.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
follow_ssl.c include "../util.h" -> include "ui/util.h" 2012-02-17 12:46:50 +00:00
follow_ssl.h
follow_stream.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
follow_stream.h
follow_tcp.c From Dirk Leinenbach: 2012-02-23 13:24:54 +00:00
follow_tcp.h
follow_udp.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
follow_udp.h
font_utils.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
font_utils.h
funnel_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
goto_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
goto_dlg.h
graph_analysis.c include "../util.h" -> include "ui/util.h" 2012-02-17 12:46:50 +00:00
graph_analysis.h From Cristian Constantin: 2012-02-06 17:32:37 +00:00
gsm_a_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
gsm_map_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
gsm_map_stat.h
gsm_map_summary.c Suppress invalid or non-meaningful statistics - for example, without 2012-02-26 08:02:02 +00:00
gtkglobals.h
gtp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
gui_stat_menu.h
gui_stat_util.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
gui_stat_util.h
gui_utils.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
gui_utils.h Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
h225_counter.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
h225_ras_srt.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
help_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
help_dlg.h
hostlist_eth.c
hostlist_fc.c
hostlist_fddi.c
hostlist_ip.c
hostlist_ipv6.c
hostlist_ipx.c
hostlist_jxta.c
hostlist_ncp.c
hostlist_rsvp.c
hostlist_sctp.c
hostlist_table.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
hostlist_table.h
hostlist_tcpip.c
hostlist_tr.c
hostlist_udpip.c
hostlist_usb.c
hostlist_wlan.c
iax2_analysis.c include "../util.h" -> include "ui/util.h" 2012-02-17 12:46:50 +00:00
iax2_analysis.h
io_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
keys.h
ldap_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
libgtkui.vcproj Rename the (static) library built from stuff in ui/gtk to "libgtkui" in 2012-02-18 20:21:30 +00:00
mac_lte_stat_dlg.c Delete a TODO comment (now that there is an equivalent tshark tap). 2012-01-25 04:00:25 +00:00
macros_dlg.c
macros_dlg.h
main.c From Irene Ruengeler: Whitespace changes. 2012-02-24 12:54:15 +00:00
main.h Capitalize the "P" in "Packet" in "Add or Edit Packet Comment". Add 2012-02-12 23:09:14 +00:00
main_airpcap_toolbar.c Another fix for the move of recent.h to the ui directory. 2012-01-18 20:11:06 +00:00
main_airpcap_toolbar.h
main_filter_toolbar.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
main_filter_toolbar.h
main_menubar.c Capitalize the "P" in "Packet" in "Add or Edit Packet Comment". Add 2012-02-12 23:09:14 +00:00
main_proto_draw.c From Kundok Park: 2012-02-23 11:29:24 +00:00
main_proto_draw.h
main_statusbar.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
main_statusbar_private.h
main_toolbar.c No need to set new save icon if equal to previous icon. 2012-01-30 13:51:04 +00:00
main_toolbar.h Disable the save-as button in the toolbar if we cannot save-as, 2012-01-30 13:05:27 +00:00
main_welcome.c From Irene Ruengeler: 2012-02-21 11:59:41 +00:00
main_welcome.h From Irene Ruengeler: 2012-02-21 11:59:41 +00:00
manual_addr_resolv.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
manual_addr_resolv.h
mcast_stream.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
mcast_stream.h
mcast_stream_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
mcast_stream_dlg.h
megaco_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
menus.h Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
mgcp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
mtp3_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
mtp3_stat.h
mtp3_summary.c Suppress invalid or non-meaningful statistics - for example, without 2012-02-26 08:02:02 +00:00
ncp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
network_icons.h
new_packet_list.c Mark the file as unsaved when updating packet comments. 2012-02-27 15:38:34 +00:00
new_packet_list.h Edit packet comments 2012-02-13 17:33:05 +00:00
old-gtk-compat.h
packet_history.c
packet_history.h
packet_list_store.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
packet_list_store.h
packet_win.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
packet_win.h
pipe_icon.h Add icons for pipe interfaces. This allows for easier 2012-01-19 13:02:32 +00:00
pixmap_save.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
pixmap_save.h
plugins_dlg.c
plugins_dlg.h
prefs_capture.c Third try. This time pipes and stdin are supported and the 2012-01-25 13:04:32 +00:00
prefs_capture.h
prefs_column.c
prefs_column.h
prefs_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
prefs_dlg.h
prefs_filter_expressions.c Fix a typo in a comment .... 2012-01-15 23:26:23 +00:00
prefs_filter_expressions.h
prefs_gui.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
prefs_gui.h
prefs_layout.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
prefs_layout.h
prefs_nameres.c
prefs_nameres.h
prefs_print.c include "../util.h" -> include "ui/util.h" 2012-02-17 12:46:50 +00:00
prefs_print.h
prefs_protocols.c
prefs_protocols.h
prefs_stream.c
prefs_stream.h
prefs_taps.c Third try. This time pipes and stdin are supported and the 2012-01-25 13:04:32 +00:00
prefs_taps.h
print_dlg.c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - 2012-02-28 03:19:49 +00:00
profile_dlg.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
profile_dlg.h
progress_dlg.c Note that INIT_DELAY is .1 second. 2012-01-24 20:32:01 +00:00
proto_dlg.c include "../util.h" -> include "ui/util.h" 2012-02-17 12:46:50 +00:00
proto_dlg.h
proto_help.c
proto_help.h
proto_hier_stats_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
proto_hier_stats_dlg.h
radius_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
range_utils.c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - 2012-02-28 03:19:49 +00:00
range_utils.h Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - 2012-02-28 03:19:49 +00:00
remote_icons.h
rlc_lte_stat_dlg.c Add a link back to previous frame for UM sequence number analysis. 2012-02-03 10:42:01 +00:00
rpc_progs.c
rpc_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
rtp_analysis.c From Mark Cottrell: Attempting to view an RTP stream analysis graph causes program exit. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6866 2012-02-24 05:42:40 +00:00
rtp_analysis.h
rtp_player.c Sean Bright <sean.bright@gmail.com>: 2012-02-10 07:16:27 +00:00
rtp_player.h
rtp_stream.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
rtp_stream.h
rtp_stream_dlg.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
rtp_stream_dlg.h
sat.h
scsi_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_assoc_analyse.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_byte_graph_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_chunk_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_chunk_stat_dlg.c
sctp_error_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_graph_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sctp_stat.h
sctp_stat_dlg.c
service_response_time_table.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
service_response_time_table.h
simple_dialog.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
sip_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
smb2_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
smb_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
stats_tree_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
stock_icons.c More .. -> ../.. changes after gtk/ move 2012-01-15 22:40:03 +00:00
stock_icons.h
summary_dlg.c Mark the gile as unsaved if comments are edited 2012-02-26 19:54:58 +00:00
summary_dlg.h
supported_protos_dlg.c
supported_protos_dlg.h
tap_param_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
tap_param_dlg.h
tcp_graph.c Delete the TH_* defines and use those from epan/dissectors/packet-tcp.h. 2012-02-10 05:05:17 +00:00
text_import.c Revisit https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3161 2012-02-24 20:33:19 +00:00
text_import.h
text_import_scanner.h
text_import_scanner.l
text_page_utils.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
text_page_utils.h
time_shift_dlg.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
time_shift_dlg.h
uat_gui.c
uat_gui.h
utf8_entities.h
voip_calls.c Allways use g_list_prepend(). 2012-02-07 06:56:45 +00:00
voip_calls.h From Cristian Constantin: 2012-02-06 17:23:04 +00:00
voip_calls_dlg.c packet-gsm_sim.c was the wrong file to check in. 2012-02-07 09:06:44 +00:00
voip_calls_dlg.h
webbrowser.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
webbrowser.h
wlan_stat_dlg.c Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
wsp_stat.c Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00