wireshark/ui
Jeff Morriss 89cfdc3559 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 -
make Save-As/Displayed/All-Packets save not only the displayed packets but
also any other packets needed (e.g., for reassembly) to fully dissect the
displayed packets.

This works only for the "All packets" case; choosing only the Selected packet,
the Marked packets, or a range of packets would require actually storing which
packets depend on which (too much memory) or going through the packet list many
times (too slow).  Also, this behavior is always the case: you can't save the
displayed packets without their dependencies (I don't see why this would be
desirable).

So far this is done for SCTP and things using the reassembly routines (TCP has
been tested).

The Win32 dialog was modified but hasn't been tested yet.

One confusing aspect of the UI is that the Displayed count in the Save-As
dialog does not match the number of displayed packets.  (I tried renaming the
button "Displayed + Dependencies" but it looked too big.)  The tooltip tries
to explain this and the fact that this works only in the All-Packets case;
suggestions for improvement are welcome.


Implementation details:

Dissectors (or the reassembly code) can list frames which were needed to
build the current frame's tree.  If the current frame passes the display
filter then each listed frame is marked as "depended upon" (this takes up the
last free frame_data flag).

When performing a Save-As/Displayed/All-Packets then choose packets which
passed the dfilter _or_ are depended upon.

svn path=/trunk/; revision=41216
2012-02-28 03:19:49 +00:00
..
cli CVARSDLL hasn't been used (is undefined) for a while.... 2012-02-24 16:23:38 +00:00
gtk Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - 2012-02-28 03:19:49 +00:00
qt Start moving files to ui/ and ui/cli/ 2012-02-17 12:30:27 +00:00
win32 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - 2012-02-28 03:19:49 +00:00
Makefile.am We already have GENERATED_HEADER_FILES; no need for GENERATED_H_FILES. 2012-02-19 22:25:54 +00:00
Makefile.common We already have GENERATED_HEADER_FILES; no need for GENERATED_H_FILES. 2012-02-19 22:25:54 +00:00
Makefile.nmake CVARSDLL hasn't been used (is undefined) for a while.... 2012-02-24 16:23:38 +00:00
alert_box.h Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
doxygen.cfg.in Create a libui (static) library in the ui directory, which contains the 2012-02-18 23:55:41 +00:00
last_open_dir.h Add some files that didn't get checked in. 2012-01-18 19:47:44 +00:00
main_statusbar.h Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
progress_dlg.h Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
recent.h Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
recent_utils.h Add some files that didn't get checked in. 2012-01-18 19:47:44 +00:00
simple_dialog.h Move some headers for UI stuff, and the alert_box.c UI-specific file, to 2012-01-16 01:07:52 +00:00
ui_util.h Restructure the recent file code so that recent.c is GUI-independent; 2012-01-18 19:38:34 +00:00
util.c Start moving files to ui/ and ui/cli/ 2012-02-17 12:30:27 +00:00
util.h Start moving files to ui/ and ui/cli/ 2012-02-17 12:30:27 +00:00