osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/ui
History
Vasil Velichkov 88dd7e734a export_pdu.c: Fix a memory leak 
Allocate the exp_pdu_data using the wmem_packet_scope allocator so the
epan_dissect_run_with_taps will free it after calling all registered tap
listeners.

valgrind --tool=memcheck --leak-check=full ./run/tshark -r sctp.pcap -U "OSI layer 3" -w exported.pcap

32 bytes in 1 blocks are definitely lost in loss record 48 of 76
   at 0x4C2EBAB: malloc (vg_replace_malloc.c:299)
   by 0xB3FC3C5: g_malloc (gmem.c:99)
   by 0x68C2BE1: export_pdu_create_tags (exported_pdu.c:251)
   by 0x68C2D5E: export_pdu_create_common_tags (exported_pdu.c:231)
   by 0x70AA54E: create_exp_pdu_proto_name (packet-sctp.c:3240)
   by 0x70AA54E: export_sctp_data_chunk.part.23 (packet-sctp.c:3268)
   by 0x70AB76B: export_sctp_data_chunk (packet-sctp.c:3256)
   by 0x70AB76B: dissect_data_chunk (packet-sctp.c:3509)

Change-Id: I6e247ab2861bbb053f0958faf253913b28dbcbeb
Reviewed-on: https://code.wireshark.org/review/29126
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2018-08-14 11:47:29 +00:00
..
cli Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
macosx Qt: Enable Emoji & Symbols selector again 2018-04-10 07:37:08 +00:00
qt More interface view cleanups. 2018-08-12 01:56:23 +00:00
win32 packet export: Add default file extension 2018-06-27 23:01:03 +00:00
CMakeLists.txt RTP: Encapsulation of comparsion of two rtpstreams 2018-06-20 08:26:31 +00:00
alert_box.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
alert_box.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
all_files_wildcard.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
capture.c Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
capture.h Remove declaration of routine that no longer exists. 2018-03-03 06:31:42 +00:00
capture_globals.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
capture_ui_utils.c Put the interface descrptions into the IDB when capturing to pcapng. 2018-08-13 04:37:00 +00:00
capture_ui_utils.h Move get_iface_display_name() to ui/iface_lists.c. 2018-08-13 02:02:59 +00:00
commandline.c Remove a question from a comment. 2018-05-13 20:24:59 +00:00
commandline.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
console.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
console.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
decode_as_utils.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
decode_as_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
dissect_opts.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
dissect_opts.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
export_object_ui.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
export_object_ui.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
export_pdu_ui_utils.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
export_pdu_ui_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
failure_message.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
failure_message.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
file_dialog.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
file_dialog.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
filter_files.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
filter_files.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
firewall_rules.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
firewall_rules.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
help_url.c WSUG: Update the Follow Stream documentation. 2018-06-21 18:38:55 +00:00
help_url.h Qt: TCP Stream Graphs dialog updates. 2018-03-26 04:25:23 +00:00
iface_lists.c Move get_iface_display_name() to ui/iface_lists.c. 2018-08-13 02:02:59 +00:00
iface_lists.h Get rid of unused routine. 2018-08-11 07:52:06 +00:00
iface_toolbar.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
iface_toolbar.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
io_graph_item.c sharkd: add support for io graph. 2018-05-31 18:43:50 +00:00
io_graph_item.h sharkd: add support for io graph. 2018-05-31 18:43:50 +00:00
language.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
language.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
last_open_dir.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
main_statusbar.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
mcast_stream.c Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
mcast_stream.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_list_utils.c Qt: Right justify custom columns with multiple fields 2018-02-20 11:48:20 +00:00
packet_list_utils.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_range.c Qt: fix use-after-free on error while saving exported packets 2018-05-25 12:49:50 +00:00
packet_range.h Qt: fix use-after-free on error while saving exported packets 2018-05-25 12:49:50 +00:00
persfilepath_opt.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
persfilepath_opt.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
preference_utils.c Not GTK+-only any more. 2018-05-16 08:23:40 +00:00
preference_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
profile.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
profile.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
progress_dlg.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
proto_hier_stats.c Generalize wtap_pkthdr into a structure for packet and non-packet records. 2018-02-09 00:29:51 +00:00
proto_hier_stats.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
recent.c Remove an unused recent setting. 2018-06-18 22:59:41 +00:00
recent.h Remove an unused recent setting. 2018-06-18 22:59:41 +00:00
recent_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
rtp_media.c RTP: Code clean up 2018-06-19 15:05:12 +00:00
rtp_media.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
rtp_stream.c tshark/RTP: GUI dependency removed from register_tap_listener_rtpstream. As consequence of it a few functions were moved from ui/rtp_stream to ui/tap-rtp-common. 2018-06-22 05:35:43 +00:00
rtp_stream.h RTP: If multiple codecs are used in RTP stream flow, all are shown in codecs column 2018-06-28 00:46:39 +00:00
rtp_stream_id.c RTP: Encapsulation of comparsion of two rtpstreams 2018-06-20 08:26:31 +00:00
rtp_stream_id.h RTP: code cleanup 3 2018-06-23 10:03:54 +00:00
service_response_time.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
service_response_time.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
simple_dialog.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
software_update.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
software_update.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
ssl_key_export.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
ssl_key_export.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
summary.c Give a structure a better name. 2018-08-11 10:04:31 +00:00
summary.h Give a structure a better name. 2018-08-11 10:04:31 +00:00
tap-iax2-analysis.c tap-iax2-analysis: fix minor indentation issues. 2018-03-17 21:24:13 +00:00
tap-iax2-analysis.h RTP: Code clean up 2018-06-19 15:05:12 +00:00
tap-rlc-graph.c Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
tap-rlc-graph.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap-rtp-analysis.c RTP: Code clean up 2018-06-19 15:05:12 +00:00
tap-rtp-analysis.h RTP: Code cleanup 2 2018-06-20 13:19:46 +00:00
tap-rtp-common.c Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
tap-rtp-common.h tap-rtp-common: fix comma at end of enumerator list [-Wpedantic] 2018-07-05 02:45:16 +00:00
tap-sctp-analysis.c Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
tap-sctp-analysis.h SCTP: fix crash when filtering an association 2018-05-26 11:23:51 +00:00
tap-tcp-stream.c Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
tap-tcp-stream.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap_export_pdu.c export_pdu.c: Fix a memory leak 2018-08-14 11:47:29 +00:00
tap_export_pdu.h tap_export_pdu: Fix two memory leaks 2018-08-03 09:27:06 +00:00
taps.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
text_import.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
text_import.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
text_import_scanner.h Squelch redundant declaration warnings. 2018-02-16 22:40:26 +00:00
text_import_scanner.l spdx: more licenses converted. 2018-03-07 15:56:44 +00:00
time_shift.c Always explicitly set tm_isdst before calling mktime(). 2018-05-09 16:33:21 +00:00
time_shift.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
traffic_table_ui.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
traffic_table_ui.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
util.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
util.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
voip_calls.c Add a tap "finish" callback, called when a listener is removed. 2018-07-21 00:51:13 +00:00
voip_calls.h RTP: code cleanup 3 2018-06-23 10:03:54 +00:00
ws_ui_util.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00