osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/ui
History
Mikael Kanstrup 8873c7e494 iface_lists: Access all_ifaces member by reference 
Change access of all_ifaces elements from by val to by reference.
With this change unnecessary copying of the whole struct is avoided
but even more important is that elements no longer have to be
removed and inserted whenever data is updated.

This change aims to make it more clear that all_ifaces elements
shall never be removed from the array without freeing resources
via the capture_opts_free_interface_t function.

NOTE: Code for GTK UI not updated

Ping-Bug: 13864
Change-Id: I36742cb1d5c8daa136c9d3732a044a7c8e5c7fe7
Reviewed-on: https://code.wireshark.org/review/23201
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2017-08-28 14:41:43 +00:00
..
cli [sipstat] Update the Response Codes table. 2017-06-21 17:22:50 +00:00
gtk Fix requesting hardware timestamps without -k 2017-08-22 12:18:12 +00:00
qt iface_lists: Access all_ifaces member by reference 2017-08-28 14:41:43 +00:00
win32 print_stream: free memory on exit. 2017-02-27 13:25:26 +00:00
.editorconfig
…
CMakeLists.txt Qt: Add interface toolbar support 2017-04-25 06:19:39 +00:00
Makefile.am Qt: Add interface toolbar support 2017-04-25 06:19:39 +00:00
alert_box.c Take the error message generation out of the merge_files routines. 2017-04-20 20:25:59 +00:00
alert_box.h Take the error message generation out of the merge_files routines. 2017-04-20 20:25:59 +00:00
all_files_wildcard.h
…
capture.c iface_lists: Access all_ifaces member by reference 2017-08-28 14:41:43 +00:00
capture.h
…
capture_globals.h
…
capture_ui_utils.c Allow bigger snapshot lengths for D-Bus captures. 2017-06-05 05:28:26 +00:00
capture_ui_utils.h
…
commandline.c commandline: fix compilation without pcap. 2017-08-22 16:44:44 +00:00
commandline.h Add hardware timestamping support 2017-08-22 07:55:26 +00:00
console.c A bunch of "{Mac} OS X" -> "macOS" changes. 2017-04-05 19:16:22 +00:00
console.h
…
decode_as_utils.c Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
decode_as_utils.h Combine Decode As and port preferences for tcp.port dissector table. 2016-10-08 02:44:53 +00:00
dissect_opts.c Clean up handling of enabled/disabled protocols/heuristic dissectors. 2017-04-08 20:40:08 +00:00
dissect_opts.h Clean up handling of enabled/disabled protocols/heuristic dissectors. 2017-04-08 20:40:08 +00:00
doxygen.cfg.in
…
export_object_ui.c Enable exporting objects with tshark 2016-12-02 16:07:35 +00:00
export_object_ui.h Enable exporting objects with tshark 2016-12-02 16:07:35 +00:00
export_pdu_ui_utils.c cf_open() pops up a dialog box on errors; its callers shouldn't do so. 2017-04-20 18:47:34 +00:00
export_pdu_ui_utils.h
…
failure_message.c Use cfile_write_failure_message() in the randpkt code. 2017-04-20 21:07:35 +00:00
failure_message.h Have separate routines for open-for-reading and open-for-writing errors. 2017-04-20 18:24:20 +00:00
file_dialog.h Add JSON export to Qt/GTK UI 2016-06-20 01:22:57 +00:00
filter_files.c Fix weird comment. 2017-06-10 00:53:06 +00:00
filter_files.h Pull the error reporting into {read,save}_filter_list. 2017-04-09 17:57:52 +00:00
firewall_rules.c Firewall rule fixups. 2016-06-06 06:27:47 +00:00
firewall_rules.h Qt: Firewall Rules dialog. 2016-06-01 23:37:25 +00:00
help_url.c extcap: set help page for all extcaps. 2016-12-20 08:23:11 +00:00
help_url.h ui: move filesystem code to wsutil/filesystem.c 2016-12-09 15:50:04 +00:00
iface_lists.c iface_lists: Access all_ifaces member by reference 2017-08-28 14:41:43 +00:00
iface_lists.h
…
iface_toolbar.c Qt: Add interface toolbar support 2017-04-25 06:19:39 +00:00
iface_toolbar.h Qt: Interface Toolbar improvements 2017-05-02 09:34:01 +00:00
io_graph_item.c io_graph_item: fix false positive array subscript is above array bounds [-Werror=array-bounds] 2017-03-10 02:48:09 +00:00
io_graph_item.h Qt: support selecting the min/max packet from IO Graph 2017-04-05 09:27:32 +00:00
language.c
…
language.h
…
last_open_dir.h
…
main_statusbar.h
…
mcast_stream.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
mcast_stream.h
…
packet_list_utils.c Qt: Support "Resolve Names" with multiple custom column fields 2016-08-27 11:15:34 +00:00
packet_list_utils.h
…
packet_range.c Move UI-only stuff out of libwireshark. 2017-04-24 03:38:21 +00:00
packet_range.h Move UI-only stuff out of libwireshark. 2017-04-24 03:38:21 +00:00
persfilepath_opt.c
…
persfilepath_opt.h
…
preference_utils.c UI: Fix preference utils store helper 2017-07-04 15:13:59 +00:00
preference_utils.h Refactor range preference. 2017-01-07 15:35:18 +00:00
profile.c Clean up some memory leaks in wsutil/filesystem.c 2017-02-19 01:27:14 +00:00
profile.h
…
progress_dlg.h
…
proto_hier_stats.c Properly find packet comments "field" for protocol hierarchy stats. 2017-06-22 23:49:37 +00:00
proto_hier_stats.h
…
recent.c Qt: Add interface toolbar support 2017-04-25 06:19:39 +00:00
recent.h Qt: Add interface toolbar support 2017-04-25 06:19:39 +00:00
recent_utils.h
…
rtp_media.c
…
rtp_media.h
…
rtp_stream.c Revert "tap: change glib functions to wmem." 2016-06-19 10:47:10 +00:00
rtp_stream.h SIP/SDP, RTP: Dissectors shows information about ED-137 related states of radio in info column/VoIP call flow 2016-12-18 11:55:03 +00:00
service_response_time.c
…
service_response_time.h
…
simple_dialog.h Clean up handling of enabled/disabled protocols/heuristic dissectors. 2017-04-08 20:40:08 +00:00
software_update.c Qt+Win32: Make software updates more friendly. 2016-12-20 14:18:14 +00:00
software_update.h Qt+Win32: Make software updates more friendly. 2016-12-20 14:18:14 +00:00
ssl_key_export.c
…
ssl_key_export.h
…
tap-iax2-analysis.c
…
tap-iax2-analysis.h
…
tap-rlc-graph.c Rename routines to clarify what they do. 2017-04-12 04:56:49 +00:00
tap-rlc-graph.h
…
tap-rtp-analysis.h Save RTP audio to file: RTP Stream Analysis dialog allows save audio for non G.711 codecs and mixed codecs 2016-12-15 05:16:29 +00:00
tap-rtp-common.c [tap-rtp-common] Add EVS to mimetype_and_clock_map 2017-06-14 11:37:28 +00:00
tap-rtp-common.h
…
tap-sctp-analysis.c SCTP: find right assoc id 2016-10-25 16:24:51 +00:00
tap-sctp-analysis.h SCTP: find right assoc id 2016-10-25 16:24:51 +00:00
tap-sequence-analysis.c VoIP Calls/Flow Sequence: Fix of showing nodes from previous call 2016-12-15 05:16:56 +00:00
tap-sequence-analysis.h VoIP Calls/Flow Sequence: Fix of showing nodes from previous call 2016-12-15 05:16:56 +00:00
tap-tcp-stream.c Rename routines to clarify what they do. 2017-04-12 04:56:49 +00:00
tap-tcp-stream.h Qt: Add Goodput graph (ACK rate), and minor bug fixes 2017-01-22 14:41:49 +00:00
tap_export_pdu.c ERF_TYPE_META write and comment support 2017-07-17 02:08:52 +00:00
tap_export_pdu.h
…
text_import.c Check for localtime() failing. 2017-04-17 07:48:56 +00:00
text_import.h Allow bigger snapshot lengths for D-Bus captures. 2017-06-05 05:28:26 +00:00
text_import_scanner.h
…
text_import_scanner.l Include config.h at the very beginning of all Flex scanners. 2016-12-02 21:02:10 +00:00
time_shift.c
…
time_shift.h
…
traffic_table_ui.c Qt: update endpoint statistics column labels to match GTK ones 2017-03-28 13:43:18 +00:00
traffic_table_ui.h Qt: Conversation time column updates. 2016-09-02 23:53:37 +00:00
ui_util.h Move the declaration of packet_list_select_last_row() to ui/gtk/packet_list.h. 2016-12-12 21:12:58 +00:00
util.c
…
util.h
…
voip_calls.c [skinny]: minor changes to xml file 2017-08-21 15:28:02 +00:00
voip_calls.h
…