forked from osmocom/wireshark
f2b4daf400
The WRETH dissector showed up some garbage in the column display. Upon further inspection, it turns out that the format string had a trailing percent sign which caused (unsigned)-1 to be returned by g_printf_string_upper_bound (in emem_strdup_vprintf). Then ep_alloc is called with (unsigned)-1 + 1 = 0 memory, no wonder that garbage shows up. ASAN could not even catch this error because EP is in charge of this. So, start adding G_GNUC_PRINTF annotations in each header that uses the "fmt" or "format" paramters (grepped + awk). This revealed some other errors. The NCP2222 dissector was missing a format string (not a security vuln though). Many dissectors used val_to_str with a constant (but empty) string, these have been replaced by val_to_str_const. ASN.1 dissectors were regenerated for this. Minor: the mate plugin used "%X" instead of "%p" for a pointer type. The ncp2222 dissector and wimax plugin gained modelines. Change-Id: I7f3f6a3136116f9b251719830a39a7b21646f622 Reviewed-on: https://code.wireshark.org/review/2881 Reviewed-by: Evan Huus <eapache@gmail.com> |
||
|---|---|---|
| .. | ||
| Makefile.am | ||
| Makefile.common | ||
| Makefile.nmake | ||
| dfilter-int.h | ||
| dfilter-macro.c | ||
| dfilter-macro.h | ||
| dfilter.c | ||
| dfilter.h | ||
| dfunctions.c | ||
| dfunctions.h | ||
| dfvm.c | ||
| dfvm.h | ||
| drange.c | ||
| drange.h | ||
| gencode.c | ||
| gencode.h | ||
| grammar.lemon | ||
| scanner.l | ||
| semcheck.c | ||
| semcheck.h | ||
| sttype-function.c | ||
| sttype-function.h | ||
| sttype-integer.c | ||
| sttype-pointer.c | ||
| sttype-range.c | ||
| sttype-range.h | ||
| sttype-string.c | ||
| sttype-test.c | ||
| sttype-test.h | ||
| syntax-tree.c | ||
| syntax-tree.h | ||