wireshark/extcap
Mikael Kanstrup 66507b9052 [RFC]androiddump: Only filter CR/LFs on Windows
Comments in code claim:
"The data we are getting from the tcpdump stdoutput stream as the
 stdout is the text stream it is convertinng the 0A=0D0A; So we
 need to remove these extra character."

This is not true on non-Windows systems at least so avoid the filter
when not built for Windows.

NOTE: A problem with the filter is that it operates on all bytes
received on the socket, including packet data(!). Capturing
data with CR/LFs (for example an HTTP request) will fail. Ideally
the filter should be replaced with some other mechanism but as I
don't have a Windows system to verify that the comment claims are
valid, this change will at least make androiddump work on
non-Windows systems.

Bug: 13510
Change-Id: Ic00f44fa7516c0db7fc015ed8685deb365a347db
Reviewed-on: https://code.wireshark.org/review/22397
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
2017-06-26 11:17:30 +00:00
..
.editorconfig Move extcap EditorConfig settings to source dir 2016-03-23 00:24:52 +00:00
Makefile.am Use the cfile_ failure_message routines in androiddump. 2017-04-21 06:50:21 +00:00
androiddump.c [RFC]androiddump: Only filter CR/LFs on Windows 2017-06-26 11:17:30 +00:00
ciscodump.c Use glib-compat 2017-03-02 15:20:05 +00:00
extcap-base.c extcap: put missed parameters into the help 2016-10-19 06:44:05 +00:00
extcap-base.h Clean up some UN*X-vs-Windows socket issues. 2017-01-26 07:00:06 +00:00
randpktdump.c extcap: fix memleak via data_file_url 2017-01-07 20:32:43 +00:00
ssh-base.c extcap: make extcap use the ws_strtoi/u functions. 2016-09-16 14:21:16 +00:00
ssh-base.h extcap: make extcap use the ws_strtoi/u functions. 2016-09-16 14:21:16 +00:00
sshdump.c Use glib-compat 2017-03-02 15:20:05 +00:00
udpdump.c udpdump.c: Don't include epan headers. 2017-06-15 04:18:20 +00:00