wireshark/ui/qt
Gerald Combs 5ab8490088 Qt: Allow multiple lines in the packet list.
Remove the setUniformRowHeights(true) call in the PacketList
constructor. This means that the packet list now calculates its height
by querying the Qt::SizeHintRole for every item instead of simply
multiplying item_height * number_of_rows.

Implement SizeHintRole in PacketListModel::data so that size
calculations aren't unbearably slow. We don't have any row text until an
item is drawn (via DisplayRole), so items with multiple lines end up
being rendered twice. Note where we make assumptions on line heights.

Although we call gtk_tree_view_set_fixed_height_mode() in the GTK+ UI we
don't have this problem there. GTK+ is apparently less strict about
enforcing row heights.

Bug: 10924
Change-Id: I98e9f4f5f321c2e03f18498e0a7e7556f88792a1
Reviewed-on: https://code.wireshark.org/review/7430
Petri-Dish: Evan Huus <eapache@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-12 16:29:58 +00:00
..
CMakeLists.txt Qt: Add extra related packet indicator types. 2015-03-05 16:45:04 +00:00
Makefile.am Update the expert indicators. 2015-03-08 16:18:48 +00:00
Makefile.common build the list of .qm files from the list of .ts files 2015-03-03 11:41:36 +00:00
Makefile_custom.common
Wireshark.pro Qt: Add the "new packet" window^Wdialog^Wwindow. 2015-02-12 23:32:54 +00:00
about_dialog.cpp
about_dialog.h
about_dialog.ui Qt: Remove windowIcon property from our .ui files. 2015-01-23 19:15:29 +00:00
accordion_frame.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
accordion_frame.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
bluetooth_att_server_attributes_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
bluetooth_att_server_attributes_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
bluetooth_att_server_attributes_dialog.ui Bluetooth/GUI: ATT: Add Server Attribute Table 2015-02-07 16:35:39 +00:00
byte_view_tab.cpp Qt: fix heap use-after-free wrt. data sources 2015-03-08 21:56:42 +00:00
byte_view_tab.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
byte_view_text.cpp Byte view text (Qt): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 2015-03-02 19:02:24 +00:00
byte_view_text.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
capture_file.cpp Qt: Automatically scroll the packet list. 2015-02-27 20:27:14 +00:00
capture_file.h Qt: Fix a crash when changing the layout. 2015-02-24 00:42:22 +00:00
capture_file_dialog.cpp Qt: Apply recent settings. 2015-02-24 09:58:03 +00:00
capture_file_dialog.h
capture_file_properties_dialog.cpp Qt: Show the full file path in the status bar. 2015-03-05 00:49:11 +00:00
capture_file_properties_dialog.h
capture_file_properties_dialog.ui Qt: Remove windowIcon property from our .ui files. 2015-01-23 19:15:29 +00:00
capture_filter_combo.cpp Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
capture_filter_combo.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
capture_filter_edit.cpp
capture_filter_edit.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
capture_filter_syntax_worker.cpp
capture_filter_syntax_worker.h
capture_info_dialog.cpp
capture_info_dialog.h
capture_interfaces_dialog.cpp Qt: fix "Assigned value is garbage or undefined" 2015-02-16 02:32:05 +00:00
capture_interfaces_dialog.h
capture_interfaces_dialog.ui
capture_preferences_frame.cpp
capture_preferences_frame.h
capture_preferences_frame.ui
color_utils.cpp Qt: Add the Coloring Rules dialog. 2015-02-07 00:30:30 +00:00
color_utils.h Qt: Add the Coloring Rules dialog. 2015-02-07 00:30:30 +00:00
coloring_rules_dialog.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
coloring_rules_dialog.h Qt: Add the Coloring Rules dialog. 2015-02-07 00:30:30 +00:00
coloring_rules_dialog.ui Qt: Add the Coloring Rules dialog. 2015-02-07 00:30:30 +00:00
column_editor_frame.cpp
column_editor_frame.h
column_editor_frame.ui
column_preferences_frame.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
column_preferences_frame.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
column_preferences_frame.ui
compiled_filter_output.cpp
compiled_filter_output.h
compiled_filter_output.ui
conversation_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
conversation_dialog.h
decode_as_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
decode_as_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
decode_as_dialog.ui
display_filter_16.svg
display_filter_combo.cpp
display_filter_combo.h
display_filter_edit.cpp Clean up ftype-conversion and dfilter error message string handling. 2015-01-18 10:22:59 +00:00
display_filter_edit.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
doxygen.cfg.in
elided_label.cpp Qt: Show the full file path in the status bar. 2015-03-05 00:49:11 +00:00
elided_label.h Qt: ElidedLabel doesn't support rich text / HTML. 2015-02-13 00:50:20 +00:00
endpoint_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
endpoint_dialog.h
export_dissection_dialog.cpp
export_dissection_dialog.h
export_object_dialog.cpp
export_object_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
export_object_dialog.ui
export_pdu_dialog.cpp
export_pdu_dialog.h
export_pdu_dialog.ui
file_set_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
file_set_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
file_set_dialog.ui
filter_action.cpp Qt: Add the Protocol Hierarchy statistics dialog. 2015-02-04 02:06:01 +00:00
filter_action.h Qt: Add the Protocol Hierarchy statistics dialog. 2015-02-04 02:06:01 +00:00
filter_expressions_preferences_frame.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
filter_expressions_preferences_frame.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
filter_expressions_preferences_frame.ui
follow_stream_dialog.cpp ep_<protocol>_port_to_display -> <protocol>_port_to_display 2015-01-08 05:32:32 +00:00
follow_stream_dialog.h
follow_stream_dialog.ui
follow_stream_text.cpp
follow_stream_text.h
font_color_preferences_frame.cpp
font_color_preferences_frame.h
font_color_preferences_frame.ui
gpl-template.txt
i18n.qrc
import_text_dialog.cpp
import_text_dialog.h
import_text_dialog.ui
interface_tree.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
interface_tree.h
io_graph_dialog.cpp Get rid of an unused structure member. 2015-03-07 04:41:09 +00:00
io_graph_dialog.h Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
io_graph_dialog.ui Qt: Add the Coloring Rules dialog. 2015-02-07 00:30:30 +00:00
label_stack.cpp Qt: Paint elided LableStack text by hand. 2015-03-08 16:16:30 +00:00
label_stack.h Qt: Show the full file path in the status bar. 2015-03-05 00:49:11 +00:00
layout_preferences_frame.cpp
layout_preferences_frame.h
layout_preferences_frame.ui
lbm_lbtrm_transport_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
lbm_lbtrm_transport_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
lbm_lbtrm_transport_dialog.ui
lbm_lbtru_transport_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
lbm_lbtru_transport_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
lbm_lbtru_transport_dialog.ui
lbm_stream_dialog.cpp Qt: Add address conversion convenience routines 2015-01-29 22:51:43 +00:00
lbm_stream_dialog.h
lbm_stream_dialog.ui
lbm_uimflow_dialog.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
lbm_uimflow_dialog.h Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
lbm_uimflow_dialog.ui
main_status_bar.cpp Add the @2x expert indicators. 2015-03-08 18:12:06 +00:00
main_status_bar.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
main_welcome.cpp Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
main_welcome.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
main_welcome.ui Change a lot of http:// URLs to https://. 2015-03-10 19:30:50 +00:00
main_window.cpp Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
main_window.h Qt: Automatically scroll the packet list. 2015-02-27 20:27:14 +00:00
main_window.ui Qt: Automatically scroll the packet list. 2015-02-27 20:27:14 +00:00
main_window_preferences_frame.cpp
main_window_preferences_frame.h
main_window_preferences_frame.ui
main_window_slots.cpp Qt: Display only filename on status bar and display full path and size on tooltip 2015-03-05 16:57:31 +00:00
manage_interfaces_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
manage_interfaces_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
manage_interfaces_dialog.ui
module_preferences_scroll_area.cpp Qt: Escape ampersands in checkboxes and radio buttons. 2015-02-24 18:35:16 +00:00
module_preferences_scroll_area.h Qt: Escape ampersands in checkboxes and radio buttons. 2015-02-24 18:35:16 +00:00
module_preferences_scroll_area.ui
packet_comment_dialog.cpp
packet_comment_dialog.h
packet_comment_dialog.ui
packet_dialog.cpp Don't create a packet dialog if we don't have a packet. 2015-03-02 04:01:43 +00:00
packet_dialog.h Don't create a packet dialog if we don't have a packet. 2015-03-02 04:01:43 +00:00
packet_dialog.ui Qt: Add the "new packet" window^Wdialog^Wwindow. 2015-02-12 23:32:54 +00:00
packet_format_group_box.cpp
packet_format_group_box.h
packet_format_group_box.ui
packet_list.cpp Qt: Allow multiple lines in the packet list. 2015-03-12 16:29:58 +00:00
packet_list.h Qt: Add extra related packet indicator types. 2015-03-05 16:45:04 +00:00
packet_list_model.cpp Qt: Allow multiple lines in the packet list. 2015-03-12 16:29:58 +00:00
packet_list_model.h Qt: Allow multiple lines in the packet list. 2015-03-12 16:29:58 +00:00
packet_list_record.cpp Qt: Allow multiple lines in the packet list. 2015-03-12 16:29:58 +00:00
packet_list_record.h Qt: Allow multiple lines in the packet list. 2015-03-12 16:29:58 +00:00
packet_range_group_box.cpp Remove emem APIs from UAT functionality. 2015-01-12 14:25:12 +00:00
packet_range_group_box.h
packet_range_group_box.ui
preferences_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
preferences_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
preferences_dialog.ui
print_dialog.cpp
print_dialog.h
print_dialog.ui
profile_dialog.cpp Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
profile_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
profile_dialog.ui
progress_bar.cpp
progress_bar.h
progress_overlay.png
progress_overlay.svg
proto_tree.cpp ProtoTree: Fix crashes. 2015-03-09 21:33:29 +00:00
proto_tree.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
protocol_hierarchy_dialog.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
protocol_hierarchy_dialog.h Qt: Add "Copy As..." to the Protocol Hierarchy stats. 2015-02-04 18:26:01 +00:00
protocol_hierarchy_dialog.ui Qt: Add "Copy As..." to the Protocol Hierarchy stats. 2015-02-04 18:26:01 +00:00
qcustomplot.cpp Update Qt version checks. 2015-02-18 02:14:59 +00:00
qcustomplot.h
qt_ui_utils.cpp Qt: Fix a couple of resource leaks found by Coverity. 2015-03-06 04:05:26 +00:00
qt_ui_utils.h ui uitls (Qt): fix parameter 'val' not found in the function declaration [-Wdocumentation] 2015-03-10 07:21:25 +00:00
recent_file_status.cpp
recent_file_status.h
related_packet_delegate.cpp Qt: Add extra related packet indicator types. 2015-03-05 16:45:04 +00:00
related_packet_delegate.h Qt: Add extra related packet indicator types. 2015-03-05 16:45:04 +00:00
remote_capture_dialog.cpp
remote_capture_dialog.h
remote_capture_dialog.ui
remote_settings_dialog.cpp
remote_settings_dialog.h
remote_settings_dialog.ui
rtp_stream_dialog.cpp Fix RTP crash on RTP analysis attempt 2015-02-07 02:16:06 +00:00
rtp_stream_dialog.h Fix RTP crash on RTP analysis attempt 2015-02-07 02:16:06 +00:00
rtp_stream_dialog.ui Qt: Add the RTP Streams dialog. 2015-01-30 06:48:32 +00:00
sctp_all_assocs_dialog.cpp
sctp_all_assocs_dialog.h
sctp_all_assocs_dialog.ui
sctp_assoc_analyse_dialog.cpp Qt: Add address conversion convenience routines 2015-01-29 22:51:43 +00:00
sctp_assoc_analyse_dialog.h
sctp_assoc_analyse_dialog.ui Qt: Remove windowIcon property from our .ui files. 2015-01-23 19:15:29 +00:00
sctp_chunk_statistics_dialog.cpp uat_load() and uat_save() return a success indication; use it. 2015-01-13 21:01:28 +00:00
sctp_chunk_statistics_dialog.h
sctp_chunk_statistics_dialog.ui
sctp_graph_arwnd_dialog.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
sctp_graph_arwnd_dialog.h Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
sctp_graph_arwnd_dialog.ui
sctp_graph_byte_dialog.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
sctp_graph_byte_dialog.h Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
sctp_graph_byte_dialog.ui
sctp_graph_dialog.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
sctp_graph_dialog.h Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
sctp_graph_dialog.ui
search_frame.cpp Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
search_frame.h Qt: Constify a bunch of strings. 2015-03-05 20:17:29 +00:00
search_frame.ui
sequence_diagram.cpp Qt: Fix a couple of resource leaks found by Coverity. 2015-03-06 04:05:26 +00:00
sequence_diagram.h Qt: Fix a couple of resource leaks found by Coverity. 2015-03-06 04:05:26 +00:00
sequence_dialog.cpp
sequence_dialog.h
sequence_dialog.ui
simple_dialog.cpp Use plain old ASCII for the SimpleDialog delimiter. 2015-02-18 20:08:41 +00:00
simple_dialog.h
sparkline_delegate.cpp
sparkline_delegate.h
splash_overlay.cpp
splash_overlay.h
splash_overlay.ui
stats_tree_dialog.cpp
stats_tree_dialog.h
stats_tree_dialog.ui
stock_icon.cpp
stock_icon.h
syntax_line_edit.cpp Qt: Add the RTP Streams dialog. 2015-01-30 06:48:32 +00:00
syntax_line_edit.h Clean up ftype-conversion and dfilter error message string handling. 2015-01-18 10:22:59 +00:00
tango_colors.h
tcp_stream_dialog.cpp Qt: Add address conversion convenience routines 2015-01-29 22:51:43 +00:00
tcp_stream_dialog.h
tcp_stream_dialog.ui
time_shift_dialog.cpp
time_shift_dialog.h
time_shift_dialog.ui
toolbar_24.svg
traffic_table_dialog.cpp WSUG and image updates. 2015-02-14 19:47:03 +00:00
traffic_table_dialog.h Qt/C++: Change a bunch of includes to forward declarations. 2015-02-10 19:59:43 +00:00
traffic_table_dialog.ui
uat_dialog.cpp Fix handling of invalid UAT items 2015-02-15 23:52:24 +00:00
uat_dialog.h Qt: More #include → forward declarations. 2015-02-13 02:31:16 +00:00
uat_dialog.ui
voip_calls_dialog.cpp Qt: Fix side effects of recent WiresharkDialog changes. 2015-02-14 00:19:58 +00:00
voip_calls_dialog.h Qt: Fix side effects of recent WiresharkDialog changes. 2015-02-14 00:19:58 +00:00
voip_calls_dialog.ui
wireshark_application.cpp Qt: Apply recent settings. 2015-02-24 09:58:03 +00:00
wireshark_application.h Qt: Apply recent settings. 2015-02-24 09:58:03 +00:00
wireshark_de.qm TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_de.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_dialog.cpp Set a window icon for WiresharkDialog. 2015-02-17 20:30:52 +00:00
wireshark_dialog.h Qt: Fix side effects of recent WiresharkDialog changes. 2015-02-14 00:19:58 +00:00
wireshark_en.qm Qt: Update translation 2015-02-26 13:04:10 +00:00
wireshark_en.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_fr.qm TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_fr.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_it.qm TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_it.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_ja_JP.qm TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_ja_JP.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_pl.qm TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_pl.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_zh_CN.qm TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00
wireshark_zh_CN.ts TX: Update translations (Manual sync 2015-03-05) 2015-03-05 15:26:46 +00:00