wireshark/extcap
Martin Mathieson 569f3bd611 More PVS-Studio issues flagged by Valerii Zapodovnikov.
/opt/SourceCode/wireshark/epan/dissectors/packet-frame.c	818	warn	V547 Expression 'fi' is always true.
/opt/SourceCode/wireshark/epan/dissectors/packet-gsm_sms.c	2692	warn	V547 Expression 'length <= (offset - saved_offset)' is always false.
/opt/SourceCode/wireshark/epan/dissectors/packet-isup.c	4688	warn	V1037 Two or more case-branches perform the same actions. Check lines: 4688, 4697
/opt/SourceCode/wireshark/extcap/androiddump.c	1237	warn	V560 A part of conditional expression is always true: data_str.
/opt/SourceCode/wireshark/extcap/androiddump.c	1603	warn	V547 Expression is always true.
/opt/SourceCode/wireshark/ui/qt/models/packet_list_model.cpp	497	warn	V560 A part of conditional expression is always true: ok_r1.

For the voip_calls.c change, I preferred to initailize along with every other field, rather than set to actual value it gets set to later.

For the isobus-vt change, I could not find a spec but followed the pattern from other error bit fields.

Bug: 16335
Change-Id: Ie55082222b582f6fff4e8c7a992d863acee6cf15
Reviewed-on: https://code.wireshark.org/review/37160
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-05-09 11:34:12 +00:00
..
.editorconfig HTTPS In More Places, update some URLs. 2019-07-27 07:55:36 +00:00
CMakeLists.txt androiddump: Link against libwiretap and libwsutil 2020-01-25 10:05:27 +00:00
androiddump.c More PVS-Studio issues flagged by Valerii Zapodovnikov. 2020-05-09 11:34:12 +00:00
ciscodump.c More modeline fixes to put HT tab stops every 8 characters. 2020-03-15 16:14:49 +00:00
dpauxmon.c If you use data_file_url(), you must first call init_progfile_dir(). 2019-04-08 02:57:53 +00:00
dpauxmon_user.h extcap: Support for DisplayPort AUX channel monitors 2018-05-14 10:44:37 +00:00
extcap-base.c More modeline fixes to put HT tab stops every 8 characters. 2020-03-15 16:14:49 +00:00
extcap-base.h Put the main() and wmain() routines for CLI programs into a separate file. 2018-12-13 00:52:11 +00:00
randpktdump.c Revert "CMake: Don't install HTML manuals twice" 2019-10-10 15:58:41 +00:00
sdjournal.c Revert "CMake: Don't install HTML manuals twice" 2019-10-10 15:58:41 +00:00
ssh-base.c ssh-base: fix no previous prototype for ‘extcap_log’ [-Wmissing-prototypes] 2018-12-26 20:14:37 +00:00
ssh-base.h extcap: save debug flag and use it to activate ssh debug. 2018-11-14 04:58:38 +00:00
sshdump.c sshdump: Use Open dialog for SSH private key 2020-04-15 14:27:21 +00:00
udpdump.c extcap: Fix packet time calculation 2020-02-10 07:45:33 +00:00