forked from osmocom/wireshark
![Guy Harris](/assets/img/avatar_default.png)
It really shouldn't free the comment passed to it, as the caller allocated it, and knows how to free it if necessary; it might not even have been allocated. Make the comment argument a "const char *" to 1) allow passing string constants etc. and 2) to catch any attempts to free it in exp_pdu_open(). Make the callers free it after exp_pdu_open() returns. (Alternatively, we could have exp_pdu_open() take the file name argument and generate the comment itself, so that all code paths generate the same comment.) Change-Id: I6e6924b05565761b641a6c3b4d9a2e97f4264e1b Ping-Bug: 15365 Reviewed-on: https://code.wireshark.org/review/31105 Reviewed-by: Guy Harris <guy@alum.mit.edu>
67 lines
1.7 KiB
C
67 lines
1.7 KiB
C
/* tap_export_pdu.h
|
|
* Routines for exporting PDUs to file
|
|
*
|
|
* Wireshark - Network traffic analyzer
|
|
* By Gerald Combs <gerald@wireshark.org>
|
|
* Copyright 1998 Gerald Combs
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
|
|
#ifndef __TAP_EXPORT_PDU_H__
|
|
#define __TAP_EXPORT_PDU_H__
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif /* __cplusplus */
|
|
|
|
typedef struct _exp_pdu_t {
|
|
int pkt_encap;
|
|
wtap_dumper* wdh;
|
|
GArray* shb_hdrs;
|
|
wtapng_iface_descriptions_t* idb_inf;
|
|
} exp_pdu_t;
|
|
|
|
/**
|
|
* Registers the tap listener which will add matching packets to the exported
|
|
* file. Must be called before exp_pdu_open.
|
|
*
|
|
* @param tap_name One of the names registered with register_export_pdu_tap().
|
|
* @param filter An tap filter, may be NULL to disable filtering which
|
|
* improves performance if you do not need a filter.
|
|
* @return NULL on success or an error string on failure which must be freed
|
|
* with g_free(). Failure could occur when the filter or tap_name are invalid.
|
|
*/
|
|
char *exp_pdu_pre_open(const char *tap_name, const char *filter,
|
|
exp_pdu_t *exp_pdu_tap_data);
|
|
|
|
/**
|
|
* Use the given file descriptor for writing an output file. Can only be called
|
|
* once and exp_pdu_pre_open() must be called before.
|
|
*
|
|
* @return 0 on success or a wtap error code.
|
|
*/
|
|
int exp_pdu_open(exp_pdu_t *data, int fd, const char *comment);
|
|
|
|
/* Stops the PDUs export. */
|
|
int exp_pdu_close(exp_pdu_t *exp_pdu_tap_data);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif /* __cplusplus */
|
|
|
|
#endif /* __TAP_EXPORT_PDU_H__ */
|
|
|
|
/*
|
|
* Editor modelines
|
|
*
|
|
* Local Variables:
|
|
* c-basic-offset: 4
|
|
* tab-width: 8
|
|
* indent-tabs-mode: nil
|
|
* End:
|
|
*
|
|
* ex: set shiftwidth=4 tabstop=8 expandtab:
|
|
* :indentSize=4:tabSize=8:noTabs=true:
|
|
*/
|