Jaap Keuter 3f0fc1b232 FC: use ETHERTYPE_UNK when applicable, no excuses ... Two interlocking problems cause the dissection of FC to fail in some cases, as shown in the capture of the related issue. The FC dissector assumes that ETHERTYPE_UNK in the data structure passed to it is coming from the MDS header dissector only, and thus that header sizes have to be taken into account. This is not / no longer the case. It always passes down ETHERTYPE_FCFT. Therefore the MDS header size checking does not apply to ETHERTYP_UNK, so is removed as condition. The other FC related dissectors were forced to setup a data structure to pass to FC for it to handle that part of the frame. Because these weren't related to ethernet, these lazily set the ethertype field in the data structure to 0. This unfortunately matches ETHERTYPE_UNK, triggering the MDS header size checking in FC, leading to this issue. With the first problem resolved, now make it explicit that unknown ethertype is indicated by ETHERTYPE_UNK, not '0'. Addresses primary part of issue #17084		2020-12-15 20:26:29 +00:00
..
crypt	dot11decrypt_util: Avoid abusing memory layout	2020-12-09 22:54:42 -05:00
dfilter	Add FT_STRINGZTRUNC.	2020-09-12 14:16:12 -07:00
dissectors	FC: use ETHERTYPE_UNK when applicable, no excuses	2020-12-15 20:26:29 +00:00
ftypes	Add FT_STRINGZTRUNC.	2020-09-12 14:16:12 -07:00
wmem	Replace ill-formed UTF-8 byte sequences with replacement character	2020-10-15 21:48:28 +00:00
wslua	Lua: Add get_preference() and set_preference() utility functions.	2020-12-08 22:56:50 +00:00
.editorconfig	…
CMakeLists.txt	Protobuf: rewrite parser of *.proto file from Bison to Lemon	2020-11-18 08:57:01 +00:00
addr_and_mask.c	epan: access a ws_in4_addr byte by byte.	2020-04-16 17:11:59 +00:00
addr_and_mask.h	wsutil: use ws_in4_addr in tvb_get_ipv4_addr_with_prefix_len.	2020-04-14 08:31:11 +00:00
addr_resolv.c	Addr Resolv: Prefer profile specific file if exists	2020-11-17 18:17:48 +00:00
addr_resolv.h	Edit Resolved Name: Don't add duplicate IPs	2020-02-24 07:45:00 +00:00
address.h	…
address_types.c	…
address_types.h	…
afn.c	…
afn.h	…
aftypes.c	…
aftypes.h	…
app_mem_usage.c	…
app_mem_usage.h	…
arcnet_pids.h	…
arptypes.h	ARP: expand the set of ARPHRD_ definitions from both IANA and Linxu.	2020-05-09 12:08:54 +00:00
asn1.c	…
asn1.h	…
ax25_pids.h	…
bridged_pids.h	…
capture_dissectors.c	…
capture_dissectors.h	…
charsets.c	windows-common: fix Clang	2020-11-19 19:01:53 +00:00
charsets.h	Use iconv to support GB 18030 and EUC-KR, allow future encodings	2020-10-21 11:26:23 +00:00
chdlctypes.h	…
cisco_pid.h	…
color_filters.c	wslua: Add ability to query current temporary color filter text	2020-06-25 08:02:27 +00:00
color_filters.h	wslua: Add ability to query current temporary color filter text	2020-06-25 08:02:27 +00:00
column-info.h	column-info.h : increase COL_MAX_LEN from 256 to 2048	2020-12-04 16:11:37 +00:00
column-utils.c	Handle relative times with >2^31 seconds.	2020-10-18 02:06:07 -07:00
column-utils.h	…
column.c	…
column.h	…
conv_id.h	…
conversation.c	conversation: use wmem_new0 instead of memset.	2020-04-14 06:03:33 +00:00
conversation.h	…
conversation_debug.h	…
conversation_filter.c	…
conversation_filter.h	…
conversation_table.c	…
conversation_table.h	…
crc6-tvb.c	…
crc6-tvb.h	…
crc8-tvb.c	…
crc8-tvb.h	…
crc10-tvb.c	…
crc10-tvb.h	…
crc16-tvb.c	…
crc16-tvb.h	…
crc32-tvb.c	…
crc32-tvb.h	…
decode_as.c	Add FT_STRINGZTRUNC.	2020-09-12 14:16:12 -07:00
decode_as.h	epan: Keep decode_as_list when changing profile	2020-06-29 18:40:27 +00:00
diam_dict.h	…
diam_dict.l	…
disabled_protos.c	…
disabled_protos.h	…
dtd.h	…
dtd_grammar.lemon	…
dtd_parse.h	…
dtd_parse.l	…
dtd_preparse.l	epan DTD parser: don't leak the full path string on error.	2020-05-02 22:18:58 +00:00
dvb_chartbl.c	…
dvb_chartbl.h	…
eap.h	Add a few EAP dissectors	2020-09-21 15:05:05 +00:00
eapol_keydes_types.h	…
epan.c	epan: Keep decode_as_list when changing profile	2020-06-29 18:40:27 +00:00
epan.h	…
epan_dissect.h	…
etypes.h	New dissector: Added support for IEEE 802.1CB R-Tags (EtherType 0xF1C1)	2020-10-15 13:51:51 +02:00
ex-opt.c	…
ex-opt.h	…
except.c	…
except.h	…
exceptions.h	Stylistic consistency.	2020-04-09 22:16:02 +00:00
exntest.c	…
expert.c	…
expert.h	Clean up URLs.	2020-10-02 20:13:42 -07:00
export_object.c	Fix memory leak in export_object.c	2020-05-02 21:41:09 +00:00
export_object.h	…
exported_pdu.c	Replace instances of wmem_alloc with wmem_new	2020-08-08 09:54:29 +00:00
exported_pdu.h	…
filter_expressions.c	…
filter_expressions.h	…
follow.c	…
follow.h	Add all supported charsets to Show Packet Bytes/Follow Stream	2020-07-06 14:21:41 +00:00
frame_data.c	Add a new record type REC_TYPE_SYSTEMD_JOURNAL.	2020-10-27 20:06:26 -07:00
frame_data.h	…
frame_data_sequence.c	…
frame_data_sequence.h	…
funnel.c	…
funnel.h	wslua: Add ability to query current temporary color filter text	2020-06-25 08:02:27 +00:00
garrayfix.h	…
golay.c	…
golay.h	…
guid-utils.c	…
guid-utils.h	…
iana_charsets.c	…
iana_charsets.h	…
iax2_codec_type.h	…
in_cksum.c	…
in_cksum.h	…
ip_opts.h	…
ipproto.c	…
ipproto.h	…
ipv4.h	…
ipv6.h	…
lapd_sapi.h	…
llcsaps.h	…
maxmind_db.c	…
maxmind_db.h	…
media_params.c	…
media_params.h	…
next_tvb.c	…
next_tvb.h	…
nlpid.h	…
oids.c	SNMP: Use BASE_SHOW_ASCII_PRINTABLE for octet strings	2020-10-10 13:28:06 +00:00
oids.h	…
oids_test.c	tests: Try to squelch [-Wpointer-sign] warnings.	2020-07-01 10:01:39 +00:00
osi-utils.c	…
osi-utils.h	…
oui.h	ieee80211: add VS SGDSN type 1 message	2020-07-08 06:29:00 +00:00
packet.c	Fix a few spelling mistakes.	2020-11-12 09:52:52 +00:00
packet.h	sll: add support for LINKTYPE_LINUX_SLL2.	2020-05-09 03:14:50 +00:00
packet_info.h	…
params.h	…
plugin_if.c	plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()	2020-08-22 05:32:29 +00:00
plugin_if.h	plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()	2020-08-22 05:32:29 +00:00
ppptypes.h	…
prefs-int.h	Lua: Add get_preference() and set_preference() utility functions.	2020-12-08 22:56:50 +00:00
prefs.c	Lua: Add get_preference() and set_preference() utility functions.	2020-12-08 22:56:50 +00:00
prefs.h	QT/CLI: Move max tree items and depth to prefs	2020-10-23 04:18:36 +00:00
print.c	XML Escaping: Don't need to escape unprintable chars.	2020-10-20 05:32:29 +00:00
print.h	…
print.ps	…
print_stream.c	…
print_stream.h	…
proto.c	Qt: Prevent multiple check marks in custom column	2020-12-04 17:16:15 +00:00
proto.h	Introduce ENC_BCD_ODD_NUM_DIG in order to handle odd number of digits	2020-12-10 16:02:10 +01:00
proto_data.c	epan: Add p_[gs]et_proto_depth.	2020-04-15 04:09:08 +00:00
proto_data.h	epan: Add p_[gs]et_proto_depth.	2020-04-15 04:09:08 +00:00
protobuf-helper.c	Protobuf: rewrite parser of *.proto file from Bison to Lemon	2020-11-18 08:57:01 +00:00
protobuf-helper.h	Protobuf: rewrite parser of *.proto file from Bison to Lemon	2020-11-18 08:57:01 +00:00
protobuf_lang_parser.lemon	Fix various spelling errors.	2020-12-09 05:52:50 +00:00
protobuf_lang_scanner.l	Protobuf: rewrite parser of *.proto file from Bison to Lemon	2020-11-18 08:57:01 +00:00
protobuf_lang_tree.c	Protobuf: rewrite parser of *.proto file from Bison to Lemon	2020-11-18 08:57:01 +00:00
protobuf_lang_tree.h	Protobuf: rewrite parser of *.proto file from Bison to Lemon	2020-11-18 08:57:01 +00:00
ps.h	…
ptvcursor.h	…
radius_dict.l	…
range.c	…
range.h	…
reassemble.c	Reassembly: Flag duplicate packets as overlaps in offset based reassembly	2020-12-10 07:18:59 +00:00
reassemble.h	…
reassemble_test.c	Reassembly: Flag duplicate packets as overlaps in offset based reassembly	2020-12-10 07:18:59 +00:00
reedsolomon.c	…
reedsolomon.h	…
register-int.h	…
register.c	…
register.h	…
req_resp_hdrs.c	…
req_resp_hdrs.h	…
rtd_table.c	…
rtd_table.h	…
rtp_pt.h	…
sctpppids.h	SCTP: update PPI values	2020-10-06 19:19:09 +00:00
secrets.c	Fix UAT PKCS #11 Library handle leak	2020-01-15 04:52:04 +00:00
secrets.h	…
sequence_analysis.c	…
sequence_analysis.h	…
show_exception.c	…
show_exception.h	…
slow_protocol_subtypes.h	…
sminmpec.h	added fastip (Boundary) enterprise ID	2020-04-03 06:50:15 +00:00
srt_table.c	…
srt_table.h	…
stat_groups.h	…
stat_tap_ui.c	…
stat_tap_ui.h	…
stats_tree.c	…
stats_tree.h	…
stats_tree_priv.h	…
stream.c	…
stream.h	…
strutil.c	epan: Fix format_text treament of Greek, Arabic, etc.	2020-12-09 12:51:19 +00:00
strutil.h	Add format_text_string(), which gets the length with strlen().	2020-08-20 07:24:32 +00:00
t35.c	…
t35.h	…
tap-voip.h	…
tap.c	…
tap.h	…
tfs.c	TFS: Add some commonly-defined string pairs to tfs.c	2020-08-17 02:58:01 +00:00
tfs.h	TFS: Add some commonly-defined string pairs to tfs.c	2020-08-17 02:58:01 +00:00
time_fmt.h	…
timestamp.c	…
timestamp.h	…
timestats.c	…
timestats.h	…
to_str-int.h	…
to_str.c	epan: Limit our bits in decode_bits_in_field.	2020-11-07 19:51:20 +00:00
to_str.h	Handle relative times with >2^31 seconds.	2020-10-18 02:06:07 -07:00
tvbparse.c	Replace instances of wmem_alloc with wmem_new	2020-08-08 09:54:29 +00:00
tvbparse.h	…
tvbtest.c	tests: Try to squelch [-Wpointer-sign] warnings.	2020-07-01 10:01:39 +00:00
tvbuff-int.h	…
tvbuff.c	Introduce ENC_BCD_ODD_NUM_DIG in order to handle odd number of digits	2020-12-10 16:02:10 +01:00
tvbuff.h	Introduce ENC_BCD_ODD_NUM_DIG in order to handle odd number of digits	2020-12-10 16:02:10 +01:00
tvbuff_base64.c	tvb: Add base64_tvb_to_new_tvb()	2020-11-25 22:09:06 +00:00
tvbuff_brotli.c	…
tvbuff_composite.c	composite_tvb: fix memory leak when tvb_composite_finalize is not called	2020-06-01 03:40:57 +00:00
tvbuff_lz77.c	…
tvbuff_lz77huff.c	…
tvbuff_lznt1.c	…
tvbuff_real.c	…
tvbuff_subset.c	…
tvbuff_zlib.c	Update URLs pointing to the bug database.	2020-10-03 07:54:12 -07:00
uat-int.h	…
uat.c	…
uat.h	…
uat_load.l	…
unit_strings.c	Document unit string and true false string helper functions	2020-04-29 10:07:51 +00:00
unit_strings.h	Document unit string and true false string helper functions	2020-04-29 10:07:51 +00:00
value_string.c	…
value_string.h	value_string: Change the bytes_string struct to avoid Wpointer-sign	2020-07-08 06:43:55 +00:00
x264_prt_id.h	…
xdlc.c	…
xdlc.h	…