forked from osmocom/wireshark
![Michael Mann](/assets/img/avatar_default.png)
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
180 lines
4.8 KiB
C
180 lines
4.8 KiB
C
/* packet-git.c
|
|
* Routines for git packet dissection
|
|
* Copyright 2010, Jelmer Vernooij <jelmer@samba.org>
|
|
*
|
|
* Wireshark - Network traffic analyzer
|
|
* By Gerald Combs <gerald@wireshark.org>
|
|
* Copyright 1998 Gerald Combs
|
|
*
|
|
* Copied from packet-pop.c
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <epan/packet.h>
|
|
#include <epan/prefs.h>
|
|
#include "packet-tcp.h"
|
|
|
|
void proto_register_git(void);
|
|
void proto_reg_handoff_git(void);
|
|
|
|
static dissector_handle_t git_handle;
|
|
|
|
static int proto_git = -1;
|
|
|
|
static gint ett_git = -1;
|
|
|
|
static gint hf_git_packet_len = -1;
|
|
static gint hf_git_packet_data = -1;
|
|
static gint hf_git_packet_terminator = -1;
|
|
|
|
#define PNAME "Git Smart Protocol"
|
|
#define PSNAME "Git"
|
|
#define PFNAME "git"
|
|
|
|
#define TCP_PORT_GIT 9418
|
|
|
|
/* desegmentation of Git over TCP */
|
|
static gboolean git_desegment = TRUE;
|
|
|
|
static gboolean get_packet_length(tvbuff_t *tvb, int offset,
|
|
guint16 *length)
|
|
{
|
|
guint8 *lenstr;
|
|
|
|
lenstr = tvb_get_string_enc(wmem_packet_scope(), tvb, offset, 4, ENC_ASCII);
|
|
|
|
return (sscanf(lenstr, "%hx", length) == 1);
|
|
}
|
|
|
|
static guint
|
|
get_git_pdu_len(packet_info *pinfo _U_, tvbuff_t *tvb, int offset, void *data _U_)
|
|
{
|
|
guint16 plen;
|
|
|
|
if (!get_packet_length(tvb, offset, &plen))
|
|
return 0; /* No idea what this is */
|
|
|
|
if (plen == 0) {
|
|
/* Terminator packet */
|
|
return 4;
|
|
}
|
|
|
|
return plen;
|
|
}
|
|
|
|
static int
|
|
dissect_git_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_)
|
|
{
|
|
proto_tree *git_tree;
|
|
proto_item *ti;
|
|
int offset = 0;
|
|
guint16 plen;
|
|
|
|
col_set_str(pinfo->cinfo, COL_PROTOCOL, PSNAME);
|
|
|
|
col_set_str(pinfo->cinfo, COL_INFO, PNAME);
|
|
|
|
ti = proto_tree_add_item(tree, proto_git, tvb, offset, -1, ENC_NA);
|
|
git_tree = proto_item_add_subtree(ti, ett_git);
|
|
|
|
if (!get_packet_length(tvb, 0, &plen))
|
|
return 0;
|
|
|
|
if (plen == 0) {
|
|
proto_tree_add_uint(git_tree, hf_git_packet_terminator, tvb, offset,
|
|
4, plen);
|
|
return 4;
|
|
}
|
|
|
|
if (git_tree)
|
|
{
|
|
proto_tree_add_uint(git_tree, hf_git_packet_len, tvb, offset,
|
|
4, plen);
|
|
|
|
proto_tree_add_item(git_tree, hf_git_packet_data, tvb, offset+4,
|
|
plen-4, ENC_NA);
|
|
}
|
|
|
|
return tvb_captured_length(tvb);
|
|
}
|
|
|
|
static int
|
|
dissect_git(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data)
|
|
{
|
|
tcp_dissect_pdus(tvb, pinfo, tree, git_desegment, 4, get_git_pdu_len,
|
|
dissect_git_pdu, data);
|
|
return tvb_captured_length(tvb);
|
|
}
|
|
|
|
void
|
|
proto_register_git(void)
|
|
{
|
|
static hf_register_info hf[] = {
|
|
{ &hf_git_packet_len,
|
|
{ "Packet length", "git.length", FT_UINT16, BASE_HEX, NULL, 0x0, NULL, HFILL },
|
|
},
|
|
{ &hf_git_packet_data,
|
|
{ "Packet data", "git.data", FT_BYTES, BASE_NONE, NULL, 0x0, NULL, HFILL },
|
|
},
|
|
{ &hf_git_packet_terminator,
|
|
{ "Terminator packet", "git.terminator", FT_UINT16, BASE_HEX, NULL, 0x0, NULL, HFILL },
|
|
},
|
|
};
|
|
|
|
static gint *ett[] = {
|
|
&ett_git,
|
|
};
|
|
|
|
module_t *git_module;
|
|
|
|
proto_git = proto_register_protocol(PNAME, PSNAME, PFNAME);
|
|
proto_register_field_array(proto_git, hf, array_length(hf));
|
|
proto_register_subtree_array(ett, array_length(ett));
|
|
|
|
git_handle = register_dissector(PFNAME, dissect_git, proto_git);
|
|
|
|
git_module = prefs_register_protocol(proto_git, NULL);
|
|
|
|
prefs_register_bool_preference(git_module, "desegment",
|
|
"Reassemble GIT messages spanning multiple TCP segments",
|
|
"Whether the GIT dissector should reassemble messages spanning multiple TCP segments."
|
|
" To use this option, you must also enable \"Allow subdissectors to reassemble TCP streams\" in the TCP protocol settings.",
|
|
&git_desegment);
|
|
}
|
|
|
|
void
|
|
proto_reg_handoff_git(void)
|
|
{
|
|
dissector_add_uint_with_preference("tcp.port", TCP_PORT_GIT, git_handle);
|
|
}
|
|
|
|
/*
|
|
* Editor modelines - http://www.wireshark.org/tools/modelines.html
|
|
*
|
|
* Local Variables:
|
|
* c-basic-offset: 2
|
|
* tab-width: 8
|
|
* indent-tabs-mode: nil
|
|
* End:
|
|
*
|
|
* ex: set shiftwidth=2 tabstop=8 expandtab:
|
|
* :indentSize=2:tabSize=8:noTabs=true:
|
|
*/
|