osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/ui
History
Tomasz Moń 1d0b233f12 Qt: Stretch last packet list header section 
Programatically show the master split widget before elements are added
to prevent pending resize events from resizing packet columns to insane
widths (in my case orders of magnitude higher than display resolution)

Such resize was occuring when loading capture file if configuration file
included hidden columns (e.g. 55 defined columns, 8 visible). The resize
was not directly visible to user. Resize event call chain included calls
to recent_set_column_width() that changed width stored in configuration.
Modified configuration column width value would become effective after
user added or removed columns.

Hide PacketList when freezing and show it when thawing. Do not call
setUpdatesEnabled(false) as it leads to widget/preferences columns
missynchronization.

Clear packet list before freeing frame data. This prevents accessing
freed memory in ProtoTree on file close if packet list was in focus and
the next widget to get focus is packet details.

Ping-Bug: 16063
Bug: 16491
Change-Id: I2c21d928348681af1793b3263815c81ee73d41b0
Reviewed-on: https://code.wireshark.org/review/37029
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2020-05-06 03:50:18 +00:00
..
cli HTTP: share dissector status value_string array with tshark HTTP stats 2020-01-24 22:38:17 +00:00
macosx macOS: Expand a comment. 2020-02-28 16:40:02 +00:00
qt Qt: Stretch last packet list header section 2020-05-06 03:50:18 +00:00
win32 Qt: Fix export of dissection 2020-04-27 16:00:03 +00:00
CMakeLists.txt HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
alert_box.c ui: add missing break. 2018-11-14 09:30:55 +00:00
alert_box.h
…
all_files_wildcard.h
…
capture.c Have callback function pointers in a capture_session structure. 2020-03-25 23:16:06 +00:00
capture.h ui/capture.h: add missing include to fix build with GCC 9.3 2020-05-04 11:22:22 +00:00
capture_globals.h
…
capture_info.h Move the last of the routines from capture_info.c into ui/capture.c. 2019-09-15 14:09:41 +00:00
capture_ui_utils.c Generate a dummy description if we don't have an interface name. 2020-05-03 21:22:17 +00:00
capture_ui_utils.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
clopts_common.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
clopts_common.h Reorganize long option values 2019-12-15 20:02:09 +00:00
cmdarg_err.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
cmdarg_err.h Move some command-line-oriented routines from wsutil to ui. 2019-01-01 02:07:06 +00:00
commandline.c Docs+help: Remove "-m". 2020-04-25 13:57:11 +00:00
commandline.h Move more version-info-related stuff to version_info.c. 2018-12-13 03:16:13 +00:00
console.c Windows: Console log handler fixups. 2019-03-14 21:15:08 +00:00
console.h
…
decode_as_utils.c Accept protocol aliases in Decode As (-d tcp.port==4433,ssl) 2019-02-05 22:40:01 +00:00
decode_as_utils.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
dissect_opts.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
dissect_opts.h Reorganize long option values 2019-12-15 20:02:09 +00:00
export_object_ui.c Don't fall out of the loop on a write error. 2019-01-02 23:56:33 +00:00
export_object_ui.h No need to report "some files could not be saved". 2019-01-01 23:12:17 +00:00
export_pdu_ui_utils.c Use g_file_open_tmp within create_tempfile 2019-12-20 19:26:38 +00:00
export_pdu_ui_utils.h
…
failure_message.c Move some command-line-oriented routines from wsutil to ui. 2019-01-01 02:07:06 +00:00
failure_message.h
…
file_dialog.c 1514 is a better initial Buffer size than 1500. 2019-04-06 21:04:02 +00:00
file_dialog.h
…
filter_files.c FilterFiles: Remove GTK+-only filter lists 2019-10-25 13:46:44 +00:00
filter_files.h FilterFiles: Remove GTK+-only filter lists 2019-10-25 13:46:44 +00:00
firewall_rules.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
firewall_rules.h
…
help_url.c Qt: Rename the Capture Interfaces dialog to Capture Options. 2019-12-03 03:16:16 +00:00
help_url.h Qt: Rename the Capture Interfaces dialog to Capture Options. 2019-12-03 03:16:16 +00:00
iface_lists.c Write the if_hardware option, if available, to pcapng files when capturing. 2020-03-28 03:34:18 +00:00
iface_lists.h Get rid of unused routine. 2018-08-11 07:52:06 +00:00
iface_toolbar.c
…
iface_toolbar.h
…
io_graph_item.c IO Graph shows unsigned values correctly 2020-01-18 12:17:24 +00:00
io_graph_item.h IO Graph shows unsigned values correctly 2020-01-18 12:17:24 +00:00
language.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
language.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
last_open_dir.h
…
main_statusbar.h
…
mcast_stream.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
mcast_stream.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
packet_list_utils.c Qt: Enable "Resolve Names" for boolean without TFS 2018-08-22 03:58:16 +00:00
packet_list_utils.h
…
packet_range.c Qt: Multiselection in PacketList 2019-11-17 12:20:29 +00:00
packet_range.h Qt: Multiselection in PacketList 2019-11-17 12:20:29 +00:00
persfilepath_opt.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
persfilepath_opt.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
preference_utils.c profiles: Try to better sync on disk config state 2019-12-16 05:34:28 +00:00
preference_utils.h ui: Refactoring column_prefs_add_custom 2019-06-30 13:08:40 +00:00
profile.c Qt: Prevent loop in renames of profiles 2019-08-13 08:16:12 +00:00
profile.h Qt: Prevent loop in renames of profiles 2019-08-13 08:16:12 +00:00
progress_dlg.h file: remove use of g_get_current_time 2019-07-17 06:25:28 +00:00
proto_hier_stats.c file: remove use of g_get_current_time 2019-07-17 06:25:28 +00:00
proto_hier_stats.h
…
recent.c Qt: Make it possible to hide welcome screen warnings. 2020-02-07 07:36:03 +00:00
recent.h Qt: Make it possible to hide welcome screen warnings. 2020-02-07 07:36:03 +00:00
recent_utils.h
…
rtp_media.c codecs API: Added description of API usage 2019-12-30 15:41:00 +00:00
rtp_media.h rtp_analysis_dialog.cpp: save any supported codec as .au 2019-11-21 16:06:49 +00:00
rtp_stream.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
rtp_stream.h rtp_player: Player is able to set start of audio play by double click 2020-01-07 09:38:14 +00:00
rtp_stream_id.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
rtp_stream_id.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
service_response_time.c
…
service_response_time.h
…
simple_dialog.h Qt: Add asynchronous simple dialog 2019-05-20 12:53:38 +00:00
software_update.c macOS: Software update fixes. 2020-02-28 04:50:38 +00:00
software_update.h Test+Qt: Add an automatic update check. 2020-02-15 11:13:25 +00:00
ssl_key_export.c Rename packet-ssl* to packet-tls* 2018-09-25 13:24:17 +00:00
ssl_key_export.h
…
summary.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
summary.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-credentials.h credentials: don't use wmem file scope but a local copy. 2019-07-05 12:26:44 +00:00
tap-iax2-analysis.c HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-iax2-analysis.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-rlc-graph.c Some more issues spotted by PVS-Studio in bug 16335. 2020-02-23 21:43:51 +00:00
tap-rlc-graph.h
…
tap-rtp-analysis.c RTP Stream Analysis: fix wrong values for clock drift and freq drift. 2020-01-24 13:36:13 +00:00
tap-rtp-analysis.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
tap-rtp-common.c rtp_player: Player is able to set start of audio play by double click 2020-01-07 09:38:14 +00:00
tap-rtp-common.h rtp_analysis_dialog: save as au: fix for streams with multiple codecs 2019-11-03 11:12:30 +00:00
tap-sctp-analysis.c [SCTP] ui: fix Analyse Association with correct number of endpoint streams 2019-06-13 18:01:43 +00:00
tap-sctp-analysis.h Qt: fix several crashes in the SCTP Dialogs 2018-08-20 05:01:11 +00:00
tap-tcp-stream.c Qt: Fix memory leak in TCP Stream Dialog 2020-04-14 15:35:55 +00:00
tap-tcp-stream.h Qt: Fix memory leak in TCP Stream Dialog 2020-04-14 15:35:55 +00:00
tap_export_pdu.c wiretap: fix memleaks with wtap_rec::opt_comment 2019-01-25 04:53:10 +00:00
tap_export_pdu.h Clean up exp_pdu_open() API. 2018-12-19 06:59:09 +00:00
taps.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
text_import.c text import: make TCP dest port truly direction dependant 2019-04-20 06:59:27 +00:00
text_import.h Text Import: update code comments and help texts 2019-01-21 21:03:49 +00:00
text_import_scanner.h Put back EOF rule, but without exporting write_current_packet(). 2019-03-20 16:06:57 +00:00
text_import_scanner.l Put back EOF rule, but without exporting write_current_packet(). 2019-03-20 16:06:57 +00:00
time_shift.c TimeShiftDialog should be considered an "edit" operation 2018-12-21 13:59:32 +00:00
time_shift.h HTTPS (almost) everywhere. 2019-07-26 18:44:40 +00:00
traffic_table_ui.c Don't cast away constness if you don't have to. 2019-03-17 22:10:10 +00:00
traffic_table_ui.h Re-implement "Map" feature for Endpoints 2019-02-16 21:11:12 +00:00
util.c HTTPS In More Places, update some URLs. 2019-07-27 07:55:36 +00:00
util.h
…
voip_calls.c voip_calls: Fix leak of GString from unistim handling. 2020-05-03 19:07:53 +00:00
voip_calls.h RTP: code cleanup 3 2018-06-23 10:03:54 +00:00
ws_ui_util.h Allow Multiselection of packets to work during live captures 2020-01-12 22:33:42 +00:00