osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
wireshark/ui
History
Peter Wu 4c1690ac47 CMake: require at least CMake 3.5 
CMake 3.11 with the Ninja generator started complaining about CMP0058
related to ui/qt/CMakeFiles/qtui_autogen.dir/RCCstock_iconsInfo.cmake
amd other files (AUTORCC). While the policy could be set explicitly,
let's try to modernize the CMake configuration:

- Drop CMP0042, if this gives issues with macOS, then it must be solved
  in a different way using non-deprecated methods.
- Drop CMP0054 and ensure that all if("${foo}") and if(${foo}) are
  converted to if(foo).
- Remove string comparison against "-NOTFOUND", it already evaluates to
  false in an if condition.
- Use CXX_STANDARD/CXX_STANDARD_REQUIRED for Qt 5.7 and newer.
- Assume that copy_if_different can accept multiple sources (CMake 3.5).
- Consistency: Out of the 60 CMake 3.11 FindXxx.cmake files that use
  find_library, 34 contain "XXX_LIBRAR" while 16 contain "Xxx_LIBRAR".
  Let's assume uppercase variables (now custom MaxMindDB include dirs
  are correctly used).

CMake 3.5 was chosen as the next version because of its wide support.
Ubuntu 14.04 ships with cmake3 3.5.1, Debian jessie-backports has 3.6.2,
EPEL for CentOS/RHEL6 includes cmake3 3.6.1 and SLES12 SP2 has 3.5.

Change-Id: I2fa7b94bf8cc78411f414987d17bab3a33dfb360
Reviewed-on: https://code.wireshark.org/review/27444
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2018-05-15 10:28:09 +00:00
..
cli Get rid of some GTK+-only stuff. 2018-05-13 20:21:14 +00:00
gtk Don't use dladdr() to get a pathname for the current executable(). 2018-05-05 08:06:35 +00:00
macosx Qt: Enable Emoji & Symbols selector again 2018-04-10 07:37:08 +00:00
qt CMake: require at least CMake 3.5 2018-05-15 10:28:09 +00:00
win32 Windows: Make sure native dialogs handle HiDPI. 2018-05-09 20:02:34 +00:00
CMakeLists.txt CMake: fix build by not unnecessarily linking with wsutil 2018-05-04 10:16:39 +00:00
alert_box.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
alert_box.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
all_files_wildcard.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
capture.c Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
capture.h Remove declaration of routine that no longer exists. 2018-03-03 06:31:42 +00:00
capture_globals.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
capture_ui_utils.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
capture_ui_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
commandline.c Remove a question from a comment. 2018-05-13 20:24:59 +00:00
commandline.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
console.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
console.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
decode_as_utils.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
decode_as_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
dissect_opts.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
dissect_opts.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
export_object_ui.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
export_object_ui.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
export_pdu_ui_utils.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
export_pdu_ui_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
failure_message.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
failure_message.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
file_dialog.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
file_dialog.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
filter_files.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
filter_files.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
firewall_rules.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
firewall_rules.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
help_url.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
help_url.h Qt: TCP Stream Graphs dialog updates. 2018-03-26 04:25:23 +00:00
iface_lists.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
iface_lists.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
iface_toolbar.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
iface_toolbar.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
io_graph_item.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
io_graph_item.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
language.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
language.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
last_open_dir.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
main_statusbar.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
make-taps.c glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0 2018-04-16 16:07:46 +00:00
mcast_stream.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
mcast_stream.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_list_utils.c Qt: Right justify custom columns with multiple fields 2018-02-20 11:48:20 +00:00
packet_list_utils.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_range.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
packet_range.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
persfilepath_opt.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
persfilepath_opt.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
preference_utils.c Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
preference_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
profile.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
profile.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
progress_dlg.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
proto_hier_stats.c Generalize wtap_pkthdr into a structure for packet and non-packet records. 2018-02-09 00:29:51 +00:00
proto_hier_stats.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
recent.c Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
recent.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
recent_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
rtp_media.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
rtp_media.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
rtp_stream.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
rtp_stream.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
service_response_time.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
service_response_time.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
simple_dialog.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
software_update.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
software_update.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
ssl_key_export.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
ssl_key_export.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
summary.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
summary.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-iax2-analysis.c tap-iax2-analysis: fix minor indentation issues. 2018-03-17 21:24:13 +00:00
tap-iax2-analysis.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
tap-rlc-graph.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap-rlc-graph.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap-rtp-analysis.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
tap-rtp-common.c ui/tap-rtp-common: fix some memleaks 2018-05-09 18:42:27 +00:00
tap-rtp-common.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-sctp-analysis.c SCTP: INIT collision 2018-04-20 08:23:05 +00:00
tap-sctp-analysis.h SCTP: INIT collision 2018-04-20 08:23:05 +00:00
tap-tcp-stream.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap-tcp-stream.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap_export_pdu.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tap_export_pdu.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
taps.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
text_import.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
text_import.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
text_import_scanner.h Squelch redundant declaration warnings. 2018-02-16 22:40:26 +00:00
text_import_scanner.l spdx: more licenses converted. 2018-03-07 15:56:44 +00:00
time_shift.c Always explicitly set tm_isdst before calling mktime(). 2018-05-09 16:33:21 +00:00
time_shift.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
traffic_table_ui.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
traffic_table_ui.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
util.c Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
util.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
voip_calls.c ui/voip_calls: fix memleak in is_mgcp_signal 2018-05-09 18:41:46 +00:00
voip_calls.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
ws_ui_util.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00