Commit graph

144 commits

Author SHA1 Message Date
Tomas Kukosa
62ece3e529 SIP headers are case-insensitive, fix case sensitivity introduced probably by mistake
svn path=/trunk/; revision=32463
2010-04-14 12:07:29 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Anders Broman
081aa44683 - Make dfilter_sip_request_line() take offset as an argument to get the right offset in case there is more than one SIP message in an tvb.
- Use correct line end offset to dissect_sip_uri().
Fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4570

svn path=/trunk/; revision=32309
2010-03-27 18:09:37 +00:00
Anders Broman
b362b47f71 My previous checkin reverted some changes, try to fix that.
svn path=/trunk/; revision=32197
2010-03-15 18:51:37 +00:00
Jeff Morriss
a6ca78fc2b Initialize a variable that otherwise might not be
svn path=/trunk/; revision=32196
2010-03-15 18:31:10 +00:00
Jeff Morriss
3ffbfe347e Declare sip_uri_offset_init() as returning void and remove a couple unused variables
svn path=/trunk/; revision=32195
2010-03-15 17:51:19 +00:00
Anders Broman
e2f2c4c2cf To fill stat_info->tap_to_addr it needs to be outside of if(tree).
svn path=/trunk/; revision=32194
2010-03-15 15:23:37 +00:00
Anders Broman
518ca45156 Use dissect_sip_uri() in dfilter_sip_request_line().
svn path=/trunk/; revision=32191
2010-03-14 19:54:09 +00:00
Anders Broman
d26a6348e7 Use dissect_sip_name_addr_or_addr_spec() or dissect_sip_uri() as needed.
svn path=/trunk/; revision=32178
2010-03-13 08:38:11 +00:00
Gerald Combs
dfff249e12 Initialize a variable.
svn path=/trunk/; revision=32172
2010-03-11 20:21:06 +00:00
Anders Broman
bd77bea4f2 Remove unused variables etc
svn path=/trunk/; revision=32171
2010-03-11 20:14:59 +00:00
Anders Broman
25e7ead105 Start to clean up parsing of SIP URI.
svn path=/trunk/; revision=32170
2010-03-11 17:45:16 +00:00
Anders Broman
25af78517e Make tvb_pbrk_guint8() return the found needle.
svn path=/trunk/; revision=32144
2010-03-08 20:45:13 +00:00
Anders Broman
3e1b6fd0a4 Check if URI is SIP.
svn path=/trunk/; revision=32122
2010-03-05 15:16:30 +00:00
Anders Broman
5d0629d36c Add comments and move some things inside if(tree).
svn path=/trunk/; revision=32121
2010-03-05 09:33:37 +00:00
Gerald Combs
2b619452ae Try to fix build errors.
svn path=/trunk/; revision=32118
2010-03-04 21:48:44 +00:00
Anders Broman
b2c9e92823 Use a hash table to lookup the SIP header.
It reduces the loading time of a file with 220 000 packets by 3s.
(SIP parsing should be optimized, if SIP is dissabled loading time is ~15s with SIP ~30s ).

svn path=/trunk/; revision=32116
2010-03-04 20:35:45 +00:00
Anders Broman
87576533f7 Changed to use g_str_hash ()
sip_hash_func() function seem to not generate unique enough keys
if load generation tools are used with many thousands users.
Loading time ~5 min -> 30s

There is a memory leak in the sip_is_packet_resend area as well.

svn path=/trunk/; revision=32090
2010-03-03 15:29:38 +00:00
Stig Bjørlykke
c198fc6546 From Didier Gautheron via bug 4419:
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized
data with 0.

svn path=/trunk/; revision=31654
2010-01-25 11:47:39 +00:00
Bill Meier
1a4283ccf8 Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Guy Harris
90765a3c3e To check which SIP method we saw, just #define values for the index in
the sip_methods[] table and check the index's value, don't do a string
comparison.

svn path=/trunk/; revision=31595
2010-01-20 21:05:24 +00:00
Anders Broman
46ba2a93c8 From Karl Heinz Wolf:
Marking in dialog SIP requests.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3588

svn path=/trunk/; revision=31594
2010-01-20 20:34:45 +00:00
Jaap Keuter
b8ef5efede From Benoit Sibaud:
New option to allow retransmission detection with different source ports.

svn path=/trunk/; revision=31496
2010-01-11 14:28:51 +00:00
Anders Broman
8e07cb1a33 Update SIP headers.
svn path=/trunk/; revision=30969
2009-11-16 06:48:17 +00:00
Jeff Morriss
1daf990897 From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2815
but (since the patch no longer applied cleanly) essentially manually
re-implemented by me:

Rename "stun" to "classic stun" and "stun2" to "stun", to follow the usage
defined in draft-ietf-behave-rfc3489bis-18 section 2.

svn path=/trunk/; revision=29884
2009-09-13 23:03:38 +00:00
Kovarththanan Rajaratnam
4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Tomas Kukosa
f56e93d1a5 Support for IPv6 addresses in URI
svn path=/trunk/; revision=29227
2009-07-29 09:13:03 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jaap Keuter
b429593171 Remove C++ style comments.
Cleanup indentation a bit.

svn path=/trunk/; revision=28380
2009-05-17 06:02:48 +00:00
Anders Broman
0f9c96f8fd From Chidambaram Arunachalam:
SIP Patch to include support for Max-Breadth, Answer-Mode, Priv-Answer-Mode, Trigger-Consent and Permission Missing headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3463

svn path=/trunk/; revision=28375
2009-05-16 09:16:11 +00:00
Martin Mathieson
efbf22009e Dissect more than one Via entry if found in a single line.
Fixes bug 3406.

svn path=/trunk/; revision=28054
2009-04-15 13:10:55 +00:00
Anders Broman
d457cf380f Try to please the build bot, fix indentation.
svn path=/trunk/; revision=28038
2009-04-13 18:09:20 +00:00
Anders Broman
662bf774f9 From Andreas Heise:
add SIP URI PARTS dissection to packet-sip.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3399

svn path=/trunk/; revision=28037
2009-04-13 14:31:13 +00:00
Gerald Combs
dde9618170 More size_t fixes.
svn path=/trunk/; revision=27977
2009-04-06 20:28:47 +00:00
Anders Broman
bd49b6e54b More size_t casts(Unfinished)
svn path=/trunk/; revision=27898
2009-03-30 19:00:00 +00:00
Anders Broman
4e5748c125 From Andreas Heise:
SIP dissector fix: mismatch of P-Asserted-Identity and P-Answer-State headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3356

svn path=/trunk/; revision=27859
2009-03-27 07:08:07 +00:00
Anders Broman
c5f1300045 Init. data to zero.
svn path=/trunk/; revision=27378
2009-02-05 18:08:03 +00:00
Guy Harris
3ad5b02052 Use #if 0, not C99-style comments, to get rid of unused code.
svn path=/trunk/; revision=27344
2009-02-01 21:19:38 +00:00
Guy Harris
07d572cc2a Squelch warnings, for now.
svn path=/trunk/; revision=27343
2009-02-01 21:17:46 +00:00
Anders Broman
f9bb905d13 Calculate the avrage setuptime.
svn path=/trunk/; revision=27342
2009-02-01 20:52:38 +00:00
Bill Meier
c53d96ac3b Use ascii_strdown_inplace instead of g_ascii_strdown in a few places.
This also fixes a few cases where memory was not freed after
 g_ascii_strdown.

svn path=/trunk/; revision=27254
2009-01-17 17:33:50 +00:00
Tomas Kukosa
35ae656ccc new "sip.hdr" subdissector table for SIP Extension headers
svn path=/trunk/; revision=26677
2008-11-03 13:53:42 +00:00
Bill Meier
1a7111b603 Minor revision related to proto_reg_handoff ...
svn path=/trunk/; revision=26252
2008-09-23 00:55:28 +00:00
Bill Meier
419e3a47f6 Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26128
2008-09-03 16:42:35 +00:00
Anders Broman
47aca4c30f From stéphane bryant:
STUN, STUN2 and TURN dissection enhancements.

svn path=/trunk/; revision=25895
2008-08-01 15:11:06 +00:00
Anders Broman
91cd5cce23 Handle malformed SIP headers (empty header line missing) and add an expert
item explaining the fault.
Fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2729

svn path=/trunk/; revision=25862
2008-07-29 18:02:09 +00:00
Martin Mathieson
6f286b94fb Register raw_sip.line with correct protocol, as noticed while testing
patch for 2581.
















svn path=/trunk/; revision=25676
2008-07-08 16:32:56 +00:00
Jaap Keuter
98899e9996 Fix for bug 2659:
Account for IPv6 addresses representation in Via header.

svn path=/trunk/; revision=25635
2008-06-30 06:35:22 +00:00
Martin Mathieson
dbfbb872ee Make sip.msg_hdr a string field instead of FT_NONE.
svn path=/trunk/; revision=25602
2008-06-25 12:40:15 +00:00