Bill Meier
055dd62063
#include <string.h> not needed.
...
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Stig Bjørlykke
86a6a0c2a4
Use a more correct length for hf_bssgp_ie_type and hf_bssgp_bvci,
...
to try fixing a buildbot run-randpkt failure.
svn path=/trunk/; revision=31509
2010-01-12 21:25:35 +00:00
Gerasimos Dimitriadis
18d299b758
- Replaced get_start_octet() with a right shift
...
- Deleted function bssgp_tvb_get_bits8(), uses tvbuff counterpart now
- guint32 vars should be enough for bit offsets
svn path=/trunk/; revision=30963
2009-11-14 21:15:38 +00:00
Anders Broman
f8a37ac1d6
Make it possible to use bssgp.tlli as custom column.
...
Remove COL_BSSGP_TLLI and CHECK_COL.
svn path=/trunk/; revision=29543
2009-08-24 20:54:25 +00:00
Kovarththanan Rajaratnam
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
0a5b014cec
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jaap Keuter
88d9e0f55f
From Reinhard Speyerer:
...
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.
svn path=/trunk/; revision=28209
2009-05-01 07:06:17 +00:00
Bill Meier
f68d3d46fe
Fix some indentation ....
...
svn path=/trunk/; revision=27310
2009-01-27 18:09:50 +00:00
Bill Meier
c544c20956
Fix various typos and spelling errors (mostly in text strings)
...
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier
a8f30cbca1
Fix some typos and spelling (mostly in text strings)
...
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Bill Meier
33c99f44fd
Fix typos and spelling (mostly in text strings)
...
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Jaap Keuter
e7ca77a5cc
Fix for bug 3085:
...
Correct interpretation of QoS T-bit.
svn path=/trunk/; revision=26908
2008-12-03 07:08:33 +00:00
Stig Bjørlykke
d0e33bc3c5
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26646
2008-10-31 14:07:23 +00:00
Anders Broman
d1ea868c27
Bucket Leak Rate decoded incorrectly as bytes instead of bits
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2849
svn path=/trunk/; revision=26147
2008-09-06 11:45:08 +00:00
Bill Meier
b52d95d591
#include <emem.h> not req'd
...
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Bill Meier
acbbc43f2e
Remove unnecessary registration of a prefs callback & do minor cleanup
...
svn path=/trunk/; revision=26078
2008-08-25 18:37:18 +00:00
Anders Broman
96aa45646d
First step to split the gsm_a dissector into several smaller ones ( done by Neil Piercy)
...
rename the "old" one to gsm_a_common.
svn path=/trunk/; revision=25915
2008-08-04 16:11:17 +00:00
Stig Bjørlykke
cb43c90778
Renamed a local variable to avoid name collisions.
...
svn path=/trunk/; revision=25561
2008-06-23 21:34:40 +00:00
Anders Broman
2e0c1810e7
Fix some of the Errors/warnings detected by checkapi.
...
svn path=/trunk/; revision=25294
2008-05-14 07:35:52 +00:00
Anders Broman
1950ffc214
Apply the small performance enhancment patches for:
...
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace
- col_append_fstr() with faster col_append_str()
- col_add_str() with col_set_str()
when it's safe
svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Anders Broman
8f3a0cb862
BSSGP.TLLI is not recognized properly in filter
...
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384
svn path=/trunk/; revision=22777
2007-09-03 16:39:07 +00:00
Jeff Morriss
794a933a2c
Change "lenght" to "length" and "decypt" to "decrypt"
...
svn path=/trunk/; revision=22356
2007-07-19 13:05:39 +00:00
Guy Harris
e62e5e3b25
There's more than one IE table; instead of fixing up all the IE tables
...
with default IE names, have bssgp_proto_tree_add_ie() use val_to_str()
if the IE table doesn't have an IE name.
Don't use the IE name as a format; use "%s" as the format, and the IE
name as the argument. (That more clearly states what's being done.)
svn path=/trunk/; revision=21837
2007-05-19 21:22:05 +00:00
Anders Broman
b688f9154a
Split tvb_get_bits64 into tvb_get_bits8 tvb_get_bits16 tvb_get_bits32 and tvb_get_bits64
...
and use them in proto_tree_add_bits_ret_val().
svn path=/trunk/; revision=21828
2007-05-18 16:46:35 +00:00
Guy Harris
1bc049906a
Add some GCC warnings to the standard set, and add some others to the
...
--enable-extra-gcc-checks set.
If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.
Constify a bunch of stuff, and make some other changes, to get rid of
warnings.
Clean up some indentation.
svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Ronnie Sahlberg
0294198960
Remove a compiler warning by #if 0 out a function that is not called.
...
The function is referenced from a comment which is why it was #ifed out instead of just deleted.
svn path=/trunk/; revision=21108
2007-03-22 08:03:44 +00:00
Anders Broman
33c97b6a1f
Get rid of yet another printout that does not go well with optional IE:s
...
svn path=/trunk/; revision=20884
2007-02-20 22:12:54 +00:00
Anders Broman
fd3aa71e67
Test before comitting...
...
svn path=/trunk/; revision=20883
2007-02-20 21:58:30 +00:00
Anders Broman
0c0367bfa1
Fix a typo and some reported compiler warnings(hopefully).
...
svn path=/trunk/; revision=20879
2007-02-20 19:40:14 +00:00
Bill Meier
103bf29730
Continuing the tradition: squelch some compiler warnings ....
...
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Anders Broman
f30812691b
Fix the bugs part of http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1371 .
...
- a typor in in hf_bssgp_ie_type
- id def out debug code.
svn path=/trunk/; revision=20821
2007-02-16 06:54:32 +00:00
Anders Broman
6c9ce8acf8
Froim Rene Pilz:
...
This patch consists also the last issues. Additionally it solves:
- For the SSCOP frames the AAL5 decoding was not performed due to an earlier patch. This caused that no SSCOP message was properly decoded.
- As the detection between a LANE frame and a SSCOP frame is rather hard a switch within the atm dissector is included which enforce SSCOP dissecting over a LANE frame. At the moment I do not see a better solution for that.
svn path=/trunk/; revision=20013
2006-11-29 06:44:07 +00:00
Anders Broman
65267d932f
Do some more of the relase 6 stuff.
...
svn path=/trunk/; revision=19056
2006-08-27 20:30:01 +00:00
Anders Broman
0bcced5d2e
BSSGP: Wrong length on IE and preparation to export IE dissection.
...
GSM_a: Add an if_def
GTP: Update comments
svn path=/trunk/; revision=19019
2006-08-24 21:19:49 +00:00
Anders Broman
e9a4ce8196
Decode PDU Type Extension.
...
svn path=/trunk/; revision=18731
2006-07-13 20:13:35 +00:00
Anders Broman
7eb7109842
From Nils Ljungberg:
...
TLLI shown twice (create-bss-pfc) PFI not fully decoded (dynamically assigned
Fixed decoding of RAN-INFORMATION and RAN-INFORMATION-REQUESTadded dekoding of RAN_INFORMATION_ACC, RAN_INFORMATION_ERROR, RAN_APPLICATION_ERROR
svn path=/trunk/; revision=18708
2006-07-10 21:39:07 +00:00
Ronnie Sahlberg
feab79e328
change a whole bunch of ethereal into wireshark
...
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman
1d1cf3790a
bssgp - handle LLC PDU of 0 length.
...
Gsm_a - radio pri included in Modify PDP context request.
svn path=/trunk/; revision=17875
2006-04-16 19:14:21 +00:00
Anders Broman
3c2c4a390a
Fix dissection of QoS.
...
svn path=/trunk/; revision=17650
2006-03-16 21:16:30 +00:00
Anders Broman
def11f9418
CID4 and CID3 Change
...
if ((value >= 1) || (value <= 0x4a)) {
to if ((value >= 1) && (value <= 0x4a)) {
svn path=/trunk/; revision=17533
2006-03-08 18:58:08 +00:00
Guy Harris
b13f6dcbd3
Use the new "proto_tree_add_*_format_value" routines.
...
svn path=/trunk/; revision=17316
2006-02-16 11:43:38 +00:00
Anders Broman
25a7d62b92
BSSGP - Translate MCC and make MCC MNC etc vissible filters
...
GSMMAP - Small bugfix
svn path=/trunk/; revision=17132
2006-01-31 05:46:36 +00:00
Jörg Mayer
f9a57f08d1
Bill Meier:
...
Spelling fixes.
svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman
2145d15234
From Rene Pilz:
...
- LLC XID patch (reaability patch).
- Dissection of the MS Radio Capabilities.
svn path=/trunk/; revision=16199
2005-10-12 05:34:36 +00:00
Anders Broman
5ddbeb2cb8
From Rene Pilz,
...
In the bssgp an IE was decoded as mobile identity and should be decoded as (p)tmsi only.
The patch is attached to this email. It also consists the new atm patch which was send yesterday.
svn path=/trunk/; revision=16146
2005-10-06 20:01:25 +00:00
Guy Harris
f6ef22c553
Have show_exception() take a "const char *" as its exception message,
...
and not free the string to which it points. Pass to
REPORT_DISSECTOR_BUG() strings allocated with ep_strdup_printf(), so
that they're freed automatically.
svn path=/trunk/; revision=16039
2005-09-28 16:16:37 +00:00
Ulf Lamping
0dc9fb3d4a
various code cleanup:
...
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants
svn path=/trunk/; revision=15264
2005-08-08 18:50:39 +00:00