Commit Graph

41156 Commits

Author SHA1 Message Date
Guy Harris 5c423a4c51 The toolkit-dependent UI library, well, depends on the toolkit. Make it
so.

svn path=/trunk/; revision=43329
2012-06-18 06:38:44 +00:00
Guy Harris c92fced5b8 Add initialization to squelch compiler warnings.
svn path=/trunk/; revision=43327
2012-06-18 05:59:33 +00:00
Guy Harris 128126c1e6 Use the GTK+ message type, not the Wireshark message type, in GTK+
calls.

svn path=/trunk/; revision=43325
2012-06-18 05:57:26 +00:00
Guy Harris 4d7c097f17 Stuff the "Don't show this message again" checkbox in the dialog's
content area.

svn path=/trunk/; revision=43323
2012-06-17 23:24:06 +00:00
Guy Harris 29e4e24184 Add "simple dialog" routines to pop up modal message boxes. Use them in
file.c and routines called from it; non-modal dialogs end up, in some
cases, either hidden, devoid of the input focus and not dismissable, or
both.

svn path=/trunk/; revision=43321
2012-06-17 22:32:03 +00:00
Chris Maynard d9d97cb7ce Fix typos.
svn path=/trunk/; revision=43320
2012-06-17 20:07:32 +00:00
Guy Harris fc2d1024de Forgot to use wtap_dump_can_write_encaps()'s final name.
svn path=/trunk/; revision=43317
2012-06-17 16:53:31 +00:00
Guy Harris 2bd813507a Export a wtap_dump_can_write_encaps() routine from Wiretap; it takes a
file type and a GArray of encapsulation types and returns TRUE if a
capture with all those encapsulation types can be written to a file in
that file type and FALSE otherwise.  Use it where appropriate.

svn path=/trunk/; revision=43315
2012-06-17 16:44:09 +00:00
Guy Harris 4ad0bf65f2 Clean up indentation.
svn path=/trunk/; revision=43314
2012-06-17 16:32:04 +00:00
Pascal Quantin 28e925a381 Allow future forward compatibility
svn path=/trunk/; revision=43312
2012-06-17 16:08:43 +00:00
Gerald Combs 903653131d [Automatic manuf, services and enterprise-numbers update for 2012-06-17]
svn path=/trunk/; revision=43308
2012-06-17 14:03:38 +00:00
Jörg Mayer f41c0b67d1 Try to detect Lua 5.2 as well
svn path=/trunk/; revision=43307
2012-06-17 12:08:42 +00:00
Jörg Mayer ffdddb1228 update lua 5.2.0 -> 5.2.1
svn path=/trunk/; revision=43306
2012-06-17 12:07:46 +00:00
Jörg Mayer 7e10804902 Whitespace fix
svn path=/trunk/; revision=43305
2012-06-17 12:07:08 +00:00
Sake Blok 3bbb0d3bc6 Enhance dissection of the NewSessionTicket handshake message.
svn path=/trunk/; revision=43304
2012-06-17 11:30:25 +00:00
Sake Blok e058a65c17 Fix reading back exported SSL keys. Bug was introduced in r43097.
svn path=/trunk/; revision=43303
2012-06-17 09:02:04 +00:00
Guy Harris a877e3e9d5 Reflect change to wtap_get_savable_file_types.
svn path=/trunk/; revision=43302
2012-06-17 01:50:52 +00:00
Guy Harris c63aa61658 Have wtap_get_savable_file_types() take an array of encapsulations and
only return file types that could handle a single file with all those
encapsulations - this means that

	1) if there's more then one encapsulation, the file format has
to handle per-packet encapsulation;

	2) just because a file format handles per-packet encapsulation,
that doesn't mean that it can handle the *particular* encapsulations
being handed to it.

This fixes some cases where we were claiming that a file could be saved
in a format that doesn't actually support it (e.g., ISDN files being
reported as savable in pcap-NG format - there's no LINKTYPE_ value for
ISDN including B and D channels).

svn path=/trunk/; revision=43300
2012-06-17 01:32:50 +00:00
Guy Harris 5237a5efa2 Move a bunch of toolbar routines into main_toolbar_private.h; they
should only be called by the main window code.

svn path=/trunk/; revision=43299
2012-06-17 00:06:13 +00:00
Guy Harris 480e2c351b Move some code to manipulate the toolbar and capture interface dialog
out of main_menubar.c into routines in main.c.

Move some routines that are only used by main.c into
main_menubar_private.h.

svn path=/trunk/; revision=43298
2012-06-17 00:00:25 +00:00
Guy Harris 8bd9df6671 Oops, main_packet_panes.h no longer exists.
svn path=/trunk/; revision=43297
2012-06-16 23:29:57 +00:00
Guy Harris 9a3a2642f5 Reflect the move of main_proto_draw.c to packet_panes.c.
svn path=/trunk/; revision=43296
2012-06-16 23:11:12 +00:00
Guy Harris 26d50fb7a0 There's not much of note in ui/gtk/main_packet_panes.c; just do those
operations directly in ui/gtk/main.c.

svn path=/trunk/; revision=43295
2012-06-16 23:10:06 +00:00
Guy Harris 6cb63bbc6f Clean up indentation.
svn path=/trunk/; revision=43294
2012-06-16 21:39:16 +00:00
Guy Harris c22b539731 Rename clear_tree_and_hex_views() to main_clear_tree_and_hex_views(), as
it specifically works on the main window's tree and hex dump views (it
doesn't apply to packet windows - they are always showing data from a
particular packet), and move its declaration to main_packet_panes.h.

svn path=/trunk/; revision=43293
2012-06-16 21:37:24 +00:00
Guy Harris 75dba53ad6 Move some routines that specifically handle the main window's packet
panes to main_packet_panes.c.

Rename main_tree_view_new() to proto_tree_view_new() - it's not just for
creating the main window's protocol tree view, it's also for creating
protocol tree views in packet windows.

svn path=/trunk/; revision=43292
2012-06-16 21:30:24 +00:00
Guy Harris 95988da72b ui/gtk/main_proto_draw.c isn't just used for the main window, it's also
used for popped-up packet windows, and it includes more than just code
to draw the protocol tree - it includes the hex dump pane code as well. 
Rename it packet_panes.c; the stuff specific to the main window should
be moved into a different file.

svn path=/trunk/; revision=43291
2012-06-16 20:59:12 +00:00
Guy Harris 57cc5fa784 ui/gtk/main_proto_draw.c isn't just used for the main window, it's also
used for popped-up packet windows, and it includes more than just code
to draw the protocol tree - it includes the hex dump pane code as well. 
Rename it packet_panes.c; the stuff specific to the main window should
be moved into a different file.

svn path=/trunk/; revision=43290
2012-06-16 20:52:04 +00:00
Pascal Quantin 02b7064a87 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7372 :
tcap.otid and tcap.dtid can be used as display filters

svn path=/trunk/; revision=43288
2012-06-16 19:13:48 +00:00
Pascal Quantin d57552df5d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7371 :
Add dissection of Release 8 or higher P-GW QoS profile

svn path=/trunk/; revision=43280
2012-06-16 13:09:51 +00:00
Guy Harris d1128f6433 For a capture file, keep an array of all encapsulation types seen.
Show all of them in the summary dialog; we will be using it in the
future to figure out what capture file formats we can write to (just
because a capture file format supports per-packet encapsulations, that
doesn't mean that it supports *all possible* encapsulations).

svn path=/trunk/; revision=43278
2012-06-15 23:54:05 +00:00
Jakub Zawadzki c43b7b8b93 highlight_field: use passed GtkTreeView for proto_tree_draw.
highlight_field() is also called when we open packet in new window and we click some bytes,
it caused redrawing packet details in *main window* but with protocol tree from (possibly) another frame.

svn path=/trunk/; revision=43277
2012-06-15 23:04:59 +00:00
Gerald Combs 304654f688 Don't install the Qt resource images. They get converted to C arrays in
qrc_*.cpp so they shouldn't be necessary even when we're building and
installing qtshark.

svn path=/trunk/; revision=43274
2012-06-15 18:17:20 +00:00
Bill Meier 1463b2b0c8 Minor cleanup:
- Use _U_ on a fcn parameter so can remove "prevent compiler warning" line of useless code;
- indentation
- ...

svn path=/trunk/; revision=43273
2012-06-15 15:49:05 +00:00
Bill Meier a9690db5a3 Minor Changes:
- checkcol() not needed;
- remove unneeded #include <expert.h>
- remove 'if(tree)' so "bytes dissected" returned always the same.

svn path=/trunk/; revision=43272
2012-06-15 15:15:48 +00:00
Anders Broman 665b95d154 Try to fix pcap-ng - most files created by editcap -c have no IDB
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7350

By using wtap_dump_open_ng() in all places.

svn path=/trunk/; revision=43271
2012-06-15 12:27:21 +00:00
Anders Broman cf28e12ed7 Correct a discrepancy in the specification.
svn path=/trunk/; revision=43270
2012-06-15 11:23:40 +00:00
Chris Maynard 0acb6e6f34 Fix Coverity CID 703858: Unused pointer value.
svn path=/trunk/; revision=43268
2012-06-14 23:56:59 +00:00
Chris Maynard 718a61d6f4 Fix Coverity CID 703859: Unused pointer value.
Fix Coverity CID 703860: Unused pointer value.

svn path=/trunk/; revision=43267
2012-06-14 23:39:44 +00:00
Jakub Zawadzki 2919ac5a5e Add some explation about buffer size.
svn path=/trunk/; revision=43266
2012-06-14 20:13:45 +00:00
Gerald Combs 089a048d4d Add back an absolute path prefix.
svn path=/trunk/; revision=43264
2012-06-14 19:49:57 +00:00
Jakub Zawadzki 0711ac874f Optimize tvb_*_unicode functions.
- Allocate tmpbuf on stack. g_unichar_to_utf8[1] requires maximum 6B + 1 byte for NUL, align it to 8B.
- Use g_string_append_unichar()

[1] http://developer.gnome.org/glib/2.26/glib-Unicode-Manipulation.html#g-unichar-to-utf8

svn path=/trunk/; revision=43263
2012-06-14 19:08:19 +00:00
Gerald Combs 7931a2baf6 More NSIS cleanup.
svn path=/trunk/; revision=43261
2012-06-14 18:53:55 +00:00
Anders Broman 17da162356 Try to fix a couple of warnings.
svn path=/trunk/; revision=43259
2012-06-14 15:50:24 +00:00
Pascal Quantin 2d4d566636 Add dissection of utra-BCCH-Container-r10
svn path=/trunk/; revision=43257
2012-06-14 10:43:54 +00:00
Anders Broman d4aaeccac7 Pretify columns.
svn path=/trunk/; revision=43256
2012-06-14 08:44:45 +00:00
Pascal Quantin 41b3988bbd Fix function name (it is an Authentication failure, not an Attach failure)
svn path=/trunk/; revision=43255
2012-06-14 07:25:53 +00:00
Pascal Quantin 3c20eeb452 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7368 :
Identity request, Identity response and Authentication failure message dissection are swapped

svn path=/trunk/; revision=43253
2012-06-14 07:14:59 +00:00
Guy Harris 21d35d275a In effect, disable closing the main window while a capture is being
stopped - there's no guaranteed way to make the UI's close button
inactive (on X11, it depends on whether the window manager allows that),
but we can just do nothing and return TRUE from the delete event handler
to ignore the delete event.

svn path=/trunk/; revision=43252
2012-06-14 03:50:39 +00:00
Guy Harris 9a0ba17ea5 Re-enable the File -> Quit menu item when the capture stops (or is
started again).

svn path=/trunk/; revision=43251
2012-06-14 03:50:28 +00:00