Clear the list of interfaces before adding new interfaces.
Also fix an endless loop which would occur in case of an error
when getting remote interfaces.
From Irene Ruengeler.
svn path=/trunk/; revision=37618
(so using ifaces) and then using the GUI (which only deals with
iface).
These kind of problems will completely disappear when the
old strucuture components like iface have completely be
retired. This is the next thing we will work on.
svn path=/trunk/; revision=37345
Fixes Bug #4645: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4645
Essentially: The "Capture Start" code "interrupted" the "Capture Options" code and attempted
to use not yet initialized "Capture Options" state.
svn path=/trunk/; revision=35633
- Don't mark callback arg as _U_ if actually used (and vice-versa);
- Use Null as user_data in g_signal_callback if unused in callback;
- Use correct signature for certain event callbacks.
svn path=/trunk/; revision=33895
This allows the dispay of the ws_combo_box choices as a tree.
Also: Rename ws_combo_box_append_text_and_pointer_with_sensitivity() to
ws_combo_box_append_text_and_pointer_full().
svn path=/trunk/; revision=33538
1.0.0. You're supposed to just use 0 in releases prior to 1.1.0 - in
1.1.0 and later, a netmask of PCAP_NETMASK_UNKNOWN will cause errors if
you try to use "ip broadcast" (as you need the netmask to check for
local broadcasts), but, prior to that, the netmask value is blindly used
even if the filter will always fail.
svn path=/trunk/; revision=33461
Use prefs_is_capture_device_hidden() to find out whether a device should
be hidden - don't scan the list of hidden devices ourselves.
svn path=/trunk/; revision=32820
Speak of network adapters rather than network cards (most personal
computers these days have no network cards - the network adapters are on
the motherboard).
svn path=/trunk/; revision=32810
build without libpcap, to make sure that works, and then do a build with
libpcap, to put into a binary release. It's the former that's failing;
I'll back out the previous change and then work on that.
svn path=/trunk/; revision=32801
if_capabilities_t - it doesn't fail on Snow Leopard, even if I undefine
HAVE_PCAP_CREATE, and doesn't fail on the Leopard PPC buildbot, either.
svn path=/trunk/; revision=32799
monitor mode at the same time that we fetch its list of link-layer
types. Support fetching that list in monitor mode, as the list may be
different in regular and monitor mode. If the interface supports
monitor mode, when printing the list of link-layer types, indicate
whether they're fetched in monitor mode or not, as tcpdump 4.1.x does.
svn path=/trunk/; revision=32789
pcap_set_buffer_size() did as well, so there aren't any libpcap releases
with pcap_create() but not pcap_set_buffer_size().
Only do one check for pcap_create.
svn path=/trunk/; revision=32695
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=475
BUT not activating the check for
pcap_create()
pcap_set_buffer_size()
This should make it possible to build with support for setting the buffersize if not capturing 802.11 traffic.
The code for handling the 'B' option should be OK in any case.
svn path=/trunk/; revision=32688
link-layer header types for interfaces; if special privileges are
necessary to open capture devices, Wireshark and TShark shouldn't have
those privileges, but dumpcap should.
svn path=/trunk/; revision=32104
Consolidate some common code. Rename a bunch of variables. Remove some
unused code.
Fix an offset flag bug in airpcap_loader.c.
This had to be merged by hand with r28349. Hopefully none of those
changes were clobbered.
svn path=/trunk/; revision=28350
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats). Hopefully this will catch at least
some P64 issues on UN*X.
svn path=/trunk/; revision=28108
showing the correct type on connect failure or cancel in the remote
interface dialog.
Added list of recent remote hosts to interface type combo box.
Save the recent remote hosts in the recent file.
Fixed some indents.
svn path=/trunk/; revision=26747
without fetching a new list each time the interface changes.
Catch the "activate" signal on the text boxes in the remote interfaces dialog.
svn path=/trunk/; revision=26727
- Moved all RPCAP settings to a "Remote Settings" dialog
- Rearranged "Buffer size" and "Wireless Settings" on win32
- Fall back to local interfaces when error listing remote interfaces
- Fixed setting correct sampling type when reopening the capture dialog
- Aligned some widgets in the "Capture Options" frame
- Added some tooltips
svn path=/trunk/; revision=26687
Get rid of an extra g_strdup() (get_if_name() doesn't mangle its
argument and doesn't modify prefs.capture_device).
If there's no interface on which to capture, pop up a dialog to indicate
that.
svn path=/trunk/; revision=25997
Start Wireshark without a preference file saved. Open the capture options dialog,
then click "Start" button without selecting any interface. Wireshark segfaults while
dereferencing NULL pointer in get_if_name() called from capture_start_cb().
svn path=/trunk/; revision=25987
don't need global_capture_opts don't need to have it declared and thus
don't need capture_options defined.
Include gtk/capture_globals in the files in question.
Change some more capture_opts references to refer to
global_capture_opts.
Change some global_capture_opts references in routines with a
capture_opts argument to refer to capture_opts.
The structure type is capture_options, not capture_opts; fix some
references.
Include <sys/types.h>, if it's present, in capture_opts.h, so we get
gid_t defined.
Clean up indentation.
svn path=/trunk/; revision=25574
now-defult global capture_opts pointer; we eventually should try to
minimize the use of global variables.
Export global_capture_opts from gtk/main.h.
Clean up indentation.
svn path=/trunk/; revision=25571
in "Use multiple files". Also default to storage-based if not time-based.
This fixes the initial problem in bug #2599.
svn path=/trunk/; revision=25489
- retrieving the list of remote PCAP interfaces
- password authentication support
- UDP data fransfer
- packet sampling (available in WinPcap 4.x)
etc.
fix problem if non-default rpcap port is used
svn path=/trunk/; revision=23750
setuid instead of Wireshark. Remove the "DANGEROUS" notices, but leave it
disabled by default. Whine if the user runs Wireshark or TShark as root.
Add a preference to disable the whining. Add a "setuid-root" script that
can be used to switch dumpcap and TShark's setuid-ness on and off for
development and testing. Update the release notes and README.packaging.
svn path=/trunk/; revision=22733
Try to call get_interface_descriptive_name() as little as possible (storing
the result in capture_opts) to avoid a performance hit during live capture
(especially if you have lots of interfaces) and to avoid leaking memory.
One issue with this is that capture_opts.c cannot (without adding significant
dependencies) set the iface_descr so readers of that field (only gtk/main.c
and tshark.c) use a macro to (set if not already set and) get the value of
that field.
svn path=/trunk/; revision=22587
that "-D" and "-L" should produce machine-readable output. Use this to
move an indirect get_pcap_linktype() call from the GUI to dumpcap.
svn path=/trunk/; revision=22367
Add a capture_interface_list(), which works similar to
get_interface_list() except that it forks dumpcap instead of calling
the pcap routines directly. Use it in the GUI.
Add a "-I" flag to dumpcap, which prints out verbose interface
information.
Tested under Windows and Linux.
svn path=/trunk/; revision=22071
- Update the wireless/AirPcap GUI code to support 802.11n as well as
some related upcoming code changes.
- Remove airpcap.h from the repository, since it exists in the AirPcap
devpack (and will be superseded Real Soon Now).
- Show the individual channel flag bits in radiotap.
Fix the 802.11n MCS set display.
This is a partial checkin, so hopefully nothing is broken.
svn path=/trunk/; revision=21831
screen
Changed IP address label to fit into an event box which is in the ip
address hbox. This allows the label to expand to fit the capture dialog
window, but no further. Expanding the capture dialog window will show
more IP addresses. Left align the label. Add ... in the middle of a
long list of IP addresses to show the first few and the last few with
the gtk_label_set_ellipsize() function in GTK 2.6 and up.
svn path=/trunk/; revision=21038
as an argument, and, on an error, if they have an error message, have
them set that "gchar *" to point to a g_malloc()ed string containing the
error message, rather than taking a pointer to a buffer for that message
as an argument. That's more like what's done in Wiretap, and doesn't
impose an upper limit on the lengths of those error messages. If that
pointer is null, don't allocate the message string and return it.
Have that error message already have the "cant_get" processing applied
to it, so nobody other than those routines need to call the "cant_get"
routines to process the error messages.
Have get_airpcap_interface_list() explicitly set "*err" to the
appropriate error code.
Clean up indentation.
svn path=/trunk/; revision=20521
Michael Tüxen