Commit Graph

14 Commits

Author SHA1 Message Date
Guy Harris 0bb9b054b5 From Stephen Shelley: the unit ID and function code fields in the Modbus
header are unsigned - make them so.

While we're at it, make them "guint8" rather than "guchar", to make it
explicit that they're one byte long.

svn path=/trunk/; revision=7650
2003-05-08 00:42:28 +00:00
Guy Harris a5e8c99294 From Stephen Shelley: remove a TODO comment that describes stuff that's
been done.

svn path=/trunk/; revision=7487
2003-04-18 04:45:00 +00:00
Guy Harris f17519118c From Stephen Shelley: full payload dissection of compliance levels 0, 1
and 2 function codes for Modbus/TCP, plus some bug fixes.

Use value_string tables to map function codes and exception codes to
strings.

svn path=/trunk/; revision=7468
2003-04-16 06:57:38 +00:00
Jörg Mayer 7c4176d868 Removed trailing whitespaces from .h and .c files using the
winapi_cleanup tool written by Patrik Stridvall for the wine
project.

svn path=/trunk/; revision=6117
2002-08-28 21:04:11 +00:00
Jörg Mayer 173fe5aef4 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.

svn path=/trunk/; revision=5932
2002-08-02 23:36:07 +00:00
Guy Harris 77fa06b899 From Joerg Mayer:
dftest.c:
	     Remove #if-0-ed includes

	packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
        packet-wtp.c, ethereal_gen.py:
	     Remove redundant include varargs (already in snprintf.h,
	     and required only for snprintf.h)

	Remove unused include of snprintf.h from files not using
	"snprintf()".

svn path=/trunk/; revision=5889
2002-07-17 00:43:03 +00:00
Guy Harris ee5ca25d31 Include files from the "epan" directory and subdirectories thereof with
"epan/..." pathnames, so as to avoid collisions with header files in any
of the directories in which we look (e.g., "proto.h", as some other
package has its own "proto.h" file which it installs in the top-level
include directory).

Don't add "-I" flags to search "epan", as that's no longer necessary
(and we want includes of "epan" headers to fail if the "epan/" is left
out, so that we don't re-introduce includes lacking "epan/").

svn path=/trunk/; revision=4586
2002-01-21 07:37:49 +00:00
Guy Harris 23319ff023 Move the pointer to the "column_info" structure in the "frame_data"
structure to the "packet_info" structure; only stuff that's permanently
stored with each frame should be in the "frame_data" structure, and the
"column_info" structure is not guaranteed to hold the column values for
that frame at all times - it was only in the "frame_data" structure so
that it could be passed to dissectors, and, as all dissectors are now
passed a pointer to a "packet_info" structure, it could just as well be
put in the "packet_info" structure.

That saves memory, by shrinking the "frame_data" structure (there's one
of those per frame), and also lets us clean up the code a bit.

svn path=/trunk/; revision=4370
2001-12-10 00:26:21 +00:00
Guy Harris bced8711f6 Make "dissector_add()", "dissector_delete()", and "dissector_change()"
take a dissector handle as an argument, rather than a pointer to a
dissector function and a protocol ID.  Associate dissector handles with
dissector table entries.

svn path=/trunk/; revision=4308
2001-12-03 04:00:26 +00:00
Guy Harris 1d42c94b05 Make the resolution for time values be nanoseconds rather than
microseconds.

Fix some "signed vs. unsigned" comparison warnings.

svn path=/trunk/; revision=3934
2001-09-14 07:10:13 +00:00
Guy Harris 8412393197 From Joerg Mayer: explicitly fill in all members of a
"header_field_info" structure, including the ones that are later set by
the routines to register fields.

svn path=/trunk/; revision=3561
2001-06-18 02:18:27 +00:00
Guy Harris 595241a676 Clearing a column before adding text to it with "col_add_fstr()" is
unnecessary.  Clearing it before fetching anything from the packet with
a call that might throw an exception, however, is a Good Idea.

The Modbus/TCP dissector is called from a dissector table, so it doesn't
have to check if the protocol is enabled, or set "pinfo->current_proto"
- that's done for it by the dissector-table code.

svn path=/trunk/; revision=3378
2001-04-24 23:22:03 +00:00
Guy Harris d40b312548 Get the "." out of the URL for the Modbus/TCP home page.
Fix Gerald's e-mail address.

svn path=/trunk/; revision=3377
2001-04-24 19:31:33 +00:00
Guy Harris 20a79084a9 Modbus/TCP support, from Riaan Swart.
svn path=/trunk/; revision=3376
2001-04-24 19:29:14 +00:00