Commit graph

17370 commits

Author SHA1 Message Date
Anders Broman
d7610e4c0a From Laurent Rabret,
2 patches for the "flow graph" display. It is better not to insert invalid packets into the list than to control the list is correct while using it...

svn path=/trunk/; revision=17622
2006-03-14 05:49:15 +00:00
Ronnie Sahlberg
2f37e2de15 coverity bug 44
svn path=/trunk/; revision=17621
2006-03-14 05:38:47 +00:00
Ronnie Sahlberg
0e46ae1dd6 handle coverity bug 36
svn path=/trunk/; revision=17620
2006-03-14 05:30:26 +00:00
Ronnie Sahlberg
877d757062 put the opcode as a generated field inside data pdus for scsi
svn path=/trunk/; revision=17619
2006-03-14 04:56:40 +00:00
Ronnie Sahlberg
dd99a25837 prettifu getconfiguration response
svn path=/trunk/; revision=17618
2006-03-14 01:18:43 +00:00
Luis Ontanon
89c487756e missed to add strptime.obj to the editcap.
svn path=/trunk/; revision=17617
2006-03-14 00:17:22 +00:00
Ronnie Sahlberg
0398f48341 set current_proto to SCSI so that the exception handler will show the correct protocol
fix length in getconfiguration()  so that we provide the proper one (+4)
to avoid marking valid packets as malformed.



svn path=/trunk/; revision=17616
2006-03-13 22:35:14 +00:00
Luis Ontanon
3318411aa7 Use checkTextWindow instead of shiftTextWindow to fetch the window object from the stack, shiftXxx will happily (and rightfully) return a null pointer without an error.
svn path=/trunk/; revision=17615
2006-03-13 22:22:17 +00:00
Luis Ontanon
fb41328889 Add -A <start time> and -B <stop time> options to editcap
svn path=/trunk/; revision=17614
2006-03-13 22:20:07 +00:00
Ulf Lamping
3048f90e45 remove a compiler warning
svn path=/trunk/; revision=17613
2006-03-13 22:19:36 +00:00
Ronnie Sahlberg
cdf3a2b322 if tcp checksum validation is enabled
and if the checksum is wrong
and if the checksum field is 0x0000

mark the packet as [Checksum Offloaded] and still allow reassembly of
tcp segmetns


since it is most likely just a tco checksum offload engine and not a real checksum error



svn path=/trunk/; revision=17612
2006-03-13 20:50:50 +00:00
Ronnie Sahlberg
edcaaee164 SCSI is fairly unique among the ethereal protocols in that it is sometimes normal for a PDU we receive back froma device to be truncated.
(report luns with allocation length 8 for example)

Therefore it is a bit wrong to mark these packets as [malformed packets]
Since they are truncated by scsi   and this is NOTY an error condition.


Add a new exception type  :  ScsiBoundsError
If this exception is caught by packet-frame, then print an appropriate message
instead of [malformed packet]

For SCSI, add helper macros TRY_SCSI_SHORT_PACKET   and END_...


If the packet was not short in the normal sense (snaplen < packetlen) then intercept the exception for BoundsError and rethrow it as ScsiBoundsError instead.





svn path=/trunk/; revision=17611
2006-03-13 10:29:00 +00:00
Anders Broman
11c3d3d90d From Ming Zhang
added another command preventallowmediaremoval besides those 3.

> enhanced packet-scsi.c a bit to decode 3 more scsi commands
> 
> getperformance
> setcdspeed
> readdiscstructure.



svn path=/trunk/; revision=17610
2006-03-13 06:23:59 +00:00
Luis Ontanon
ad6eb21dd1 Expert info is going to be used in runtime.
For the sake of speed use integers instead of strings to then be converted into integers.


svn path=/trunk/; revision=17609
2006-03-13 00:31:04 +00:00
Ulf Lamping
069b26b2d9 fix bug #803: sync pipe on Win32 wasn't set to binary mode, so error message transport failed between Ethereal and dumpcap.
I've also changed the way the secondary error message is transported from former "header message 0 secondary 0" to "header header message 0 header secondary 0" as that might be a bit more clearer, and I'll need it for further development anyway.

I was using this while debugging and not recognizing the real problem - for about four hours :-(. I'll need this feature when doing the interface (and link layer type) browsing later (transferring this data from dumpcap to Ethereal) to get a full blown privilege seperation.

svn path=/trunk/; revision=17608
2006-03-13 00:30:51 +00:00
Luis Ontanon
4bafab904c This time, should be the good one!
svn path=/trunk/; revision=17607
2006-03-12 21:45:18 +00:00
Ulf Lamping
6610672d0c is that what you meant?
svn path=/trunk/; revision=17606
2006-03-12 21:15:01 +00:00
Luis Ontanon
940afa0877 Let's see if at the third attempt I get it right...
svn path=/trunk/; revision=17605
2006-03-12 20:48:14 +00:00
Luis Ontanon
b85e0d1a29 Let's try again!
svn path=/trunk/; revision=17604
2006-03-12 19:47:29 +00:00
Luis Ontanon
f100efb165 I Hope this works
svn path=/trunk/; revision=17603
2006-03-12 18:57:38 +00:00
Luis Ontanon
f4c227852c Move make-init-lua.pl and family to plugins/lua and have init.lua installed in the right place
svn path=/trunk/; revision=17602
2006-03-12 17:39:46 +00:00
Jaap Keuter
20707c71ec Assure that pinfo is a valid pointer. Related to Coverity CID 112
svn path=/trunk/; revision=17601
2006-03-12 16:42:10 +00:00
Luis Ontanon
25ff5cd787 Move init.lua and family to plugins/lua
svn path=/trunk/; revision=17600
2006-03-12 16:41:34 +00:00
Luis Ontanon
5ca4b68272 reenable TreeItem,
shiftXXX() was broken


svn path=/trunk/; revision=17599
2006-03-12 15:31:33 +00:00
Luis Ontanon
72c79c1289 Protocols are now invoked.
svn path=/trunk/; revision=17598
2006-03-12 13:03:18 +00:00
Ronnie Sahlberg
f5ef51d37f revert back to svn 17587
svn path=/trunk/; revision=17597
2006-03-11 23:16:34 +00:00
Ronnie Sahlberg
dfd3e11e65 oops removed one check too many
when we lookup grandparent,   check that we actually have a grandparent.



svn path=/trunk/; revision=17596
2006-03-11 22:40:52 +00:00
Luis Ontanon
428823b00e Remove debug code...
svn path=/trunk/; revision=17595
2006-03-11 22:26:08 +00:00
Luis Ontanon
b3a173664b Protocols register OK.
svn path=/trunk/; revision=17594
2006-03-11 22:05:40 +00:00
Ulf Lamping
297ed538fc mark parser error messages as Ethereal generated
svn path=/trunk/; revision=17593
2006-03-11 20:19:20 +00:00
Ulf Lamping
db279bee85 add dumpcap to the list of new features
svn path=/trunk/; revision=17592
2006-03-11 18:51:57 +00:00
Luis Ontanon
cff34ee126 Close the files after reading!
svn path=/trunk/; revision=17591
2006-03-11 18:19:48 +00:00
Luis Ontanon
19f81800ba use se_trees instead of GHashTables,
rename binding into assoc(iation) which is the AOC name.
move the definition of sccp_assoc_t to packet-sccp.h so that information regarding sccp associations it can be used by user protocols



svn path=/trunk/; revision=17590
2006-03-11 15:30:52 +00:00
Ronnie Sahlberg
01bf34cb88 remove some redundant calls and checks and pass the required pointers as parameters instead to make it slightly faster
svn path=/trunk/; revision=17589
2006-03-11 13:36:22 +00:00
Ronnie Sahlberg
aba18252db document the char *name parameter to the create tree functions
svn path=/trunk/; revision=17588
2006-03-11 13:21:41 +00:00
Ronnie Sahlberg
27de4cfd39 give se_trees names so that it is easier to debug and to log how often certain trees are accessed
svn path=/trunk/; revision=17587
2006-03-11 13:02:41 +00:00
Ronnie Sahlberg
fb48a75091 remove some unusued parameters
svn path=/trunk/; revision=17586
2006-03-11 12:33:15 +00:00
Luis Ontanon
6e4aa06681 Avoid a coverity false positive (CID 38) from being considered.
svn path=/trunk/; revision=17585
2006-03-11 12:12:10 +00:00
Luis Ontanon
59ec8529e1 Mark coverity CID 117 as a false positive.
Lex code is often hard for humans to understand... neither of the error conditions found would be happening...

One was marked as error because coverity does not understand that yyterminate() breaks execution.

The other marked as an error because coverity is not able to figure out that the error appears in an actions against two different rules that will not ever match toghether.



svn path=/trunk/; revision=17584
2006-03-11 12:07:00 +00:00
Ronnie Sahlberg
90bec589e8 second try to fix the bug
svn path=/trunk/; revision=17583
2006-03-11 12:03:28 +00:00
Ronnie Sahlberg
662346cf94 the code forgot to update offset *offset++ is not the same as offset++ :-)
svn path=/trunk/; revision=17582
2006-03-11 12:00:59 +00:00
Luis Ontanon
f7b7ade499 Mark coverity's CID 105 as a false positive.
(The macro GET_MSG_TYPE does propper bounds checking but coverity doesn't consider it (may not be able to resolve the ?: operator) )


svn path=/trunk/; revision=17581
2006-03-11 11:55:49 +00:00
Luis Ontanon
9ed9299e17 Remove an entire horde of off-by-one errors pointed out by Coverity's CID: 83
(Coverity finds just one at a time...)


svn path=/trunk/; revision=17580
2006-03-11 11:48:35 +00:00
Luis Ontanon
40f5303a8e replace GHashTables with se_trees
svn path=/trunk/; revision=17579
2006-03-11 11:45:36 +00:00
Ronnie Sahlberg
2a2039729a include emem.h
otherwise ep_strdup() defaults to int   which will break
if pointers are bigger than integers.


this should fix bugs 797  802  805 806


svn path=/trunk/; revision=17578
2006-03-11 11:18:56 +00:00
Ulf Lamping
22dca0c988 ... and don't forget to include emem.h!
svn path=/trunk/; revision=17577
2006-03-11 09:09:55 +00:00
Ulf Lamping
2e2c970da9 replace g_malloc and alike by their corresponding ep_ functions
svn path=/trunk/; revision=17576
2006-03-11 09:08:18 +00:00
Ronnie Sahlberg
7782c6b6f6 forgot to paint a node causing massively unbalanced tree
svn path=/trunk/; revision=17575
2006-03-11 06:12:36 +00:00
Jörg Mayer
7e40853dbb propset...
svn path=/trunk/; revision=17574
2006-03-11 01:45:42 +00:00
Ronnie Sahlberg
76a2df4a58 dont declare variables in the middle of a code block. many compilers do not like that.
svn path=/trunk/; revision=17573
2006-03-11 00:58:16 +00:00