Commit graph

4554 commits

Author SHA1 Message Date
Ronnie Sahlberg
fd58413224 start decoding PA_PW_SALT in the PA-DATA structure.
for the time being   since i have never seen this salt being used elsewhere,
assume everything is the MS style salt:

guint32 nt_status
guint32 unknown
guint32 unknown


if the MS KDC does nopt allow a client to grab a ticket (due to policy   client can only log in at certain hours or such)
KDC will repsond with a failuer with edata like above   and nt-status ==  STATUS_LOGON_HOURS




svn path=/trunk/; revision=17722
2006-03-24 21:41:01 +00:00
Ronnie Sahlberg
54f9da2135 the edata field is PA-DATA for error PREAUTH_FAILED just the same as for PREAUTH_REQUIRED
add decode of edata field for the error code PREAUTH_FAILED



svn path=/trunk/; revision=17721
2006-03-24 21:16:47 +00:00
Jaap Keuter
b21337192c From Olivier Jacques:
- to_str.c: add support of "AT_NONE" address type in address_to_str_buf (avoid the assert failed later on
when messages have address type of AT_NONE - which can be the case for an MTP2 capture with FISU messages)
- packet-isup.c: changed source and destination addresses from (net_src and net_dst) to (src and dst) so 
that addresses taken into account in the statistics are the SS7 point codes

svn path=/trunk/; revision=17720
2006-03-24 14:26:01 +00:00
Anders Broman
8d61e9b902 Mark the value_strings static.
svn path=/trunk/; revision=17718
2006-03-24 07:10:22 +00:00
Anders Broman
9a6f6e7d37 From Ravi Valmikam
1. Decode A11 Session Update message
 
2. Decode A10 3GPP2 (GRE Payload Type 0x88D2) packets with the following attributes
    - Flow Control
    - Segmentation
    - SDI Indicator
    - Flow Discriminator

svn path=/trunk/; revision=17717
2006-03-24 07:09:35 +00:00
Ulf Lamping
e43c4e50c9 add another comment what's currently missing in the PROFINET specific parts
svn path=/trunk/; revision=17713
2006-03-24 02:20:37 +00:00
Jaap Keuter
a10dd1b04e Completed Channel Identification IE with Channel number/Slot map field
svn path=/trunk/; revision=17712
2006-03-23 23:04:43 +00:00
Anders Broman
e4bdd466cf From Mike Duigou:
> I have improved the heuristics and the display tree building code in
> dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem.

svn path=/trunk/; revision=17709
2006-03-23 18:42:25 +00:00
Gerald Combs
40be5362b6 Coverity CID 48 is still complaining about a NULL dereference. Hopefully
this will fix it.

svn path=/trunk/; revision=17708
2006-03-23 18:22:42 +00:00
Anders Broman
b0d52994be Covierty bug fix.
svn path=/trunk/; revision=17705
2006-03-23 17:00:32 +00:00
Anders Broman
7186d13653 Fix bug:
825 setup message has an error in gsm-a-dtap 

svn path=/trunk/; revision=17704
2006-03-23 16:59:48 +00:00
Anders Broman
2f9f463ede Fix Bugs
820     gsm-map checkIMEI decoding error  
821     gsm-map sendIMSI decoding error  

svn path=/trunk/; revision=17703
2006-03-23 16:58:50 +00:00
Luis Ontanon
fdb5257f7c Bug 796
the dictionary parser could not handle more than one attribute with parameters per file 


svn path=/trunk/; revision=17702
2006-03-23 00:57:56 +00:00
Michael Tüxen
fd0640e930 Update to draft-ietf-tsvwg-sctp-auth-02.txt.
svn path=/trunk/; revision=17701
2006-03-23 00:36:35 +00:00
Anders Broman
441d892b13 From Motonori Shindo:
find attached the patch that reflects this interpretation of 
> this field accordingly. It also fixes a few minor bugs associated with 
> the handling of 'UNIX Secs' field and two field types
> (LAST_SWITCHED(21) and FIRST_SWITCHED(22)) in case of NetFlow V9.

svn path=/trunk/; revision=17698
2006-03-22 17:19:56 +00:00
Anders Broman
8fa4a23147 From Jeff Morris
fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=332

svn path=/trunk/; revision=17697
2006-03-22 17:13:09 +00:00
Anders Broman
f0c117048d Handle two octet lengths correctly and remove optional decoding of sns_config, as I read the standard there is no difference.
svn path=/trunk/; revision=17696
2006-03-22 17:11:31 +00:00
Anders Broman
f935a4f8f6 Fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=820
svn path=/trunk/; revision=17695
2006-03-22 17:10:19 +00:00
Jaap Keuter
f4248f455d From Bill Meier:
Ensure "relevant function" logic works for loopback packets containing multiple forwarding addresses.


svn path=/trunk/; revision=17689
2006-03-21 06:54:12 +00:00
Anders Broman
3239ded778 svn properties
svn path=/trunk/; revision=17686
2006-03-20 19:53:07 +00:00
Anders Broman
6087ba3942 svn properties
svn path=/trunk/; revision=17685
2006-03-20 19:51:06 +00:00
Anders Broman
ea024eb4ad From Martin Mathieson:
Some cosmetic changes:
- when working out the application id description to show in the info 
column, also consider vendor application identifiers
- make sure application ids and command codes are always shown as 
decimal numbers
- a little whitespace tidyup

svn path=/trunk/; revision=17684
2006-03-20 19:46:04 +00:00
Ronnie Sahlberg
f331077a60 waste a couple of bytes per tcp conversation and make the tree for acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global.
while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite   tcp analysis might actually work and work well even for tcp over tcp tunnelling. 

this also means that if you include packet-tcp.h   you also need to include emem.h .




svn path=/trunk/; revision=17681
2006-03-20 10:52:53 +00:00
Guy Harris
ce711119e0 Add guid_to_str to the list of exported functions.
svn path=/trunk/; revision=17678
2006-03-19 22:44:47 +00:00
Guy Harris
7db8eea5c6 Make the GUIDs in various data structures e_guid_t's rather than arrays
of 16 bytes.  Use "sizeof" for the size of e_guid_t's, and use structure
assignment to copy GUID values.

Make functions such as append_h225ras_call() and new_h225ras_call() take
pointers to e_guid_t's as arguments.

Define GUID_LEN in epan/guid-utils.h and use it as the length of a GUID
in a packet.  (Note that "sizeof e_guid_t" is not guaranteed to be 16,
although it is guaranteed to be the size of an e_guid_t.)

When constructing a display filter that matches a GUID, use
guid_to_str() to construct the string for the GUID.

svn path=/trunk/; revision=17676
2006-03-19 20:45:45 +00:00
Guy Harris
0d66eda9ba Fix some format strings to display all fields in some mode sense page
bytes.

Constify some variables to squelch compiler warnings.

svn path=/trunk/; revision=17672
2006-03-19 20:23:17 +00:00
Guy Harris
f1a5571448 Turn the handle types into an enum, so that they're more likely to be
displayed by name in debuggers and so that switch statements can check
whether all types are handled.

Add a check for an unknown handle type, to squelch compiler warnings
(and to catch missing handle type code at run-time, if new handle types
are added).

svn path=/trunk/; revision=17671
2006-03-19 20:21:56 +00:00
Guy Harris
cfe070105f Fix typo.
svn path=/trunk/; revision=17670
2006-03-19 20:19:40 +00:00
Jaap Keuter
be52b0238d No negative power consumption, so unsigned value.
svn path=/trunk/; revision=17669
2006-03-19 17:32:21 +00:00
Jaap Keuter
0050f4e68d Patch that fixes bug 793 and a few other things mostly revolving around
BACnet schedules.  Could someone please take care of this?

1) fDate - correctly handle wild card year
2) fTime - rename local variables cut-and-pasted from fDate
3) fCalendarEntry - do single-pass decoding rather than while loop since the structure cannot be repeated.
4) fDailySchedule - correctly handle enclosing context tags.
5) fWeeklySchedule - correctly handle enclosing context tags
6) fAcknowledgeAlarmRequest - fix function name spelling and tags 3 and 5 are timeStamp, not time.
7) fSpecialEvent - handle context tags correctly.
8) fReadRangeRequest - Add cases from 2004 spec

Dave Richards


svn path=/trunk/; revision=17667
2006-03-19 12:28:21 +00:00
Lars Roland
e810b7a424 - dissect sip headers properly when they are extended over multiple lines
- skip white space characters, including CR and LF on various places (not complete yet, but better than before)

svn path=/trunk/; revision=17665
2006-03-18 20:28:40 +00:00
Ronnie Sahlberg
93471988aa rename se_tree_lookup32_less_than_or_equal()
to se_tree_lookup32_le()


svn path=/trunk/; revision=17664
2006-03-18 09:01:42 +00:00
Ronnie Sahlberg
c4c2ce2606 add new se_tree_lookup32_less_than_or_equal() call
svn path=/trunk/; revision=17663
2006-03-18 06:15:39 +00:00
Lars Roland
87e4a20bbb Make some string comparisons case insensitive in the sip dissector
svn path=/trunk/; revision=17662
2006-03-18 04:40:11 +00:00
Lars Roland
b63ee69750 Add some dependencies for libethereal.dll, so it gets re-build, if someone just changes a source file in a subdirectory (e.g. a dissector)
svn path=/trunk/; revision=17661
2006-03-18 03:32:10 +00:00
Lars Roland
fc81794dc9 based on a patch from Martin Mathieson:
- dissection of SIP headers containing credentials and challenges.

from me:
- add filter fields for some missing related parameters from RFC 3261
- improve calculation of parameter length.

This implements enhancement request (bug id 812)

svn path=/trunk/; revision=17660
2006-03-18 03:23:26 +00:00
Ulf Lamping
6ea4c2745e add missing IDispatch methods and related dissections
svn path=/trunk/; revision=17658
2006-03-17 21:41:56 +00:00
Ronnie Sahlberg
b43c495d49 fix for coverity bug 41
if decryption failed there was a possibility to dereference a null pointer


svn path=/trunk/; revision=17657
2006-03-17 21:03:14 +00:00
Jaap Keuter
09f2ccdca3 Fix bug 819: make sure to always return a tvb pointer.
svn path=/trunk/; revision=17656
2006-03-17 11:46:07 +00:00
Anders Broman
d2ae4f4c7a From Ming Zhang:
added 3 MCC mode pages decode support.

MRW page
Write param page
capacity page

also fixed several wrong tvb_get_ntohs usage introduced in previous patch.

svn path=/trunk/; revision=17654
2006-03-17 06:26:14 +00:00
Ulf Lamping
0ef693174e fix some typos in a comment
svn path=/trunk/; revision=17653
2006-03-16 23:18:15 +00:00
Anders Broman
3c2c4a390a Fix dissection of QoS.
svn path=/trunk/; revision=17650
2006-03-16 21:16:30 +00:00
Anders Broman
a784b12150 If version is v6 let the IPv6 dissetor handle it.
svn path=/trunk/; revision=17649
2006-03-16 20:14:47 +00:00
Anders Broman
cfbc70a648 Add some extension IE:s
- APN Restriction
 - RAT Type
-  IMEI(SV)

svn path=/trunk/; revision=17648
2006-03-16 20:13:17 +00:00
Jaap Keuter
c673b2f4f1 Fixed skipCount decoding. Added "relevant function" tag and put relevant function into INFO column.
svn path=/trunk/; revision=17646
2006-03-16 17:47:45 +00:00
Jaap Keuter
d3efbd7284 Superfluous check on 'secret' removed.
Coverity CID 31

svn path=/trunk/; revision=17645
2006-03-16 12:27:50 +00:00
Luis Ontanon
182553b988 From: Peter Johansson
have mtp3_pc_hash() explicitly returning pc.

From me:
 break; execution inside the switch.


svn path=/trunk/; revision=17643
2006-03-16 10:23:09 +00:00
Ronnie Sahlberg
107f59142d the new type of sid/rid structure is for lookupnames2 not lookupnames
svn path=/trunk/; revision=17642
2006-03-16 08:47:19 +00:00
Jaap Keuter
87212ed160 Add missing preference storage.
svn path=/trunk/; revision=17639
2006-03-15 21:22:11 +00:00
Anders Broman
61b223303a From Greg Morris:
Modification to (proto.h) is made to add an additional expert group type of PI_REQUEST_CODE to allow Request tag information to be passed to the expert tap. This is for such reasons where a dissector would like to echo specific information about certain types of requests. For example: NCP connection request is really a request not a REPLY_CODE. Same is true for the TCP SYN request.

Changes to packet-ncp.c
1. Server broadcast message flag. Now indicates if the message is a pending message or an oplock clear notification.
2. Cleanup of packet signature detection process. Previous method had some flaws so I redesigned it. Appears to be solid now.
3. Echo NCP Server Session information to expert tap.
 
Note on item #3: NCP Connection+Task = NCP Session, a Single connection can have many tasks. The server sees each connection/task as a unique session. For this reason the NCP session information is now echoed to the expert composite statistics so that you can easily identify the different NCP processes and sessions. It is important to NCP analysis to understand that each session is most likely a different program on the requesting host sharing the same NCP connection.
 
Changes to packet-ncp2222.inc
1. Comment out the echo of NCP connection info to expert tap. Replaced by NCP sessions.
2. Add displayEID in request decode (resolves Coverity defect for dead code in NCP dissector)
 
Changes to ncp2222.py
1. Fix for endian display of bindery object type in NCP 0x1720.
2. Fix for size of bindery object type to 2 bytes instead of 4 to match other bindery NCP's.

svn path=/trunk/; revision=17636
2006-03-15 18:56:35 +00:00