Commit Graph

44837 Commits

Author SHA1 Message Date
Evan Huus fc48d80b32 Use glib's isdigit function.
svn path=/trunk/; revision=47565
2013-02-08 14:03:33 +00:00
Michael Mann faf307e2fc Support SDP context over SIP.
Added setup_sdp_transport() to allow higher layer protocols to call SDP with context to correctly setup an OFFER/ANSWER within SDP (which doesn't have its own transport layer).  I attempted to keep backwards compatibility until all higher layer protocols set up OFFER/ANSWER context.  If OFFER/ANSWER (request/response) can't be found (which would be the case for higher layer protocols without context), Wireshark should resort to the old behavior of applying SDP information as it sees packets.

This patch includes integration with SIP as it appears to have the most bug reports.  Other higher layer protocols will be done later.  Most are mentioned in bug 2368.

Fixes bug 2368 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2368) and all its duplicates
Fixes bug 2992 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2992) and all its duplicates

svn path=/trunk/; revision=47564
2013-02-08 13:47:07 +00:00
Alexis La Goutte 14780d9a0d Add new images to Makefile.am (needed when use make dist-*)
svn path=/trunk/; revision=47562
2013-02-08 10:14:09 +00:00
Guy Harris e92f2f398d Constify the name member of a struct _proto_xmlpi_attr, to squelch
warnings.

svn path=/trunk/; revision=47561
2013-02-08 09:09:29 +00:00
Guy Harris 922a57753b Constify the second argument to uat_load(), to squelch some warnings.
svn path=/trunk/; revision=47560
2013-02-08 09:06:08 +00:00
Guy Harris 1df459c415 Constify the return value of append_to_buffer(), to squelch some
warnings.

svn path=/trunk/; revision=47559
2013-02-08 09:00:03 +00:00
Guy Harris 2cbfc5db98 Constify the return value of replace_entity(), to squelch some warnings.
svn path=/trunk/; revision=47558
2013-02-08 08:56:55 +00:00
Guy Harris a52fedeece Stick NONGENERATED_ in the front of the macros listing non-generated
files.  Define C_FILES and CPP_FILES in Makefile.common.inc to include
*all* C and C++ files, respectively, including generated files.

svn path=/trunk/; revision=47557
2013-02-08 05:31:13 +00:00
Guy Harris ddd4e48890 We don't care what source files are "dissector" source files, we only
need to care whether source files should be scanned for registration
functions.

Reduce the number of macros we define in Makefile.common.inc, getting
rid of some only used internally.

svn path=/trunk/; revision=47556
2013-02-08 04:20:32 +00:00
Gerald Combs fad8b88242 Capitalize the short name.
svn path=/trunk/; revision=47555
2013-02-08 03:17:13 +00:00
Jeff Morriss 3ae58ce943 Put all the aclocal-fallback files in the source distribution.
svn path=/trunk/; revision=47554
2013-02-08 02:53:53 +00:00
Jeff Morriss de92a29c0c Move move of the Qt checks into AM_PATH_QT.
svn path=/trunk/; revision=47553
2013-02-08 02:51:14 +00:00
Evan Huus e1bfc1c61c Fix issue where using realloc() to shrink a chunk could result in
multiple adjacent free chunks. When splitting a used chunk, the resulting
extra unused chunk may need to be merged to its right.

svn path=/trunk/; revision=47552
2013-02-08 02:40:05 +00:00
Evan Huus ebc2067e30 Add explicit casts to pacify MSVC buildbot.
svn path=/trunk/; revision=47551
2013-02-08 02:15:03 +00:00
Evan Huus 9fcb518818 Make use of the new garbage-collection routines when closing a file.
svn path=/trunk/; revision=47550
2013-02-08 01:58:04 +00:00
Evan Huus 63313f0c70 Update wmem docs
svn path=/trunk/; revision=47549
2013-02-08 01:50:35 +00:00
Evan Huus b636b88646 Expose the new wmem API functions, and use a consistent order of
alloc/free/realloc across all of wmem.

svn path=/trunk/; revision=47548
2013-02-08 01:47:48 +00:00
Evan Huus eea6cb6315 Rewrite the block allocator to support the new wmem API (realloc, free, gc).
Some interesting algorithmic stuff going on in here for those who are
interested.

This completes the allocator rewrites for the API additions, so those can be
exposed now.

svn path=/trunk/; revision=47547
2013-02-08 01:38:03 +00:00
Gerald Combs dcd8e9df5a Add module_preferences_scroll_area.*.
svn path=/trunk/; revision=47546
2013-02-08 01:30:31 +00:00
Gerald Combs 24d67b60ab Add a ModulePreferencesScrollArea widget which builds a scrollable frame
for a preferences module. Use it to fill in the remaining preferences.
Don't show the printing preferences since they're not used here.

Change the titles and tooltips for some of the name resolution
preferences.

Disable the capture preferences if we can't capture. This is different
from the GTK+ version which hides it completely.

Thus concludes the preferences dialog (for the time being).

svn path=/trunk/; revision=47545
2013-02-08 01:16:46 +00:00
Jeff Morriss 4bbe78cbdf If we're compiling for Qt check if we have a working C++ compiler.
svn path=/trunk/; revision=47544
2013-02-08 01:16:27 +00:00
Jeff Morriss c8d70864c6 Check for QtCore instead of Qt.
svn path=/trunk/; revision=47543
2013-02-07 22:58:38 +00:00
Bill Meier 1e64a82f02 Add addition test to reduce false positives for 'ERROR: NO ARRAY: '
Essentially:
 Detect when an hf_... var is effictively initialized
 via the use of proto_registrar_get_id_byname() or
 proto_get_id_by_filter_name() (instead of
 proto_register_field_array()).

svn path=/trunk/; revision=47542
2013-02-07 22:16:39 +00:00
Bill Meier 900d29a95e Use proto_registrar_get_id_byname() instead of proto_registrar_get_byname();
The code is slightly cleaner and the use of proto_registrar_get_id_byname()
 enables an additional checkhf test to reduce false positives.

Also: comment out 2 unused hf_... vars in packet-smb-sidsnooping.c
(found by checkhf)


svn path=/trunk/; revision=47541
2013-02-07 22:07:49 +00:00
Bill Meier cfff564398 Add 'proto_registrar_get_id_byname()' accessor.
svn path=/trunk/; revision=47540
2013-02-07 22:04:02 +00:00
Bill Meier fea2576612 Add note re 'no problems to date' with VS2012 (VC11).
svn path=/trunk/; revision=47539
2013-02-07 21:59:27 +00:00
Jeff Morriss 5f101234d6 Use a variable for the package name we're querying.
Add SVN Id.

svn path=/trunk/; revision=47538
2013-02-07 20:58:45 +00:00
Jeff Morriss 8a6b4d596d QPropertyAnimation is needed for Qt builds and isn't present until Qt 4.6.0.
Add a (crude) check for the Qt version, making 4.6.0 the minimum.

The existing checks in configure.ac should be moved into into this new module.

svn path=/trunk/; revision=47537
2013-02-07 20:51:52 +00:00
Bill Meier 669e68dfde Add a hack to fix false positive 'unused ...' related to use of ..._add_oui().
svn path=/trunk/; revision=47536
2013-02-07 19:36:29 +00:00
Chris Maynard 8bb6b5fe05 Add proto_tree_set_visible. Also, sort.
(Ref: http://www.wireshark.org/lists/wireshark-dev/201302/msg00048.html)

Q. Should the addition of proto_tree_set_visible be backported to 1.8?

svn path=/trunk/; revision=47535
2013-02-07 19:12:10 +00:00
Jeff Morriss 74cd935845 There is no longer any need to link wireshark.desktop and wireshark.png into the rpm/SOURCES directory.
svn path=/trunk/; revision=47534
2013-02-07 17:37:38 +00:00
Bill Meier 408e6aa279 Minor tweaks ...
svn path=/trunk/; revision=47533
2013-02-07 17:24:32 +00:00
Bill Meier 64e97d9ec5 Fix a few minor bugs;
Do some small tweaks for readability & consistency.

svn path=/trunk/; revision=47532
2013-02-07 17:17:21 +00:00
Jeff Morriss 6484e0c9f7 Perl is required to build Wireshark, add it to BuildRequires.
svn path=/trunk/; revision=47531
2013-02-07 16:33:17 +00:00
Jeff Morriss 11507d00e0 Add MIME types for more capture file formats Wireshark understands:
- AIX iptrace
 - Novell LANalyzer
 - HP-UX nettl

The magic matching comes from Fedora's magic file, the file extensions from
wiretap.

(Yes, I just made the application/x-* MIME types up.)

svn path=/trunk/; revision=47530
2013-02-07 03:51:43 +00:00
Jeff Morriss 64b63e493c Add magic matching to PCAP, PCAPNG, and snoop files (based on Fedora's magic
file).  That way your files don't need to be named (e.g.) *.pcap for your file
manager to know that they should be opened with Wireshark.

Add *.ntar to the list of patterns for PCAPNG files.

svn path=/trunk/; revision=47529
2013-02-07 03:24:12 +00:00
Jeff Morriss f24dafa0f5 Overhaul to make this file more useful/up to date. Many changes are based on
Fedora's .spec file.  Changes include:
  - Create a separate wireshark-gnome package (like Redhat).
  - Control some things with variables set at the top of the file.
    - Allow the user to configure how dumpcap is installed.
    - Allow the user to choose some options including GTK2 or GTK3.
  - Greatly expand the BuildRequires entries; get the minimum versions of some
    things from 'configure'.
  - Install freedesktop files for better (free)desktop integration.

svn path=/trunk/; revision=47528
2013-02-07 03:09:47 +00:00
Gerald Combs c8c168c99a Remove more unnecessary defintions.
svn path=/trunk/; revision=47527
2013-02-06 21:57:16 +00:00
Gerald Combs 4f59c586d2 Remove some unnecessary definitions.
svn path=/trunk/; revision=47526
2013-02-06 21:55:58 +00:00
Gerald Combs 138b732b80 C++-ize filter_expressions.h.
svn path=/trunk/; revision=47525
2013-02-06 19:12:14 +00:00
Bill Meier fe8b2c63e3 Fix missing hf field array entries:
- In two cases, add missing entries to hf[];
 - Other cases: 'if 0' the packages referring to
    the missing entries.

See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842

ERROR: NO ARRAY: packet-h248_annex_e.c:
Fixed:
  hf_h248_pkg_ct
  hf_h248_pkg_nt

Packages 'if 0'd out:
  hf_h248_pkg_dd
  hf_h248_pkg_root


svn path=/trunk/; revision=47524
2013-02-06 19:04:24 +00:00
Gerald Combs 248310e3a7 Add filter expressions frame entries.
svn path=/trunk/; revision=47523
2013-02-06 19:03:23 +00:00
Gerald Combs 1c0deb0fc8 Add Filter Expressions^WButton^WShortcut^WBookmark preferences.
Add comments noting that

- We might want to do something different when the bookmark button is
  pressed.
- The display filters (dfilters file) and gui.filter_expressions
  preferences should be merged.
- Many buttons on Qt4 + OS X + unifiedTitleAndToolBarOnMac makes the
  main window really wide.

Add a qstring_strdup convenience routine. Add "disabled" display filter
edit icons. Fix up whitespace and descriptions in a couple of places.

svn path=/trunk/; revision=47522
2013-02-06 18:22:54 +00:00
Bill Meier ae527cbf10 Update a comment.
svn path=/trunk/; revision=47521
2013-02-06 15:01:40 +00:00
Evan Huus e32e0114e6 From Stefan Allers via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8282

Extended Negotiation support for the DICOM dissector.

svn path=/trunk/; revision=47520
2013-02-06 13:33:31 +00:00
Anders Broman 607162de38 From Pontus Fuchs:
If a monitor interface exists but is down the Wireless
toolbar fails to bring it up.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8251

svn path=/trunk/; revision=47519
2013-02-06 13:29:08 +00:00
Anders Broman 6bcbacf99a From Tyson Key:
Support for dissection of MiFare command payloads in PN532 InDataExchange packets.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8291

svn path=/trunk/; revision=47518
2013-02-06 13:23:54 +00:00
Anders Broman ba959015f6 From Guy Davies:
Update for RADIUS dictionary for Juniper Networks ERX

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8300

svn path=/trunk/; revision=47517
2013-02-06 13:18:25 +00:00
Guy Harris ec02b35a9c -Werror needs to be applied only to clean files, not to, for example,
Flex-generated files.  Comment it out for now.

svn path=/trunk/; revision=47516
2013-02-06 10:24:50 +00:00
Guy Harris de2db00f04 Add -Werror if enabled.
Sort EXTRA_DIST.

svn path=/trunk/; revision=47515
2013-02-06 09:52:09 +00:00