osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
28,408 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

28408 Commits

Author SHA1 Message Date
Guy Harris fc067ab910 Don't use DISSECTOR_ASSERT() to check a packet's content. Fixes bug 
3827.

svn path=/trunk/; revision=29339
 2009-08-09 01:23:09 +00:00
Gerald Combs 53a24d94f9 Check TLV lengths before we try to add them to the tree. Fixes bug 3824. 
svn path=/trunk/; revision=29338
 2009-08-08 22:20:08 +00:00
Kovarththanan Rajaratnam ca86991181 From Bahaa Naamneh via Bug 3538: 
This patch ensures that the filter autocompletion code handles protocols (radius and wimaxasncp) which uses delayed initialisation of protocols fields.

svn path=/trunk/; revision=29337
 2009-08-08 12:40:59 +00:00
Kovarththanan Rajaratnam ced157e4b7 Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658

svn path=/trunk/; revision=29336
 2009-08-08 09:57:07 +00:00
Kovarththanan Rajaratnam d36637e8f5 Pass on WinPcap/MSVC redistributable executables to the WiresharkPortable launcher and not the extractor. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3547.

svn path=/trunk/; revision=29335
 2009-08-08 09:22:58 +00:00
Jaap Keuter 4f501b3655 From Ivan Sy: 
Fixed IPv6 malformed packet when ip6_nxt (Next Header) is equal to "59". as per section 4.7 RFC 2460.

svn path=/trunk/; revision=29334
 2009-08-08 04:51:42 +00:00
Guy Harris 6b34dad7f2 Note that the new behavior matches what Wireshark does. 
svn path=/trunk/; revision=29333
 2009-08-08 01:23:15 +00:00
Guy Harris 643adf19e6 Move one comment before all of the code to which it refers. 
Update another comment with information from the corresponding comment
in tshark.c

Move some code so that it's run only if its result is used.

Add an additional comment about logging on UN*X.

svn path=/trunk/; revision=29332
 2009-08-08 01:21:55 +00:00
Gerald Combs 7cf4114654 If we have a format error, don't try adding something to the 
tree. Fixes bug 3822.

svn path=/trunk/; revision=29331
 2009-08-08 00:27:31 +00:00
Bill Meier d6925b130e fuzz-test: Fix/change WIRESHARK_ABORT_ON_DISSECTOR_BUG handling: 
1. If enabled: the variable must be exported to the env to take effect;
2. Upon reflection: disable this feature:
   tshark has been changed to output WARNING messages to stderr as a
    default; This means that DISSECTOR_BUGs and failed DISSECTOR_ASSERTs
     which cause WARNING log level messages will thus be output to stderr and 
     thus will be detected by the fuzz-test.

svn path=/trunk/; revision=29330
 2009-08-07 22:36:14 +00:00
Gerald Combs 7110e957f6 From Matt P via bug 3774: 
Patch utilizes techniques incorporated in the packet-ieee8023.c dissect_802_3()
routine to dynamically calculate the remaining payload length.  This is then
compared to the length included in the CCSDS header.

svn path=/trunk/; revision=29329
 2009-08-07 21:53:40 +00:00
Bill Meier 2a6163ec32 tshark: console_log_level preference now controls which log msgs are sent to stderr; 
Note: This is a behavior change: 
      Given the default value for the console_log_level preference
       tshark will now show ERROR, CRITICAL and WARNING level log messages.
      Prior to this change tshark was hardwired to show only
       ERROR and CRITICAL level messages.
      Time will tell whether this change results in too much noise
       in tshark output.

svn path=/trunk/; revision=29328
 2009-08-07 21:22:54 +00:00
Jörg Mayer b6cffe4050 - Add an AC macro to test linker flags. 
- Test whether the linker supports --as-needed and if so,
  adds it to LDFLAGS

svn path=/trunk/; revision=29327
 2009-08-07 18:49:24 +00:00
Jörg Mayer 952cbd7902 * Tue May 26 2009 cmorve69@yahoo.es 
- made it compile with --as-needed

This patch was taken from the opensuse wireshark.spec file.
No thanks go to the author and the package maintainers of
this package for not sending this upstream - it would have
made it into 1.2.0.

svn path=/trunk/; revision=29326
 2009-08-07 18:47:56 +00:00
Jörg Mayer d9531723b5 - Add rfc number comments on not-yet-decoded options 
- Decode autoconfigure option

svn path=/trunk/; revision=29325
 2009-08-07 18:45:06 +00:00
Kovarththanan Rajaratnam 8bc2261d24 Back out r29323. The non fully qualified path seems to work for everyone else so don't mess with it. 
svn path=/trunk/; revision=29324
 2009-08-07 14:01:44 +00:00
Kovarththanan Rajaratnam cdf7fda658 Use fully qualified path to bash 
svn path=/trunk/; revision=29323
 2009-08-07 13:18:02 +00:00
Kovarththanan Rajaratnam d2b61c0297 Free frame data slice on file reset 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3813

svn path=/trunk/; revision=29322
 2009-08-07 12:15:46 +00:00
Gerald Combs 367bcb7abd Clean up the last two DIRTY_DISSECTOR_SRC entries. 
svn path=/trunk/; revision=29321
 2009-08-07 00:15:35 +00:00
Bill Meier 3c1bc8f251 Fix some individual cases of 'if (unsigned) < 0' 
svn path=/trunk/; revision=29320
 2009-08-06 23:51:45 +00:00
Bill Meier 4acb789917 'if (curr_len <= 0)' won't work as desired when curr_len is declared as unsigned. 
The fix: change to 'if ((signed)curr_len <= 0)'.
This is a bit of a hack but I think it works.
See the comment in this file (packet-gsm_a_common.h).

svn path=/trunk/; revision=29319
 2009-08-06 23:47:21 +00:00
Guy Harris c3aaf166c6 Those items are 32 bits or longer, so the cast should be safe; add an 
additional cast in the hopes that they squelch "dereferencing
type-punned pointer" warnings.

svn path=/trunk/; revision=29318
 2009-08-06 23:26:24 +00:00
Michael Tüxen 8fcdcbd14f packet-sctp.c seems to be clean (at least it is on Mac OS X). 
svn path=/trunk/; revision=29317
 2009-08-06 22:26:05 +00:00
Stig Bjørlykke 0776b9c0a1 Added new_packet_list_set_font() and initialize fonts when using 
new packet list.

svn path=/trunk/; revision=29316
 2009-08-06 22:06:37 +00:00
Michael Tüxen 191709f6af Get it compiling when HAVE_LIBGCRYPT is not defined. 
svn path=/trunk/; revision=29315
 2009-08-06 21:55:10 +00:00
Bill Meier b38516fbd9 Fix some indentation and spacing 
svn path=/trunk/; revision=29314
 2009-08-06 21:42:40 +00:00
Gerald Combs 85f68c7461 Fix compilation warnings in a few dissectors and try moving them to the 
"clean" list.

svn path=/trunk/; revision=29313
 2009-08-06 20:55:04 +00:00
Bill Meier 21d8e2d3e1 Prevent possible (benign ?) array references with an array index of -1. 
svn path=/trunk/; revision=29312
 2009-08-06 18:44:38 +00:00
Bill Meier eba5297683 Remove inadvertantly committed comments re issue yet to be fixed ... 
svn path=/trunk/; revision=29311
 2009-08-06 16:13:31 +00:00
Bill Meier 413e64f1a6 Register ett[] subtree array only once. 
svn path=/trunk/; revision=29310
 2009-08-06 16:10:29 +00:00
Bill Meier 7f7161f819 Register ett[] subtree array only once. 
svn path=/trunk/; revision=29309
 2009-08-06 16:06:11 +00:00
Gerald Combs 595f9b6630 Convert a GString to an ep_strbuf_t (and squelch a static analysis 
warning in the process). Remove an unused variable.

svn path=/trunk/; revision=29308
 2009-08-05 19:03:48 +00:00
Jaap Keuter b5aa261da6 From Gerasimos Dimitriadis: 
Fixes/enhances the decoding of the Mobile Identity IE for type of identity
"TMGI and optional MBMS Session Identity".

svn path=/trunk/; revision=29307
 2009-08-05 18:42:45 +00:00
Jaap Keuter 8787b8ecc8 Fix for bug 3811: 
Add missing shorthand application/vnd.ms-sync besides application/vnd.ms-sync.wbxml.

svn path=/trunk/; revision=29306
 2009-08-05 18:21:52 +00:00
Jaap Keuter 5c57e015d4 From Ivan Sy: 
Add support for Support for DHCID RR (RFC 4701).

svn path=/trunk/; revision=29305
 2009-08-05 18:17:18 +00:00
Gerald Combs 65be9b68bd Squelch a couple of Clang Static Analyzer warnings. 
svn path=/trunk/; revision=29304
 2009-08-05 15:39:29 +00:00
Martin Mathieson 92b2bcf28a Show power headroom report inside its own subtree. 
svn path=/trunk/; revision=29303
 2009-08-05 08:02:12 +00:00
Jaap Keuter 203269175e Fix for bug 3806: 
Add presentation of Block Ack Bitmap.

svn path=/trunk/; revision=29302
 2009-08-05 07:33:44 +00:00
Gerald Combs 931a750908 Add a couple of pointer checks. 
svn path=/trunk/; revision=29301
 2009-08-05 00:36:27 +00:00
Guy Harris 3d1e81ff3d Fix typo. 
svn path=/trunk/; revision=29300
 2009-08-05 00:13:38 +00:00
Guy Harris 6847b0b94d Put the initializers for the elements of value_string arrays into curly 
brackets, so the API checks for non-terminated value_string arrays will
not falsely think the arrays are non-terminated.

svn path=/trunk/; revision=29299
 2009-08-04 23:14:40 +00:00
Jaap Keuter c9e3f66d14 Optimize empty strings to NULL pointers. 
svn path=/trunk/; revision=29298
 2009-08-04 21:05:38 +00:00
Bill Meier d0f569953d Fix benign double subtree registration of an ett_... variable. 
svn path=/trunk/; revision=29297
 2009-08-04 19:29:42 +00:00
Bill Meier 8589c2f11b Minor changes: 
- Move proto_register...() to the end of the file as per convention;
- Move ett[] to be local to proto_register...();
- "if (...==-1)" not req'd in proto_register...();
- #include <moduleinfo.h> not req'd;
- Remove unneeded forward declarations.

svn path=/trunk/; revision=29296
 2009-08-04 19:01:34 +00:00
Bill Meier cb7dac7100 Initialize several ett_... variables to -1 
svn path=/trunk/; revision=29295
 2009-08-04 18:52:01 +00:00
Bill Meier 90e865cc54 Init ett_... variables to -1 
svn path=/trunk/; revision=29294
 2009-08-04 18:48:45 +00:00
Bill Meier 8ffaa3b880 Remove duplicate entry from ett[] 
svn path=/trunk/; revision=29293
 2009-08-04 18:46:51 +00:00
Guy Harris b6660d06bf Clean up white space a bit - use 2-space indenting. 
Put a bunch of code that does nothing unless data_val is non-null inside
"if (data_val)", and get rid of the individual tests.

svn path=/trunk/; revision=29292
 2009-08-04 18:39:43 +00:00
Gerald Combs 49c58bc1a4 Miscellaneous cleanups. 
svn path=/trunk/; revision=29291
 2009-08-04 17:59:48 +00:00
Martin Mathieson fef272347b Show number of predefined bytes in info column. 
svn path=/trunk/; revision=29290
 2009-08-04 10:41:08 +00:00