Commit Graph

13206 Commits

Author SHA1 Message Date
Ulf Lamping dd71ad695f (some) redesign of capture data structures.
don't use global cfile at all but only an untpyed handle to call the cf_... functions in file.c
move the save_file member from capture_file to capture_opts, as it's only used while capturing and while preparing it

svn path=/trunk/; revision=13276
2005-02-04 01:29:29 +00:00
Jörg Mayer 02f8788b4e Albert Chin:
>From autoconf.info:
     In order to support these features, it is essential that `datadir'
  remains being defined as `${prefix}/share' to depend upon the current
  value of `prefix'.

     A corollary is that you should not use these variables except in
  Makefiles.  For instance, instead of trying to evaluate `datadir' in
  `configure' and hard-coding it in Makefiles using e.g.,
  `AC_DEFINE_UNQUOTED(DATADIR, "$datadir")', you should add
  `-DDATADIR="$(datadir)"' to your `CPPFLAGS'.


svn path=/trunk/; revision=13275
2005-02-04 00:29:37 +00:00
Jörg Mayer d01c1ddaef albert chin:
The HP-UX compilers don't like non-constant initializers (C99'ism).
        Patch attached for plugins/mate/mate_setup.c.

Fix a few warnings (change some () to (void))

svn path=/trunk/; revision=13274
2005-02-04 00:22:00 +00:00
Jörg Mayer cf16ab5a13 Yaniv Kaul
Attached patch simplifies a very complex 'if' statement in packet-fw1.c
        and generally streamlines the code.


svn path=/trunk/; revision=13273
2005-02-03 23:42:06 +00:00
Jörg Mayer 94a6f0cc48 Yaniv Kaul:
Attached please find a small performance optimization to packet-ip.c,
        which removes multiple redundant calls to tvb_get_ptr().

Changed srt_addr and dst_addr from char to guchar

svn path=/trunk/; revision=13272
2005-02-03 23:35:57 +00:00
Jörg Mayer 9c638f9e7e Motonori Shindo:
Please find attached a small patch for CoSine L2 debug dissector. The
code used to incorrectly select the first 4 octets in the tvbuff. This
patch fixes this problem.

svn path=/trunk/; revision=13271
2005-02-03 23:24:08 +00:00
Jörg Mayer c49b92ea30 Yniv Kaul: Small performance optimization
It change a while()->do, to do->while() and removes a variable (and an
  assignment to it).

svn path=/trunk/; revision=13270
2005-02-03 23:18:23 +00:00
Jörg Mayer 326165db2b ncisco Alcoba:
Do not add target address if the packet is a Request. According to the RFC,
        target addresses in requests have no meaning


svn path=/trunk/; revision=13269
2005-02-03 22:52:20 +00:00
Ulf Lamping 9ff19a4c94 move capture_file_fd field from capture_file to capture_opts type, as this is the place where it should be
svn path=/trunk/; revision=13268
2005-02-03 22:48:20 +00:00
Jörg Mayer fc9a0f0744 Mark C. Brown: Added support for new ixgbe card
svn path=/trunk/; revision=13267
2005-02-03 22:44:13 +00:00
Ulf Lamping be0e6a0631 prevent ringbuffer from having to know about capture_file type at all (decoupling dependencies)
svn path=/trunk/; revision=13266
2005-02-03 21:58:33 +00:00
Anders Broman 915e63ae18 Add dissection of some more packages.
svn path=/trunk/; revision=13265
2005-02-03 21:57:42 +00:00
Anders Broman 2b80bfc282 Add dissection of some more packages.
svn path=/trunk/; revision=13264
2005-02-03 21:56:59 +00:00
Anders Broman 72468bb0e5 From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message, 
in the first one the calling and called numbers, and in the second the SPs 
and CIC; in releases it shows the cause value.

svn path=/trunk/; revision=13263
2005-02-03 21:51:35 +00:00
Anders Broman 4d97ad9eb1 From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message, 
in the first one the calling and called numbers, and in the second the SPs 
and CIC; in releases it shows the cause value.

svn path=/trunk/; revision=13262
2005-02-03 21:50:19 +00:00
Anders Broman 3ff1f03636 Various updates to GSM MAP
svn path=/trunk/; revision=13261
2005-02-03 21:22:09 +00:00
Jörg Mayer 103ced271d Jon Ringle: bug fix to the stun ERROR-CODE dissecting
svn path=/trunk/; revision=13260
2005-02-03 21:11:46 +00:00
Ulf Lamping 7eff647262 add tooltips to the dialogs radio buttons
svn path=/trunk/; revision=13259
2005-02-03 20:44:19 +00:00
Guy Harris 9707eedda5 From Dominique Bastien: add the slow protocol MAC address to the list of
well-known MAC addresses.

svn path=/trunk/; revision=13258
2005-02-03 20:14:11 +00:00
Lars Roland 627918aecb Small fix for h225 dissector as suggested by Tomas Kukosa
svn path=/trunk/; revision=13257
2005-02-03 16:22:08 +00:00
Gilbert Ramirez 7e9f4b7eb7 From Pekka Pietikainen <pp@ee.oulu.fi>, add a byte to the hex[]
array so that there is room for the terminating NUL from sprintf().

svn path=/trunk/; revision=13256
2005-02-03 15:03:29 +00:00
Anders Broman acb8eef002 Add an OID
svn path=/trunk/; revision=13255
2005-02-03 06:54:55 +00:00
Ulf Lamping 7f3a6f361e Enable GTK-Wimp only for Windows 2000/XP/2003
...as Win9x/ME/NT known to have problems with it!

svn path=/trunk/; revision=13254
2005-02-03 02:35:20 +00:00
Ulf Lamping bac4df8970 Copied this file from:
http://nsis.sourceforge.net/archive/nsisweb.php?page=15&instances=0,11

Licensing question, as the NSIS homepage states:
http://nsis.sourceforge.net/features/license/
so it should be ok to rerelease this file under the GPL

svn path=/trunk/; revision=13253
2005-02-03 02:32:48 +00:00
Guy Harris e86a1c6a47 Give a URL for the ERF specification.
svn path=/trunk/; revision=13252
2005-02-03 02:26:20 +00:00
Guy Harris 4e4b6309fa Fix a comment.
svn path=/trunk/; revision=13251
2005-02-03 01:24:07 +00:00
Guy Harris 191465dc43 Check in the missing part of Jon Ringle's patch (the part that actually
changed the conversation code).

svn path=/trunk/; revision=13250
2005-02-03 01:08:39 +00:00
Guy Harris d7006ef10c Undo de-UTF-8ification and other damage.
svn path=/trunk/; revision=13249
2005-02-03 01:07:21 +00:00
Ulf Lamping d8d1e6a62b added %ETHEREAL%\disabled_protos
svn path=/trunk/; revision=13248
2005-02-02 22:18:37 +00:00
Ulf Lamping 69f2ac18a9 bugfix: the EOT flag detection in a COTP data TPDU was using little endian, although it's big endian in the packet.
some other minor output enhancements

svn path=/trunk/; revision=13247
2005-02-02 21:13:52 +00:00
Anders Broman cdfac64b99 Add Jon Ringle, at the moment I don't have the e-mail address.
svn path=/trunk/; revision=13246
2005-02-02 20:15:29 +00:00
Anders Broman d86f7e48c4 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13245
2005-02-02 20:09:00 +00:00
Anders Broman 8f749c91cc From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13244
2005-02-02 20:08:36 +00:00
Anders Broman 851ecd2ac4 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13243
2005-02-02 20:07:03 +00:00
Anders Broman 93ea4470f0 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13242
2005-02-02 20:02:46 +00:00
Michael Tüxen 03b78c062f Add mtp3.pc as suggested by Luis Ontanon.
Cleanups

svn path=/trunk/; revision=13241
2005-02-02 13:37:04 +00:00
Guy Harris 93426174ef Writing the raw data of a TCP stream to a file isn't printing it, so
don't use the print mechanism for that - do the writing directly in the
"follow stream" code.

Use "size_t" for character counts.

Make the "hexchars" array static and const, as it's not written to, and
there's probably no point in copying it to the stack (unless that
improves cache locality).

There's no need to explain why we're subtracting the number of bytes
actually read, rather than the number of bytes asked for, from the data
length.

Note an issue with printing lines.

svn path=/trunk/; revision=13240
2005-02-02 10:28:51 +00:00
Guy Harris 26c2759ebc Get rid of an unused typedef.
svn path=/trunk/; revision=13239
2005-02-02 10:19:35 +00:00
Guy Harris 291e154e03 Use C89 syntax, not C++ syntax, for functions that take no arguments.
svn path=/trunk/; revision=13238
2005-02-02 09:08:42 +00:00
Guy Harris 0c5d6e35ee Don't assume that the only blank filter expression is empty - check for
an all-space-character string.

Don't use "filter_string" both for the (unfreeable, unmodifiable) value
fetched from the text entry and the new filter expression; use it only
for the former, and make it a "const" pointer to avoid compiler
warnings.

Use a GString to construct the stuff to be added to the new filter
expression - the old code, when appending stuff to the filter expression
in a loop, would leak the pre-append value.

svn path=/trunk/; revision=13237
2005-02-02 08:53:08 +00:00
Ronnie Sahlberg b4d53ed380 from chris eagle
add radiobutton to allow saving raw tcpstreams


these radiobuttons should, by someone that uses, this feature be changed into
a menu instead.



svn path=/trunk/; revision=13236
2005-02-02 08:50:40 +00:00
Guy Harris 20730353e2 Make sure "comment" is set.
Get rid of an unused variable.

svn path=/trunk/; revision=13235
2005-02-02 08:08:53 +00:00
Guy Harris de76a7c615 Clean up white space.
Get rid of an unused variable and two #includes that aren't needed.

svn path=/trunk/; revision=13234
2005-02-02 08:02:46 +00:00
Guy Harris d393884422 "filter_string_fwd" is assigned a "const" pointer, so make it a "const"
pointer.

svn path=/trunk/; revision=13233
2005-02-02 08:01:27 +00:00
Lars Roland 70eb306bb2 for VoIP Call Analysis:
- make VoIP Call Analysis work if, called from command line
- should also work now while capturing with packet list
  updated in "real time" (to be tested)
- give each tap listener a unique identifier, so ethereal
  won't mix them up
- various cleanups
- compile by default

Todo:
- add support for "tap display filter"
- reimplement function to add rtp streams to the call flow.
 

svn path=/trunk/; revision=13232
2005-02-02 01:02:09 +00:00
Ulf Lamping 91aeca75dd by more specific about unix configuration files
svn path=/trunk/; revision=13231
2005-02-01 23:49:02 +00:00
Ronnie Sahlberg ecdd9999b1 the old netlogon protocol is now called smb_netlogon
svn path=/trunk/; revision=13230
2005-02-01 23:33:04 +00:00
Ronnie Sahlberg 9d2157c031 g_strlcpy does not exist in gtk 1.2
use strncpy instead


svn path=/trunk/; revision=13229
2005-02-01 23:30:18 +00:00
Anders Broman 6e4f24c0d9 Improve handling of pinfo->private_data
svn path=/trunk/; revision=13228
2005-02-01 22:57:22 +00:00
Jörg Mayer 64e12f7518 Add boolean to the list of non-portable types
svn path=/trunk/; revision=13227
2005-02-01 15:45:03 +00:00