Commit Graph

32 Commits

Author SHA1 Message Date
Guy Harris b93c394c98 From Anders Broman:
change some variable names to conform to abbreviations used in
	the specs;

	added+dissection of some more BAT ASE elements;

	fixed some minor bugs.

svn path=/trunk/; revision=8641
2003-10-07 17:43:52 +00:00
Guy Harris af5b47a0c2 When registering a field, make sure its ID is -1 or 0 - if it's not,
that probably means you've registered two fields with the same field ID
variable, which is an error.

Fix the bugs doing so found.

svn path=/trunk/; revision=8629
2003-10-06 20:46:52 +00:00
Guy Harris e53d7ed5ed From packet steve: get rid of some duplicate field definitions (some
aren't exactly duplicates, but they both set the same hf_ variable).

svn path=/trunk/; revision=8621
2003-10-06 08:35:30 +00:00
Guy Harris 2d25da5376 From Anders Broman:
fix some cut and paste errors in "upgraded parameter" routine;

	more BICC work.

svn path=/trunk/; revision=8601
2003-10-03 20:58:13 +00:00
Guy Harris 5dee9ea070 Clean up a bunch of length processing - use the reported length rather
than the captured length, and fix up some other stuff.

svn path=/trunk/; revision=8572
2003-09-29 21:50:03 +00:00
Guy Harris a22075b380 From Michael Lum: fix some val_to_str calls to have a non-null format
string for unknown values.

svn path=/trunk/; revision=8571
2003-09-29 21:12:15 +00:00
Guy Harris fb1dff45b5 From Anders Broman: further dissect APM messages containing BICC stuff,
and fix a bug in the "upgraded parameter code".

svn path=/trunk/; revision=8557
2003-09-27 23:51:09 +00:00
Guy Harris 930e137aff From Anders Broman: add support for BICC dissection.
Change his e-mail address.

svn path=/trunk/; revision=8454
2003-09-11 00:08:14 +00:00
Guy Harris 6189e0e871 From Anders Broman: don't use a bitmask for the CIC filter, the value
has already had the bits extracted.

svn path=/trunk/; revision=7938
2003-06-26 08:39:46 +00:00
Guy Harris c34733fff3 From Anders Broman: dissect the "parameter compatibility" parameter.
svn path=/trunk/; revision=7925
2003-06-25 04:27:51 +00:00
Michael Tüxen 27fb63a9fb - get rid of col_set_fence: it will be called in packet-sctp.c only.
- replace DATA1 by DATA in packet-m3ua.c (typo)

svn path=/trunk/; revision=7529
2003-04-22 13:47:38 +00:00
Michael Tüxen d8b05d1729 - add better INFO column handling using col_set_fence.
- change my e-mail.

svn path=/trunk/; revision=7502
2003-04-19 20:13:23 +00:00
Guy Harris a551f4a0ab From Anders Broman: dissect user-to-user IEs in ISUP messages as Q.931
UU IE's.

svn path=/trunk/; revision=7456
2003-04-14 18:04:13 +00:00
Guy Harris 30859b1802 From Jeff Morriss: rather than re-initializing the Info column with each
PDU, just append the message type acronym to the column, so you can see
the message types for all the messages in the frame.

svn path=/trunk/; revision=7439
2003-04-11 20:19:45 +00:00
Guy Harris 237fd12777 From Anders Broman: decode ISUP element User service info as Q.931
Bearer capability.

svn path=/trunk/; revision=7437
2003-04-10 18:40:38 +00:00
Guy Harris ce39f410b8 From Anders Broman: put the message type in the Info column regardless
of whether a protocol tree is being built or not.

svn path=/trunk/; revision=7347
2003-03-12 00:27:00 +00:00
Guy Harris 16db97a28c "packet-isup.c" doesn't appear to need to include "packet-ip.h", so
don't do so.

Pick up Anders Broman's table of Q.850 cause values, and his change to
use "dissect_q931_cause_ie()" for cause indicators - but do it by
modifying the Q.931 dissector's "dissect_q931_cause_ie()" to take, as an
argument, the header field to use for the cause value, and export that
routine and have the ISUP dissector call it, rather than by duplicating
the cause IE dissector.

svn path=/trunk/; revision=7225
2003-02-28 23:16:15 +00:00
Jörg Mayer 7c4176d868 Removed trailing whitespaces from .h and .c files using the
winapi_cleanup tool written by Patrik Stridvall for the wine
project.

svn path=/trunk/; revision=6117
2002-08-28 21:04:11 +00:00
Jörg Mayer 173fe5aef4 Replace the types from sys/types.h and netinet/in.h by their glib.h
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.

svn path=/trunk/; revision=5932
2002-08-02 23:36:07 +00:00
Guy Harris 77fa06b899 From Joerg Mayer:
dftest.c:
	     Remove #if-0-ed includes

	packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
        packet-wtp.c, ethereal_gen.py:
	     Remove redundant include varargs (already in snprintf.h,
	     and required only for snprintf.h)

	Remove unused include of snprintf.h from files not using
	"snprintf()".

svn path=/trunk/; revision=5889
2002-07-17 00:43:03 +00:00
Guy Harris 2e44d10e3e Make all routines not used outside this module static.
Get rid of some unused arguments.

Pass the tree argument, not the item argument, to "proto_tree_add"
routines.

svn path=/trunk/; revision=5356
2002-05-02 09:52:20 +00:00
Gilbert Ramirez bd4a9c13eb Provide tvb_ensure_length_remaining(), which is like
tvb_length_remaining() except that it throws BoundsError if 'offset'
is out-of-bounds.

Allow a length argument of -1 for FT_STRING and FT_BYTES fields
in proto_tree_add_item().

Change some dissectors to either use -1 for the length argument in
calls to proto_tree_add_item(), or call tvb_ensure_length_remaining()
instead of tvb_length_remaining(), or to check the return-value
of tvb_length_remaining(). Changes to more dissectors are necessary,
but will follow later.

svn path=/trunk/; revision=4656
2002-02-01 04:34:17 +00:00
Guy Harris a927aed2fb From Michael T�xen: updates to work with the new M3UA dissector.
svn path=/trunk/; revision=4643
2002-01-31 00:49:59 +00:00
Guy Harris eb2d6593dc Replace a bunch of "tvb_length()" and "tvb_length_remaining()" calls in
arguments to "proto_tree_add_text()", and to "proto_tree_add_XXX()" calls
that add FT_NONE or FT_PROTO items to the protocol tree, with -1.

Replace some calls to "tvb_length()" or "tvb_length_remaining()" with
calls to "tvb_reported_length()" and "tvb_reported_length_remaining()",
as those give the actual length of the data in the packet, not just the
data that happened to be captured.

svn path=/trunk/; revision=4605
2002-01-24 09:20:54 +00:00
Guy Harris ee5ca25d31 Include files from the "epan" directory and subdirectories thereof with
"epan/..." pathnames, so as to avoid collisions with header files in any
of the directories in which we look (e.g., "proto.h", as some other
package has its own "proto.h" file which it installs in the top-level
include directory).

Don't add "-I" flags to search "epan", as that's no longer necessary
(and we want includes of "epan" headers to fail if the "epan/" is left
out, so that we don't re-introduce includes lacking "epan/").

svn path=/trunk/; revision=4586
2002-01-21 07:37:49 +00:00
Guy Harris 23319ff023 Move the pointer to the "column_info" structure in the "frame_data"
structure to the "packet_info" structure; only stuff that's permanently
stored with each frame should be in the "frame_data" structure, and the
"column_info" structure is not guaranteed to hold the column values for
that frame at all times - it was only in the "frame_data" structure so
that it could be passed to dissectors, and, as all dissectors are now
passed a pointer to a "packet_info" structure, it could just as well be
put in the "packet_info" structure.

That saves memory, by shrinking the "frame_data" structure (there's one
of those per frame), and also lets us clean up the code a bit.

svn path=/trunk/; revision=4370
2001-12-10 00:26:21 +00:00
Guy Harris bced8711f6 Make "dissector_add()", "dissector_delete()", and "dissector_change()"
take a dissector handle as an argument, rather than a pointer to a
dissector function and a protocol ID.  Associate dissector handles with
dissector table entries.

svn path=/trunk/; revision=4308
2001-12-03 04:00:26 +00:00
Guy Harris aa4cd01b9b Get rid of "proto_tree_add_notext()" - if you create a subtree using it,
but, before you set the text, you throw an exception while putting stuff
under the subtree, you end up with an absolutely blank protocol tree
item, which is really gross.  Instead of calling
"proto_tree_add_notext()", call "proto_tree_add_text()" with at least a
minimal label - yes, it does mean you do some work that will probably be
unnecessary, but, absent a scheme to arrange to do that work if it *is*
necessary (e.g., catching exceptions), the alternative is an ugly
protocol tree display.

svn path=/trunk/; revision=3879
2001-08-28 08:28:19 +00:00
Guy Harris 8412393197 From Joerg Mayer: explicitly fill in all members of a
"header_field_info" structure, including the ones that are later set by
the routines to register fields.

svn path=/trunk/; revision=3561
2001-06-18 02:18:27 +00:00
Guy Harris 40abc4f2b0 MSVC++ doesn't define "uint"; use "guint" instead.
svn path=/trunk/; revision=3481
2001-05-30 08:49:23 +00:00
Guy Harris a559a89406 Fix Gerald's e-mail address.
svn path=/trunk/; revision=3451
2001-05-25 16:19:31 +00:00
Guy Harris c7595d9a42 ISUP support, from Martina Obermeier.
svn path=/trunk/; revision=3450
2001-05-25 16:17:45 +00:00