Pascal Quantin
5db2d622e4
From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9554 :
...
GSM SMS: remove some globals and expose some UDH fields through dis_field_udh()
svn path=/trunk/; revision=53997
2013-12-12 22:35:45 +00:00
Guy Harris
8d67e7b20c
The dissector table has never been used, and the name of the dissector
...
table doesn't correspond to any obvious field, so I'm not sure why it
needs to exist. Remove it.
svn path=/trunk/; revision=53996
2013-12-12 22:22:09 +00:00
Chris Maynard
76eebd5561
Appease Visual Studio Code Analysis by ensuring that the string in csec[] is NULL-terminated.
...
svn path=/trunk/; revision=53995
2013-12-12 22:02:46 +00:00
Guy Harris
3e8ea51499
Get rid of a dissector table that has never been used.
...
Get rid of a field that was hidden, always set to 0, and not obviously
used anywhere.
svn path=/trunk/; revision=53994
2013-12-12 21:45:35 +00:00
Bill Meier
b3922f9f72
Create/use two extended value-strings;
...
Reformat some hf[] entries;
Reformat a long line;
tabs --> spaces 9to match editor-modelines);
Rework/Add whitespace.
svn path=/trunk/; revision=53993
2013-12-12 21:42:10 +00:00
Jakub Zawadzki
f049bec3ca
DHCPv6: update list of message types and options (from IANA)
...
svn path=/trunk/; revision=53992
2013-12-12 21:29:51 +00:00
Bill Meier
24c15c9eea
Reformat some hf[] entries;
...
Reformat some long lines;
tabs --> spaces (to match editor modelines);
Rework/add whitespace;
svn path=/trunk/; revision=53991
2013-12-12 21:15:03 +00:00
Bill Meier
09d84f308d
Create/use an extended value-string;
...
Localize some vars;
Remove some unneeded initializers;
Reformat some hf[] entries;
Reformat a long commenty for readability;
Break up some long lines;
Use consistent indentation;
Rework/add whitespace;
Fix inconsistent editor modelines.
svn path=/trunk/; revision=53990
2013-12-12 21:11:30 +00:00
Guy Harris
859cd68acc
In r12060, use of the "aim.family" subdissector table was eliminated, in
...
favor of the AIM dissector having its own private way of handing off to
subdissectors. Get rid of the subdissector table.
svn path=/trunk/; revision=53989
2013-12-12 21:06:55 +00:00
Bill Meier
b54c6ea57f
Reformat hf[] entries;
...
tabs --> spaces to match editor modelines;
Rework/add whitespace.
svn path=/trunk/; revision=53988
2013-12-12 21:02:25 +00:00
Bill Meier
d63a5cfb0e
Remove 'if (tree)' around (indirect) calls to expert functions;
...
Reformat hf[] entries;
'offset++' --> 'offset += 1' for consistency;
tabs --> spaces to match editor modelines;
Rework/add whitespace.
svn path=/trunk/; revision=53987
2013-12-12 20:56:31 +00:00
Bill Meier
62a62aafc4
Remove two text arrays (flagged with _U_);
...
Remove unneeded initializers;
Change tabs --> spaces (to match edirtor modelines);
Rework/add some whitespace.
svn path=/trunk/; revision=53986
2013-12-12 20:51:40 +00:00
Bill Meier
01fd11ab41
(Trivial):
...
tabs --> spaces (to match editor modelines);
'offset++' --> 'offset += 1' for consistency;
Break up a long text constant;
Reformat some lines for readability.
svn path=/trunk/; revision=53985
2013-12-12 20:44:08 +00:00
Chris Maynard
06282f3eee
Fix Visual Studio Code Analysis warning C6385: Invalid data: accessing 'tag_to_type', the readable size is '136' bytes, but '540' bytes might be read
...
svn path=/trunk/; revision=53984
2013-12-12 20:40:12 +00:00
Bill Meier
5a2dd0e9ac
Use a consistent indentation: 4 spaces;
...
Use #if 0/#endif instead of '/* */' to comment out some code;
svn path=/trunk/; revision=53983
2013-12-12 20:39:11 +00:00
Bill Meier
226e9caf9c
(Trivial)
...
- Remove two lines of commented out code;
- Specify 'tab-width: 8' (not 4) in editor modelines;
- Rework/add whitespace;
svn path=/trunk/; revision=53982
2013-12-12 20:35:58 +00:00
Chris Maynard
b03a63f371
Fix Visual Studio Code Analysis warning C6287: Redundant code: the left and right sub-expressions are identical
...
svn path=/trunk/; revision=53981
2013-12-12 20:33:30 +00:00
Bill Meier
e566611e27
(Trivial);
...
- localize some vars;
- Specify 'tab-width: 8' (not 4) in editor modelines;
- tabs --> spaces;
svn path=/trunk/; revision=53980
2013-12-12 20:33:17 +00:00
Bill Meier
394b50d967
(Trivial)
...
tabs --> spaces to match editor modelines;
Specify 'tab-width: 8' (not 4) in editor modelines;
svn path=/trunk/; revision=53979
2013-12-12 20:25:53 +00:00
Bill Meier
ebaeed5a1f
(Trivial)
...
- Fix indentation to match editor modelines (tabs-->spaces);
- Rework/add some whitespace;
svn path=/trunk/; revision=53978
2013-12-12 20:16:30 +00:00
Martin Kaiser
e14b04c20f
remove unused dissector tables
...
http://www.wireshark.org/lists/wireshark-dev/201312/msg00137.html
svn path=/trunk/; revision=53977
2013-12-12 20:15:06 +00:00
Martin Kaiser
03e8f5b0c0
correct the function names in order to fix compile errors
...
svn path=/trunk/; revision=53976
2013-12-12 20:09:40 +00:00
Chris Maynard
bc1b084ae1
Trivial: Spaces -> tabs.
...
svn path=/trunk/; revision=53975
2013-12-12 20:09:33 +00:00
Bill Meier
bacfeda9e9
Move proto_reg_handoff...() to the file end as per convevntion;
...
Reformat certain lines to use a consistent style;
tabs --> spaces (to match the editor modelines);
Rework some whitespace;
svn path=/trunk/; revision=53974
2013-12-12 19:59:23 +00:00
Chris Maynard
0b2dc7041f
Fix Coverity CID 1135557: Structurally dead code, by moving the break statement to the most sensible place.
...
svn path=/trunk/; revision=53973
2013-12-12 19:56:35 +00:00
Anders Broman
54a8c3165d
Try to fix "initializer element is not computable at load time"
...
svn path=/trunk/; revision=53972
2013-12-12 19:54:15 +00:00
Anders Broman
4058146e26
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53971
2013-12-12 19:52:14 +00:00
Bill Meier
13cc753fd4
Move proto_reg_handoff...() to file end as per convention;
...
Reformat various hf[] entries;
#include params.h (not prefs.h);
'offset++' --> 'offset += 1' for consistency;
Localize some variable defintions;
Tabs --> spaces (to match editor modelines);
Rework some whitespace;
svn path=/trunk/; revision=53970
2013-12-12 19:48:46 +00:00
Chris Maynard
69dbd3fb24
Reject the packet if info is NULL under conditions where it'll be used.
...
svn path=/trunk/; revision=53969
2013-12-12 19:38:20 +00:00
Bill Meier
1de89438f2
Create/use a number of extended value-strings;
...
Remove or comment out dups from several value-string arrays;
Sort a number of value-string arrays;
Reformat many hf[] entries;
Remove some unneeded initializers;
Add editor-modelines;
Use consistent indentation;
Reformat whitespace.
svn path=/trunk/; revision=53968
2013-12-12 19:26:55 +00:00
Chris Maynard
c96d5a97ad
Trivial: Tab -> spaces.
...
svn path=/trunk/; revision=53967
2013-12-12 19:20:30 +00:00
Chris Maynard
c21370b0f4
Reject the packet if data is NULL under conditions where it'll be used.
...
svn path=/trunk/; revision=53966
2013-12-12 19:10:24 +00:00
Chris Maynard
4b609d4c92
Reject the packet if data is NULL. For now, leave the DISSECTOR_ASSERT's since both get_rose_ctx() and get_asn1_ctx() also check signatures.
...
svn path=/trunk/; revision=53965
2013-12-12 19:04:38 +00:00
Chris Maynard
a97a3152b0
Reject the packet if data is NULL. Remove _U_ where data is actually used. For now, leave the DISSECTOR_ASSERT's since both get_rose_ctx() and get_asn1_ctx() also check signatures.
...
(Arguably it's the responsibility of the dissector passing this information to set the signature correctly so if there's an invalid signature, the bug is with the calling dissector and not with the one receiving the invalid signature.)
svn path=/trunk/; revision=53964
2013-12-12 18:10:08 +00:00
Anders Broman
74b58162d7
- Forward declaration of register functions.
...
svn path=/trunk/; revision=53963
2013-12-12 17:45:22 +00:00
Anders Broman
138ce6f204
Try to fix "initializer element is not computable at load time"
...
svn path=/trunk/; revision=53962
2013-12-12 17:32:22 +00:00
Martin Mathieson
aad04d5963
Remove some TODOs that have now been addressed
...
svn path=/trunk/; revision=53961
2013-12-12 13:25:12 +00:00
Martin Mathieson
25cc056590
Missing from last commit - copy hfn into stored result for PDU
...
svn path=/trunk/; revision=53960
2013-12-12 13:23:28 +00:00
Martin Mathieson
9a6d3cf358
Show other security inputs (apart from keys)
...
svn path=/trunk/; revision=53959
2013-12-12 11:07:53 +00:00
Anders Broman
b781d6c99d
- Make local functions static.
...
- Forward declaration of register functions.
svn path=/trunk/; revision=53958
2013-12-12 06:11:05 +00:00
Gerald Combs
018157cbb6
Fix the path to dumpcap.
...
svn path=/trunk/; revision=53957
2013-12-12 02:41:08 +00:00
Gerald Combs
12ef64b1aa
Remove the checks for ../../lib. If it still exists it likely means that
...
there's a stale LIBRARY_OUTPUT_PATH in CMakeCache.txt.
svn path=/trunk/; revision=53956
2013-12-12 01:46:09 +00:00
Gerald Combs
8470f36423
Update library searches to reflect r53780.
...
svn path=/trunk/; revision=53955
2013-12-12 01:36:44 +00:00
Chris Maynard
a2459dc786
Reject the packet if data is NULL.
...
svn path=/trunk/; revision=53954
2013-12-11 23:04:09 +00:00
Chris Maynard
8cacdfa8ce
Reject the packet if data is NULL. Leave the DISSECTOR_ASSERT(actx != NULL) since get_asn1_ctx() also checks the signature.
...
svn path=/trunk/; revision=53953
2013-12-11 23:03:01 +00:00
Gerald Combs
a81424382e
Be more consistent with the name "Wireshark" and its two UI
...
flavors. Upgrade the Qt flavor from "experimental" to "alpha". I also
apologize in advance to all of the people who installed previous versions
of the 1.11.x packages and who will now have extra shortcuts lying around.
svn path=/trunk/; revision=53952
2013-12-11 22:29:05 +00:00
Jörg Mayer
6e79e1f534
Fix
...
svn/trunk/epan/dissectors/packet-netlink-netfilter.c:164:11: error: variable ‘is_req’ set but not used [-Werror=unused-but-set-variable]
gboolean is_req;
^
cc1: all warnings being treated as errors
svn path=/trunk/; revision=53951
2013-12-11 21:51:30 +00:00
Jakub Zawadzki
57e66ad446
Fix buildbot:
...
packet-netlink-netfilter.c:94: warning: 'dissect_netlink_netfilter_queue' defined but not used
svn path=/trunk/; revision=53950
2013-12-11 21:30:23 +00:00
Chris Maynard
d5f1c9e7d4
Trivial: tabs -> spaces.
...
svn path=/trunk/; revision=53949
2013-12-11 21:25:35 +00:00
Chris Maynard
6120f6a116
New-style dissectors return the number of bytes dissected, not TRUE/FALSE.
...
svn path=/trunk/; revision=53948
2013-12-11 21:23:32 +00:00