Commit graph

150 commits

Author SHA1 Message Date
Pascal Quantin
7a44616a1d Fix dissection of 8PSK Power Capability IE
svn path=/trunk/; revision=54942
2014-01-24 16:33:31 +00:00
Evan Huus
a6415ece0a Rename a couple of to_str functions to have ep_ in the name. This makes it
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).

svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
Jakub Zawadzki
c45475ab45 Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54135
2013-12-15 23:44:12 +00:00
Pascal Quantin
39fd5f29af Fix copy paste errors
svn path=/trunk/; revision=52823
2013-10-24 21:11:00 +00:00
Bill Meier
9874da2fcb #if 0 numerous "unused const variables" (mostly value-string-arrays);
Also; fix a few "set but not used" warnings.

svn path=/trunk/; revision=52780
2013-10-23 06:29:11 +00:00
Michael Mann
346f803d42 Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either:
1. Case sensitivity differences between hf_ field name and formatted string.
2. Unnecessary whitespace between hf_ field name and colon in formatted string

There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed.

svn path=/trunk/; revision=52098
2013-09-16 10:39:06 +00:00
Alexis La Goutte
2632e16985 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51885
2013-09-09 19:30:47 +00:00
Pascal Quantin
a65045ec3f Code cleanup:
- remove some useless trees
- prettify the dissection of a few IEs
- use ELEM_MAND_VV_SHORT macro where applicable

svn path=/trunk/; revision=51741
2013-09-03 21:10:05 +00:00
Michael Mann
a72fc72061 Batch of filterable expert info.
svn path=/trunk/; revision=51689
2013-09-03 02:26:50 +00:00
Pascal Quantin
777613f964 Remove useless tree
svn path=/trunk/; revision=51602
2013-08-30 17:55:07 +00:00
Pascal Quantin
c82839c0a2 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9085 :
GSM A-I/F DTAP - Detach Request - Detach type is not displayed

svn path=/trunk/; revision=51599
2013-08-30 17:23:36 +00:00
Pascal Quantin
84bf0acc00 Convert a few dissectors from EMEM to WMEM API
svn path=/trunk/; revision=51597
2013-08-30 14:49:55 +00:00
Pascal Quantin
22c5585547 Add a DRX subtree to GTP dissector now that the subtree (useless for NAS and EPS NAS dissectors) was removed from de_gmm_drx_param in r51537
svn path=/trunk/; revision=51541
2013-08-27 19:38:35 +00:00
Pascal Quantin
77f1ed0f93 Make SPLIT PG CYCLE CODE filterable
svn path=/trunk/; revision=51537
2013-08-27 17:01:58 +00:00
Pascal Quantin
ef942ca080 Upgrade NAS disssectors to v11.7.0
svn path=/trunk/; revision=50494
2013-07-10 21:31:22 +00:00
Anders Broman
b522b91cf6 Revert revision 48854, the problem is in packet-gtp.c not setting P2P_DIR correctly.
svn path=/trunk/; revision=48872
2013-04-16 05:40:54 +00:00
Anders Broman
1b7b729852 Don't check direction on "prot" where the meaning is the same UL/DL
svn path=/trunk/; revision=48854
2013-04-15 16:29:59 +00:00
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Pascal Quantin
92dce1c3f0 Do not initialize ett_tree and dtap_msg_fcn when match_strval_idx does not find a match
svn path=/trunk/; revision=48520
2013-03-24 10:09:16 +00:00
Pascal Quantin
1af56ab0c7 Upgrade NAS disssectors to v11.6.0
svn path=/trunk/; revision=48427
2013-03-19 20:47:48 +00:00
Pascal Quantin
86eda54fe6 As suggested by Evan Huus, use extended value_strings
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
Pascal Quantin
94f330030d use enum values instead of hardcoded values
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)

svn path=/trunk/; revision=48397
2013-03-18 20:26:47 +00:00
Anders Broman
c94d02cf85 svn path=/trunk/; revision=47229 2013-01-23 15:40:32 +00:00
Pascal Quantin
ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209.
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
Pascal Quantin
0b20f855f0 Upgrade NAS disssectors to v11.5.0
svn path=/trunk/; revision=46842
2012-12-29 17:10:04 +00:00
Bill Meier
7c11289535 Fix several [-Wshadow] warnings;
Also: Do some minor whitespace and formatting changes.

svn path=/trunk/; revision=46197
2012-11-26 02:24:48 +00:00
Pascal Quantin
e4f6a12b1a The APN is an SM IE
svn path=/trunk/; revision=45858
2012-11-01 10:10:55 +00:00
Anders Broman
49307fcedc High light bytes including the first lenght byte in the APN name.
svn path=/trunk/; revision=45856
2012-11-01 08:24:08 +00:00
Anders Broman
b762b44048 Mark a parameter as unused.
svn path=/trunk/; revision=45851
2012-10-31 16:39:51 +00:00
Anders Broman
361adb3822 Make APN name a filterable item.
Fixes part of bug 7932.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7932

svn path=/trunk/; revision=45850
2012-10-31 16:19:46 +00:00
Pascal Quantin
9bcae55a34 Fix copy/paste error
svn path=/trunk/; revision=45330
2012-10-05 04:48:51 +00:00
Pascal Quantin
04ba20fa0e Upgrade NAS dissector to v11.4.0 (Release 11)
svn path=/trunk/; revision=45325
2012-10-04 21:23:06 +00:00
Pascal Quantin
191dd647a1 Display the raw PFI next to the translated one (as a value string array would do) so as to reduce a bit confusion
svn path=/trunk/; revision=45295
2012-10-03 18:09:04 +00:00
Pascal Quantin
64272873f0 The Packet Filter Identifier range is [1;16] according to 3GPP 27.007 chapter 10.1.3
svn path=/trunk/; revision=45266
2012-10-02 20:17:08 +00:00
Pascal Quantin
ff3bd58b74 Upgrade NAS EPS dissector to v11.4.0 (Release 11)
svn path=/trunk/; revision=45253
2012-10-02 12:46:21 +00:00
Pascal Quantin
99d2b14706 Remove a duplicate hf
svn path=/trunk/; revision=45200
2012-09-28 21:20:29 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Pascal Quantin
d530983a67 Update dissection of Request type IE
svn path=/trunk/; revision=44948
2012-09-17 16:04:36 +00:00
Pascal Quantin
7da4784b25 Following r44648, revert part of r44162 and followups so as to have a top level gsm_a filter name
svn path=/trunk/; revision=44667
2012-08-25 13:32:41 +00:00
Bill Meier
98774f5734 Fix extended value-string linear search: remove 2 dups from value-string array.
svn path=/trunk/; revision=44634
2012-08-23 12:51:32 +00:00
Pascal Quantin
025200992d Follow-up of r44162: gsm_a_gm dissector is used for both GPRS Mobility Management and Session Management protocols. Update filter names accordingly.
svn path=/trunk/; revision=44183
2012-08-01 09:44:57 +00:00
Michael Mann
175851fb40 Updated GSM dissectors display filters per checkfiltername.pl
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name.

svn path=/trunk/; revision=44162
2012-07-31 18:54:11 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Jeff Morriss
a59aa64da4 Fix: packet-gsm_a_gm.c:3965:6: error: comparison is always true due to limited range of data type [-Werror=type-limits]
svn path=/trunk/; revision=42797
2012-05-22 23:59:41 +00:00
pascal
9746c22630 Dissect Operator Specific Use container in Protocol Configuration Options IE
Put protocol and container ID in a subtree

svn path=/trunk/; revision=42790
2012-05-22 20:34:20 +00:00
pascal
0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs)
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
Jörg Mayer
d40cea2e7b Two cases where gcc has problems to detect that a specific specific
variable may not be used uninitialized.

svn path=/trunk/; revision=42731
2012-05-21 00:23:13 +00:00
pascal
254fcdfe19 Upgrade NAS dissector to Release 10 (v10.6.1)
svn path=/trunk/; revision=42728
2012-05-20 20:56:42 +00:00
Michael Tüxen
2250389193 Make the compiler happy.
svn path=/trunk/; revision=42723
2012-05-20 10:57:12 +00:00
pascal
774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1)
svn path=/trunk/; revision=42722
2012-05-20 09:50:34 +00:00