Commit graph

30 commits

Author SHA1 Message Date
Guy Harris
4d9475e4ef Get rid of tvb_get_faked_unicode() - tvb_get_string_enc() does the job
better.

We don't need eventlog_get_unicode_string_length() in the eventlog
dissector, either - tvb_unicode_strsize() does the job just as well.

svn path=/trunk/; revision=54874
2014-01-21 09:56:34 +00:00
Michael Mann
e2df7c83cb Move dceprc_procedure_name from packet_info to dcerpc_info. Doesn't appear to be "used" by dissectors, just stored (for help in debugging?).
svn path=/trunk/; revision=53552
2013-11-24 20:55:55 +00:00
Michael Mann
22760b2d2a Remove pinfo->private_data from DCERPC dissectors and instead have dcerpc_info* infomation be passed in as a function parameter. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387)
All "generated" source was manually modified (with the power of search/replace), but I believe the "source input" files have been adjusted (checked into revs 53098 and 53099) to reflect the necessary changes (with possible whitespace formatting differences).

The Microsoft compiler doesn't flag "unused function parameters", so I apologize in advance if I may have missed a few.  The "dcerpc_info* di" parameter is used in almost every function.

svn path=/trunk/; revision=53100
2013-11-06 14:31:29 +00:00
Michael Mann
87e55cb9e0 Sync with latest SAMBA PIDL source per http://www.wireshark.org/lists/wireshark-dev/201310/msg00217.html
Didn't integrate
0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch
0016-Regenerate-the-dnserver.patch

due to compilation errors on Windows.

svn path=/trunk/; revision=52744
2013-10-21 19:41:54 +00:00
Michael Mann
0334c5b425 Remove check_col from generated DCE/RPC dissectors. Bug 8804 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8804).
I still couldn't figure out how to generate the source, so I made the modifications to the generated dissectors "manually" (search/replace tool in VS) that would match the "PIDL source" included here.

I will be sending the "PIDL source" (non dissector files) to the samba team.

svn path=/trunk/; revision=52313
2013-10-01 14:45:03 +00:00
Michael Mann
cf80442912 Convert some proto_tree_add_string_format calls to something more appropriate.
There seem to be several cases of proto_tree_add_string_format where a "string" value/filter doesn't really make sense because it's always empty, and is just being used as a "filterable subtree header (placeholder)".  They appear to be more for "presense" than "value" and should probably be FT_NONE, although I'd almost argue for removing the filter in favor of  proto_tree_add_text.

svn path=/trunk/; revision=52296
2013-09-30 15:21:09 +00:00
Pascal Quantin
a0c53ffaa1 emem -> wmem conversion:
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits()
- tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup()
- tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode()
- tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string()
- tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string()
- tvb_get_ephemeral_string_enc() -> tvb_get_string_enc()
- update docs accordingly

svn path=/trunk/; revision=52172
2013-09-22 15:50:55 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jeff Morriss
554ed113a9 Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be sent upstream to the Samba developers.
svn path=/trunk/; revision=34713
2010-10-30 14:35:05 +00:00
Ronnie Sahlberg
ad942553b3 start describing ReportEventW in the IDL and make use of the "bitmap"
for EventTypes.

This addresses also bug 3552 with the until now unusued code.


The eventlog dissector is very incomplete.
While the protocol specification is available now, what is lacking is 
example capture files to test with when implementing more of the IDL 
definitions.




svn path=/trunk/; revision=29231
2009-07-29 10:59:31 +00:00
Ronnie Sahlberg
e5f6cb05da Fixup the correct names of the parameters for OpenEventLogW
svn path=/trunk/; revision=29230
2009-07-29 10:41:24 +00:00
Ronnie Sahlberg
1899a11f3f update the idl to correctly dissect the read eventlog w flags as a
bitmap and not as a uint32

this addresses bug 3691 (that was already manually addressed by hand 
in the generated dissector)



svn path=/trunk/; revision=29229
2009-07-29 10:28:10 +00:00
Stig Bjørlykke
27572c22f4 From Kovarththanan Rajaratnam via bug 3702:
This patch optimizes the data source name processing in add_new_data_source()
by delaying it. We now simply store the constant string and lazily compute the
name when needed. This gives a performance boost because we only need the name
if we have multiple data sources.

svn path=/trunk/; revision=29066
2009-07-12 10:19:13 +00:00
Stig Bjørlykke
b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Stig Bjørlykke
b17d12b64d Removed an unused static entry.
svn path=/trunk/; revision=25521
2008-06-22 00:50:29 +00:00
Ronnie Sahlberg
74e19c696e regenerate the dissectors with an even newer patched version of pidl to add two more pragmas
you need this patch ontop of svn pidl to regenerate the files :

Index: lib/Parse/Pidl/Wireshark/NDR.pm
===================================================================
--- lib/Parse/Pidl/Wireshark/NDR.pm     (revision 22005)
+++ lib/Parse/Pidl/Wireshark/NDR.pm     (working copy)
@@ -916,6 +916,14 @@
        $res{headers} .= "#ifdef HAVE_CONFIG_H\n";
        $res{headers} .= "#include \"config.h\"\n";
        $res{headers} .= "#endif\n\n";
+
+       $res{headers} .= "#ifdef _MSC_VER\n";
+       $res{headers} .= "#pragma warning(disable:4005)\n";
+       $res{headers} .= "#pragma warning(disable:4013)\n";
+       $res{headers} .= "#pragma warning(disable:4018)\n";
+       $res{headers} .= "#pragma warning(disable:4101)\n";
+       $res{headers} .= "#endif\n\n";
+
        $res{headers} .= "#include <glib.h>\n";
        $res{headers} .= "#include <string.h>\n";
        $res{headers} .= "#include <epan/packet.h>\n\n";



svn path=/trunk/; revision=21262
2007-03-29 02:22:23 +00:00
Ronnie Sahlberg
c46d3f3796 fixup the idl to always use pointer for out parameters
regenerate with patched pidl


svn path=/trunk/; revision=21261
2007-03-29 02:09:48 +00:00
Ulf Lamping
9e78e405c0 from Gisle Vanem: some more #pragma's that MingW don't like
svn path=/trunk/; revision=21240
2007-03-28 03:56:24 +00:00
Ulf Lamping
c2408435bc fix the remaining MSVC warnings by setting individual #pragma(warning:disable) settings - this is very certainly not the way to go, but the way to prevent additional warnings rushing in ...
svn path=/trunk/; revision=21221
2007-03-27 02:14:56 +00:00
Ronnie Sahlberg
1af9fbb14f Using a patched version of pidl that decorates all parameters with _U_
and updates to the conformance file,
regenerate the eventlog dissector to remove a lot of compiler warnings


svn path=/trunk/; revision=21110
2007-03-22 08:45:01 +00:00
Ronnie Sahlberg
87f05b8bda update EFS and EVENTLOG conformance files to use the new defines
for when policy handles are opened/closed and regenerate the dissector
with the latest version of PIDL



svn path=/trunk/; revision=20917
2007-02-24 21:34:29 +00:00
Ronnie Sahlberg
1371e6de35 add tracking of policy_handles to the eventlog dissector
svn path=/trunk/; revision=19801
2006-11-05 05:21:33 +00:00
Guy Harris
239ba17a50 dissect_ndr_uint16()'s last argument points to a guint16, not a guint.
svn path=/trunk/; revision=19316
2006-09-24 20:31:02 +00:00
Ronnie Sahlberg
cb23bfa371 update where the extra strings in the record are being dissected to that the decode follows the packet structure more closely
svn path=/trunk/; revision=19283
2006-09-22 07:56:18 +00:00
Ronnie Sahlberg
4fb91a42f8 update to eventlog record
dissect the informational strings that may be present inside an event



svn path=/trunk/; revision=19282
2006-09-22 07:43:29 +00:00
Ronnie Sahlberg
f1aec19c53 add conformance file magic to decode the non-NDR source/computer name strings of the eventlog_Record
svn path=/trunk/; revision=19280
2006-09-22 01:40:23 +00:00
Ronnie Sahlberg
e38da93629 updates to eventlog to use the pidl generated dissector and enhance the conformance file to dissect parts of the eventlog Records.
(record dissection is incomplete since this is not really NDR encoded   but better than nothing)



svn path=/trunk/; revision=19279
2006-09-22 00:01:38 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Guy Harris
13bb12c4f1 Move a bunch of stuff that's more Windows-related than SMB-related to
"packet-windows-common.[ch]".

svn path=/trunk/; revision=11592
2004-08-03 02:28:49 +00:00
Gilbert Ramirez
669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00
Renamed from packet-dcerpc-eventlog.c (Browse further)