Commit graph

2596 commits

Author SHA1 Message Date
Anders Broman
84241f46ad From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48399
2013-03-18 20:44:36 +00:00
Alexis La Goutte
55cdb2b45b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48374
2013-03-17 19:24:09 +00:00
Anders Broman
3e38475176 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48356
2013-03-17 17:52:26 +00:00
Anders Broman
fad318ad44 From beroset:
changed implicit casts to explicit casts and corrected one erroneous cast (from void* to void**)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48286
2013-03-14 06:26:55 +00:00
Anders Broman
d0efafbcb1 From beroset:
remove C++ incompatibilities from UAT_VS_DEF macro and all uses

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48259
2013-03-12 06:40:13 +00:00
Anders Broman
1b788d4061 Update to V11.5.0 (2012-12).
svn path=/trunk/; revision=48195
2013-03-08 17:55:53 +00:00
Pascal Quantin
d915e3c04f Prettify a bit dissection of sr-ProhibitTimer-r9 and drxShortCycleTimer
svn path=/trunk/; revision=48188
2013-03-08 08:19:26 +00:00
Anders Broman
37a86e4de6 Use explicit casts.
svn path=/trunk/; revision=48045
2013-03-04 06:48:36 +00:00
Anders Broman
04ec1e0984 Use explicit casts.
svn path=/trunk/; revision=48043
2013-03-03 21:22:25 +00:00
Anders Broman
9991973c37 Use explicit casts.
svn path=/trunk/; revision=48008
2013-03-02 14:51:04 +00:00
Balint Reczey
27320f87cb Remove asn1/dsp from autotools Makefile system since it lacks distclean target
svn path=/trunk/; revision=47994
2013-03-02 00:35:57 +00:00
Balint Reczey
1ebdb2e521 Export libwireshark symbols using WS_DLL_PUBLIC define
Also remove old WS_VAR_IMPORT define and related Makefile magic
everywhere in the project.

svn path=/trunk/; revision=47992
2013-03-01 23:53:11 +00:00
Guy Harris
c522bb09c2 The LDAP dissector uses register_frame_end_routine(), so it needs to
include packet-frame.h.

svn path=/trunk/; revision=47928
2013-02-28 00:09:26 +00:00
Pascal Quantin
7fdbff4822 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8378 :
A detailed diagnostic information contains either a SMS-SUBMIT-REPORT or a SMS-DELIVERY-REPORT. Set P2P direction accordingly.

svn path=/trunk/; revision=47927
2013-02-27 23:08:17 +00:00
Guy Harris
53fffe0414 Get rid of unnecessary includes of "packet-frame.h".
svn path=/trunk/; revision=47925
2013-02-27 23:02:18 +00:00
Guy Harris
6b629c4d92 Move show_exception() and show_reported_bounds_error() to
epan/show_exception.c, as it's used outside
epan/dissectors/packet-frame.c.  Update their callers to include
<epan/show_exception.h> to get their declaration.

Add a CATCH_NONFATAL_ERRORS macro that catches all exceptions that, if
there's more stuff in the packet to dissect after the dissector call
that threw the exception, doesn't mean you shouldn't go ahead and
dissect that stuff.  Use it in all those cases, including ones where
BoundsError was inappropriately being caught (you want those passed up
to the top level, so that the packet is reported as having been cut
short in the capture process).

Add a CATCH_BOUNDS_ERRORS macro that catches all exceptions that
correspond to running past the end of the data for a tvbuff; use it
rather than explicitly catching those exceptions individually, and
rather than just catching all exceptions (the only place that
DissectorError should be caught, for example, is at the top level, so
dissector bugs show up in the protocol tree).

Don't catch and then immediately rethrow exceptions without doing
anything else; just let the exceptions go up to the final catcher.

Use show_exception() to report non-fatal errors, rather than doing it
yourself.
 
If a dissector is called from Lua, catch all non-fatal errors and use
show_exception() to report them rather than catching only
ReportedBoundsError and adding a proto_malformed item.

Don't catch exceptions when constructing a trailer tvbuff in
packet-ieee8023.c - just construct it after the payload has been
dissected, and let whatever exceptions that throws be handled at the top
level.

Avoid some TRY/CATCH/ENDTRY cases by using checks such as
tvb_bytes_exist() before even looking in the tvbuff.

svn path=/trunk/; revision=47924
2013-02-27 22:43:54 +00:00
Michael Mann
8c0d526f58 SNMP dissector should handle aes256 (better version than r47690)
svn path=/trunk/; revision=47902
2013-02-26 11:38:39 +00:00
Bill Meier
96a24cc79f Fix spelling/typos found using a list of commonly misspelled words.
The misspellings were mostly in comments but some were
in text strings visible to the user.


svn path=/trunk/; revision=47899
2013-02-26 04:42:26 +00:00
Bill Meier
d449c31d1d its ==> it's & it's ==> its as needed.
svn path=/trunk/; revision=47892
2013-02-26 01:22:18 +00:00
Martin Kaiser
38a73a32f3 include the wsutil/wsgcrypt.h instead of including gcrypt.h directly
svn path=/trunk/; revision=47802
2013-02-21 18:23:29 +00:00
Guy Harris
c5f0b68669 And one more case where tvb_new_subset_remaining() is appropriate.
svn path=/trunk/; revision=47760
2013-02-20 01:38:58 +00:00
Guy Harris
021069a56b Clean up white space - get rid of 4-space tabs.
Reformat the hf[] array to be consistent, and get rid of some bogus
blurbs (probably copy-and-pasteos).

svn path=/trunk/; revision=47759
2013-02-20 01:37:08 +00:00
Guy Harris
29715ccc8f How can I get a new tvbuff that starts at an offset within a given
tvbuff and runs to the end of the tvbuff?  Let me count the ways....

Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().

svn path=/trunk/; revision=47751
2013-02-19 23:17:07 +00:00
Anders Broman
9736ff7cb5 Remove experiment with global code
svn path=/trunk/; revision=47747
2013-02-19 18:53:47 +00:00
Anders Broman
fc2b80ac0b Add the remaining asn1 files "CODE global" not handled yet.
svn path=/trunk/; revision=47746
2013-02-19 18:44:06 +00:00
Anders Broman
b38062ff8f Dissect more supplementarry services
svn path=/trunk/; revision=47738
2013-02-18 19:34:04 +00:00
Anders Broman
399f019522 Add more ASN1 files.
svn path=/trunk/; revision=47730
2013-02-18 06:26:09 +00:00
Michael Mann
fd44f9a339 Remove C++ incompatibilities in c1222 dissector.
Also addresses an implicit cast in the epan/uat.h file

Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342)

svn path=/trunk/; revision=47721
2013-02-17 22:15:16 +00:00
Guy Harris
61f7b3e031 Squelch some more warnings.
svn path=/trunk/; revision=47717
2013-02-17 20:00:53 +00:00
Guy Harris
947da615c4 Squelch some warnings.
svn path=/trunk/; revision=47716
2013-02-17 19:58:56 +00:00
Anders Broman
ad636a9492 Try to fix merge problem.
svn path=/trunk/; revision=47714
2013-02-17 19:35:17 +00:00
Anders Broman
9341c04a12 Add a preferense to the Q.932 dissector wether facility messages should be dissected as QSIG or ETSI.
Add the ISUP Supplementary services dissector.

svn path=/trunk/; revision=47713
2013-02-17 19:28:59 +00:00
Guy Harris
1e389e91c1 Give it an RCS ID.
svn path=/trunk/; revision=47710
2013-02-17 19:08:12 +00:00
Guy Harris
4e16c03bd1 Get rid of trailing CRs, set the usual svn properties to expand $Id$ and
use native line endings.

svn path=/trunk/; revision=47709
2013-02-17 19:07:27 +00:00
Anders Broman
f942b5e12a Add isdn-sup to the asn1 makefiles.
svn path=/trunk/; revision=47707
2013-02-17 18:32:35 +00:00
Anders Broman
7a60d0d9eb Add the files for an initial ISDN Supplimentary Services(ETSI) dissector.
svn path=/trunk/; revision=47706
2013-02-17 18:27:04 +00:00
Pascal Quantin
9dc510fc8e Fix typo error
svn path=/trunk/; revision=47693
2013-02-16 13:55:10 +00:00
Michael Mann
46dbc91896 Add decryption algorithm preference to SNMP dissector.
Bug 8328 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8328)

svn path=/trunk/; revision=47690
2013-02-16 02:10:50 +00:00
Pascal Quantin
203e7e0301 Factorize FGI dissection
svn path=/trunk/; revision=47654
2013-02-14 10:09:46 +00:00
Anders Broman
e5556e29ce Export TBCD-STRING.
svn path=/trunk/; revision=47496
2013-02-05 15:12:13 +00:00
Bill Meier
8ef31f222e Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start of comment' within a text string.
svn path=/trunk/; revision=47446
2013-02-02 14:20:15 +00:00
Pascal Quantin
98c1748e12 Add SIB type to info column
svn path=/trunk/; revision=47394
2013-01-31 20:08:38 +00:00
Anders Broman
4a8f124c43 Add an OID translation.
svn path=/trunk/; revision=47386
2013-01-31 16:59:39 +00:00
Michael Mann
8ad4ccb850 Allow SNMP user table entry to be re-editted even if engineID/Username remains the same.
Bug 2426 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2426)

svn path=/trunk/; revision=47328
2013-01-28 21:08:14 +00:00
Pascal Quantin
df466c5940 Remove duplicate include file
svn path=/trunk/; revision=47275
2013-01-25 18:37:00 +00:00
Pascal Quantin
fd659d2b4a Fix dissection of ETWS/CMAS messages
svn path=/trunk/; revision=47274
2013-01-25 18:33:07 +00:00
Pascal Quantin
eaf731ccad Remove non ASCII character
svn path=/trunk/; revision=47273
2013-01-25 16:50:05 +00:00
Anders Broman
ce6025b059 Dissect Broadcast-Message-Content correctly.
svn path=/trunk/; revision=47272
2013-01-25 15:29:19 +00:00
Tomas Kukosa
5d3ff466da Fix H.460.9 numbers of parameters
svn path=/trunk/; revision=47256
2013-01-24 11:54:18 +00:00
Tomas Kukosa
d19cde439e Fix H.460.x calling from H.225 - content decoding
svn path=/trunk/; revision=47253
2013-01-24 10:11:02 +00:00