osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
34,806 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

34806 Commits

Author SHA1 Message Date
Stig Bjørlykke 888880eb25 Rewrote check for szStr in dissect_ICBAPhysicalDevice_get_LogicalDevice_rqst. 
Coverity 535.

svn path=/trunk/; revision=36282
 2011-03-23 07:34:00 +00:00
Stig Bjørlykke e8e4bff8ee Removed "comparing an array to null", with no effect. 
Coverity 534.

svn path=/trunk/; revision=36281
 2011-03-23 07:31:17 +00:00
Stig Bjørlykke 0ae643e27d Removed "comparing an array to null", with no effect. 
Coverity 533.

svn path=/trunk/; revision=36280
 2011-03-23 07:29:19 +00:00
Stig Bjørlykke aca69d699a Removed "comparing an array to null", with no effect. 
Coverity 532.

svn path=/trunk/; revision=36279
 2011-03-23 07:25:08 +00:00
Ronnie Sahlberg 0832de6b8e value&0x03 does not need to be shifted to the right by two. 
cut-n-paste bug from a few lines above where value&0x0c do need to be shifted by two
before printing as a value

coverity 342


svn path=/trunk/; revision=36278
 2011-03-23 06:50:09 +00:00
Anders Broman 691c566900 CID 453,454 
Missing break

svn path=/trunk/; revision=36277
 2011-03-23 05:48:58 +00:00
Ronnie Sahlberg 875abf1deb dont assign to a proto_item* unless we are going to use the value 
coverity 1157

svn path=/trunk/; revision=36276
 2011-03-23 05:18:26 +00:00
Ronnie Sahlberg c317244ff8 Print the time units in the CSV output for io_stat using correct extension, i.e. always in seconds. 
coverity 419

svn path=/trunk/; revision=36275
 2011-03-23 05:11:06 +00:00
Ronnie Sahlberg 89d3156883 Shift the correct number of steps when masking the UAAERP bit to 0/1 
coverity 348

svn path=/trunk/; revision=36274
 2011-03-23 04:55:22 +00:00
Ronnie Sahlberg 24eb2e7b6e The NSG bits in the login pdu are 0x0c not 0xc0 
coverity 344


svn path=/trunk/; revision=36273
 2011-03-23 04:50:17 +00:00
Bill Meier 31b01ae88e Don't compute each checksum twice when adding dummy headers (-u, -T, -s, -S options) 
g_ntohs() & friends may be (are ?) macros and may (will ?) eval args more than once ...


svn path=/trunk/; revision=36272
 2011-03-23 00:43:55 +00:00
Jeff Morriss 263a3b3d10 Don't compile expert_dlg.c (that dialog is being removed) 
svn path=/trunk/; revision=36271
 2011-03-22 21:15:36 +00:00
Gerald Combs 6e7d652034 Clarify a comment. 
svn path=/trunk/; revision=36270
 2011-03-22 21:07:00 +00:00
Ronnie Sahlberg feaf55330e Coverity 989 
Remove some item=  assignments we dont need since we never use the value
of the created item.


svn path=/trunk/; revision=36269
 2011-03-22 20:48:36 +00:00
Stig Bjørlykke f775562f33 Added a sanity check for finfo->hfinfo. 
Coverity 425.

svn path=/trunk/; revision=36268
 2011-03-22 19:48:55 +00:00
Bill Meier 1f5bfa75b1 Remove two tests for fail return from g_malloc(); Fixes Coverity #424 "FORWARD_NULL" 
svn path=/trunk/; revision=36267
 2011-03-22 19:27:48 +00:00
Stig Bjørlykke ed3d478fb9 Allocate correct size of fdata col_text and col_text_len. 
Coverity 711 & 716.

svn path=/trunk/; revision=36266
 2011-03-22 19:24:08 +00:00
Stig Bjørlykke fac93b08b2 Allocate correct size of nwk_keyring. 
Coverity 715.

svn path=/trunk/; revision=36265
 2011-03-22 19:16:19 +00:00
Stig Bjørlykke 41d5c9b750 Allocate correct size of hash_key. 
Coverity 713.

svn path=/trunk/; revision=36264
 2011-03-22 19:13:48 +00:00
Stig Bjørlykke f51139e659 Allocate correct size of reload_frame. 
Coverity 714.

svn path=/trunk/; revision=36263
 2011-03-22 19:13:05 +00:00
Stig Bjørlykke 1f108b02a0 Allocate correct size of range. 
Coverity 718.

svn path=/trunk/; revision=36262
 2011-03-22 18:58:32 +00:00
Stig Bjørlykke abb51ebe9b Allocate correct size of int, not size of a pointer to int. 
Coverity 717.

svn path=/trunk/; revision=36261
 2011-03-22 18:53:37 +00:00
Stig Bjørlykke 2cc2403a33 Initialize al_cto before usage. 
Coverity 808.

svn path=/trunk/; revision=36260
 2011-03-22 18:42:02 +00:00
Stig Bjørlykke b03c1345d2 Initialize geom in window_get_geometry. 
Coverity 804.

svn path=/trunk/; revision=36259
 2011-03-22 18:28:08 +00:00
Bill Meier fda538056f Fix potential array overrun: Coverity CID #565. 
svn path=/trunk/; revision=36258
 2011-03-22 18:26:36 +00:00
Martin Mathieson 46857df13e Fix mask when extracting FACH Indicator. 
Coverity CID 349.

svn path=/trunk/; revision=36257
 2011-03-22 18:24:38 +00:00
Martin Mathieson 0370a7977d Remove redundant comparison. 
Coverity CID 361.

svn path=/trunk/; revision=36256
 2011-03-22 18:06:58 +00:00
Martin Mathieson 034820599a Make a struct static to avoid growing the stack too much. 
Coverity CID 753.

svn path=/trunk/; revision=36255
 2011-03-22 17:46:59 +00:00
Martin Mathieson bed50222ac Don't assign top_ti - delete it for now. 
Coverity CID 862

svn path=/trunk/; revision=36254
 2011-03-22 17:37:47 +00:00
Stephen Fisher b494b86514 From Dirk via bug #5771: Add heuristic dissector for images and HTTP 
Also add to AUTHORS file.


svn path=/trunk/; revision=36253
 2011-03-22 16:43:16 +00:00
Guy Harris 8ca97915c3 We have to initialize the elements of the fdata->col_text array to null 
pointers, as there's code that assumes that if they're not set to null
pointers, they're set correctly, and doesn't bother setting them to the
right value.

svn path=/trunk/; revision=36252
 2011-03-22 16:33:39 +00:00
Jeff Morriss 20c8fe0f7a Copy expert_tapdata_t here so that expert_dlg.h is no longer needed. 
svn path=/trunk/; revision=36251
 2011-03-22 16:05:12 +00:00
Martin Mathieson 4611533752 There can be up to 15 DL HARQ processes (depending upon TDD config index). 
svn path=/trunk/; revision=36250
 2011-03-22 14:39:02 +00:00
Jeff Morriss 3621346c20 Fix a typo 
svn path=/trunk/; revision=36249
 2011-03-22 13:49:07 +00:00
Stig Bjørlykke 9ec9b1ccb9 Pass pointers to structs instead of struct values to create_ntlmssp_v2_key. 
Coverity 567.

svn path=/trunk/; revision=36248
 2011-03-22 12:12:04 +00:00
Stig Bjørlykke feb0a4aeaa Allocate space for null termination in make_basename. 
Coverity 710.

svn path=/trunk/; revision=36247
 2011-03-22 11:46:19 +00:00
Stig Bjørlykke bdf603c403 Close fp in error case in ssl_parse_key_list to avoid leakage. 
Coverity 597.

svn path=/trunk/; revision=36246
 2011-03-22 11:40:15 +00:00
Stig Bjørlykke 75568093eb Rewrote error reporting to avoid using a 2048 bytes stack buffer. 
Coverity 726.

svn path=/trunk/; revision=36245
 2011-03-22 11:25:12 +00:00
Stig Bjørlykke a07fff3b15 Corrected hack for TAPA by checking for "not IPv4". 
Coverity 343.

svn path=/trunk/; revision=36244
 2011-03-22 10:12:07 +00:00
Ronnie Sahlberg 7191538bcc Coverity 1167 
Dont assign tlv_item unless we need to dereference it.
Also push the variable deeper into the scope where it is used isntead of function wide scope.


svn path=/trunk/; revision=36243
 2011-03-22 09:55:33 +00:00
Ronnie Sahlberg 3037db8904 Coverity 1168 
Create the items for 33_ARS under the subtree we create for this type and not under the parent node in the tree.


svn path=/trunk/; revision=36242
 2011-03-22 09:47:34 +00:00
Ronnie Sahlberg ff04f85940 Coverity 512 
Check if we ran out of bytes in the tvb and return NULL
instead of trying to pass it to the decryption routines.



svn path=/trunk/; revision=36241
 2011-03-22 09:35:26 +00:00
Ronnie Sahlberg dddec126f6 Coverity 323 
Use strdup to copy a string literal we will free() later on.



svn path=/trunk/; revision=36240
 2011-03-22 09:12:57 +00:00
Anders Broman 1ab6930388 - Add 9.4.5 IMEISV IE dissection 
- UE Time Zone is TLV
- Cell Global Identity  PDU type is SGSAP_PDU_TYPE

svn path=/trunk/; revision=36239
 2011-03-22 09:06:42 +00:00
Ronnie Sahlberg ea9e664fc9 Coverity 420 
Remove dead code and add a g_assert_not_reached() at a spot we can definitely never reach.

change a if(x)g_free(x) to a g_free(x)
since g_free(NULL) is just a nop.



svn path=/trunk/; revision=36238
 2011-03-22 09:05:26 +00:00
Guy Harris 423e428441 Use the same style in netscreen_seek_read() that we use in 
netscreen_read(), checking the return value of
parse_netscreen_hex_dump() against -1 and explicitly returning FALSE if
it's -1, otherwise driving on.

svn path=/trunk/; revision=36237
 2011-03-22 07:42:45 +00:00
Guy Harris 3a39cb2ed6 Make expert_tapdata_t opaque to its clients; define the structure only 
in gtk/expert_comp_dlg.c.

Don't declare now-static functions in gtk/expert_dlg.h.

svn path=/trunk/; revision=36236
 2011-03-22 07:24:14 +00:00
Anders Broman 694a48cdc8 Remove the Exper info dialogue. 
(Leave the fies for a while).

svn path=/trunk/; revision=36235
 2011-03-22 06:17:20 +00:00
Guy Harris 23e5eb42ba When we allocate the col_text array, initialize it to a bunch of 
pointers to null strings, rather than a bunch of null pointers, so that
if an exception is thrown before we set any of the columns, or some
other problem occurs, we don't end up with null pointers that could
later cause a crash.

Fix indentation.

svn path=/trunk/; revision=36234
 2011-03-22 03:56:39 +00:00
Bill Meier bdd6f7f692 Re-arrange code so Coverity Prevent doesn't falsely report several INFINITE_LOOPs: Coverity 427-429 (run 617) 
svn path=/trunk/; revision=36233
 2011-03-22 00:38:55 +00:00