osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
43393 commits 23 branches 0 tags 1.3 GiB
Commit graph

124 commits

Author SHA1 Message Date
Pascal Quantin
e4f6a12b1a The APN is an SM IE 
svn path=/trunk/; revision=45858
 2012-11-01 10:10:55 +00:00
Anders Broman
49307fcedc High light bytes including the first lenght byte in the APN name. 
svn path=/trunk/; revision=45856
 2012-11-01 08:24:08 +00:00
Anders Broman
b762b44048 Mark a parameter as unused. 
svn path=/trunk/; revision=45851
 2012-10-31 16:39:51 +00:00
Anders Broman
361adb3822 Make APN name a filterable item. 
Fixes part of bug 7932.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7932

svn path=/trunk/; revision=45850
 2012-10-31 16:19:46 +00:00
Pascal Quantin
9bcae55a34 Fix copy/paste error 
svn path=/trunk/; revision=45330
 2012-10-05 04:48:51 +00:00
Pascal Quantin
04ba20fa0e Upgrade NAS dissector to v11.4.0 (Release 11) 
svn path=/trunk/; revision=45325
 2012-10-04 21:23:06 +00:00
Pascal Quantin
191dd647a1 Display the raw PFI next to the translated one (as a value string array would do) so as to reduce a bit confusion 
svn path=/trunk/; revision=45295
 2012-10-03 18:09:04 +00:00
Pascal Quantin
64272873f0 The Packet Filter Identifier range is [1;16] according to 3GPP 27.007 chapter 10.1.3 
svn path=/trunk/; revision=45266
 2012-10-02 20:17:08 +00:00
Pascal Quantin
ff3bd58b74 Upgrade NAS EPS dissector to v11.4.0 (Release 11) 
svn path=/trunk/; revision=45253
 2012-10-02 12:46:21 +00:00
Pascal Quantin
99d2b14706 Remove a duplicate hf 
svn path=/trunk/; revision=45200
 2012-09-28 21:20:29 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Pascal Quantin
d530983a67 Update dissection of Request type IE 
svn path=/trunk/; revision=44948
 2012-09-17 16:04:36 +00:00
Pascal Quantin
7da4784b25 Following r44648, revert part of r44162 and followups so as to have a top level gsm_a filter name 
svn path=/trunk/; revision=44667
 2012-08-25 13:32:41 +00:00
Bill Meier
98774f5734 Fix extended value-string linear search: remove 2 dups from value-string array. 
svn path=/trunk/; revision=44634
 2012-08-23 12:51:32 +00:00
Pascal Quantin
025200992d Follow-up of r44162: gsm_a_gm dissector is used for both GPRS Mobility Management and Session Management protocols. Update filter names accordingly. 
svn path=/trunk/; revision=44183
 2012-08-01 09:44:57 +00:00
Michael Mann
175851fb40 Updated GSM dissectors display filters per checkfiltername.pl 
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name.

svn path=/trunk/; revision=44162
 2012-07-31 18:54:11 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
Jeff Morriss
a59aa64da4 Fix: packet-gsm_a_gm.c:3965:6: error: comparison is always true due to limited range of data type [-Werror=type-limits] 
svn path=/trunk/; revision=42797
 2012-05-22 23:59:41 +00:00
pascal
9746c22630 Dissect Operator Specific Use container in Protocol Configuration Options IE 
Put protocol and container ID in a subtree

svn path=/trunk/; revision=42790
 2012-05-22 20:34:20 +00:00
pascal
0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs) 
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
 2012-05-21 19:27:38 +00:00
Jörg Mayer
d40cea2e7b Two cases where gcc has problems to detect that a specific specific 
variable may not be used uninitialized.

svn path=/trunk/; revision=42731
 2012-05-21 00:23:13 +00:00
pascal
254fcdfe19 Upgrade NAS dissector to Release 10 (v10.6.1) 
svn path=/trunk/; revision=42728
 2012-05-20 20:56:42 +00:00
Michael Tüxen
2250389193 Make the compiler happy. 
svn path=/trunk/; revision=42723
 2012-05-20 10:57:12 +00:00
pascal
774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1) 
svn path=/trunk/; revision=42722
 2012-05-20 09:50:34 +00:00
Bill Meier
6fbb09d50b General Cleanup including: 
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);

svn path=/trunk/; revision=42678
 2012-05-17 14:35:11 +00:00
pascal
1e2f3bb55a Update RRC to V10.7.0 and add dissection of Core Network System Information IEs 
svn path=/trunk/; revision=42081
 2012-04-15 11:51:40 +00:00
Bill Meier
198c9ba55f FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE; 
In some cases:
 Use val_to_str_const() instead of val_to_str();
 Reformat long lines;
 Do some general whitespace changes.


svn path=/trunk/; revision=41587
 2012-03-16 02:00:29 +00:00
Anders Broman
a062fb34bd From Pascal Quantin [NAS EPS] Update Configuration Protocol description in PCO IE https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6865 
svn path=/trunk/; revision=41166
 2012-02-23 20:24:40 +00:00
Anders Broman
ce751db87c From Pascal Quantin: 
fixes for dissection of Traffic Flow Template IE.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6840

svn path=/trunk/; revision=41020
 2012-02-13 22:46:12 +00:00
Alexis La Goutte
958afd725d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=40993
 2012-02-12 18:04:26 +00:00
Chris Maynard
9105d0b0c9 Revert a recent spelling change back to its UK variant. 
svn path=/trunk/; revision=40631
 2012-01-21 16:09:08 +00:00
Chris Maynard
e4862cf115 Fix a comment and some typos. 
svn path=/trunk/; revision=40619
 2012-01-21 02:39:59 +00:00
Jaap Keuter
72ebaa39e3 From Pascal Quantin: 
Some test equipments can send weird Protocol Configuration Options IE in the
Attach Accept message with an empty protocol identifier content. Wireshark 
will trigger an assert when dissecting those messages because it does not 
check the tvb length before calling the sub dissector.
With checking the protocol identifier length before calling the sub dissector,
the PCO is decoded correctly.

svn path=/trunk/; revision=40604
 2012-01-20 07:49:12 +00:00
Anders Broman
b24d4d9142 From Pascal Quantin: 
Add S1 related info to the DRX parameter dissection (IE
common to 2G/3G/LTE) as specified in 3GPP 24.301 Release 9.8.0 chapter 10.5.5.6.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6642

svn path=/trunk/; revision=40070
 2011-12-02 21:56:10 +00:00
Anders Broman
4dd121e599 Extend dissection of GTPv2 EPS Security Context and Quadruplets. 
svn path=/trunk/; revision=40065
 2011-12-01 21:26:22 +00:00
Anders Broman
291994def5 From Pascal Quantin: 
adds to the Protocol Configuration Options the decoding of
the following container identifiers:
- Selected Bearer Control Mode
- DSMIPv6 Home Agent Address
- DSMIPv6 Home Network Prefix
- DSMIPv6 IPv4 Home Agent Address
- P-CSCF IPv4 Address
- DNS Server IPv4 Address

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6636

svn path=/trunk/; revision=40057
 2011-12-01 05:42:07 +00:00
Anders Broman
f40538afeb From Pascal Quantin: 
Currently Wireshark limits the Access Point Name length to 50 bytes. But
according to 3GPP 24.008 chapter 10.5.6.1, the maximum length is 100 bytes (102
bytes minus the IEI and length fields) and not 50.
The attached patch increases the MAX_APN_LENGTH define value and allow the
correct display of an APN with a size greater than 50 bytes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6628

svn path=/trunk/; revision=40044
 2011-11-29 22:25:21 +00:00
Anders Broman
094e30816d Fix Checkapi found errors. 
svn path=/trunk/; revision=40030
 2011-11-28 18:10:57 +00:00
Anders Broman
c755a51c40 Prevet a crash when dissecting linked TI. 
svn path=/trunk/; revision=40024
 2011-11-28 16:41:59 +00:00
Bill Meier
54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier
67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
 2011-10-10 00:39:31 +00:00
Anders Broman
5ba5385c74 Protect the columns from beeing overwritten. 
svn path=/trunk/; revision=37752
 2011-06-22 14:49:26 +00:00
Bill Meier
d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings. 
svn path=/trunk/; revision=37716
 2011-06-19 18:47:35 +00:00
Anders Broman
ed1bfad981 From Pascal Quantin: 
Update 3GPP NAS MS Radio Access Capability dissection to Release 9.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5970

From me change all enc type to ENC_BIG_ENDIAN.

svn path=/trunk/; revision=37451
 2011-05-29 06:06:22 +00:00
Jeff Morriss
cdedb31e94 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a 
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).  A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.

Store the return value of match_strval() rather than calling it repeatedly.

svn path=/trunk/; revision=37204
 2011-05-17 18:58:40 +00:00
Anders Broman
5a0acb469e Use the correct value string and bitmasks. 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5928

svn path=/trunk/; revision=37199
 2011-05-17 08:23:30 +00:00
Anders Broman
7dce5861cc From Pascal Quantin: 
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
 2011-04-27 22:18:00 +00:00
Anders Broman
aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00