that a retap doesn't build the protocol tree unless there's a tap with a
filter; presumably "the expert_item value" refers to the item to which
expert information is being attached.
However, if there's no protocol item, the only thing
expert_add_info_format() doesn't do is set the severity and group for a
protocol item, but the expert info composite dialog doesn't appear to
look at that.
Thus, it appears we can just use cf_retap_packets(); do so, as it's
faster.
svn path=/trunk/; revision=28270
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats). Hopefully this will catch at least
some P64 issues on UN*X.
svn path=/trunk/; revision=28108
The attached patch is an enhancement to the Expert Info Composite dialog's tab labels.
On the four severity level tabs a second number is displayed that represents the total
number of detail records associated with each severity level.
svn path=/trunk/; revision=27260
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).
This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702
svn path=/trunk/; revision=25933
This requires some casts to be added and I just don't want to add casts at all possible places. So I compile and only add casts where the (MSVC) compiler has a hard time.
Unfortunately this won't find any problems in Linux/Unix only code - I'll keep an eye on the buildbot and try to fix things as I'm going on ...
svn path=/trunk/; revision=24913
In summary these patches do the following:
1. GTK+ 2.x builds will now use Tree View to display the expert items, expanded items are the individual packet numbers.
2. GTK+ 1.x builds will continue to use the older clist functionality
3. Implements the equivilant of expert info (actually calls expert_dlg.c)
svn path=/trunk/; revision=18091
"error_t" is defined elsewhere on at least some versions of Fedora Core,
so it collides with our usage; use "expert_comp_dlg_t" instead.
svn path=/trunk/; revision=16889