Commit Graph

14065 Commits

Author SHA1 Message Date
Gerald Combs 5ec0554c24 In alloc_field_info, throw a ReportedBoundsError if we're passed an
invalid length.

svn path=/trunk/; revision=14203
2005-04-27 16:22:24 +00:00
Tomas Kukosa 130db4f23c Export of dissect_ber_null() and dissect_per_null()
svn path=/trunk/; revision=14202
2005-04-27 15:19:36 +00:00
Tomas Kukosa 94dffebd6c NULL type decoders for PER and BER
svn path=/trunk/; revision=14201
2005-04-27 14:17:14 +00:00
Ronnie Sahlberg 0389d222e2 With the speedup changes to epan/proto.c the tree will be faked to only contain those fields actually referenced by a filter.
Other nodes will never be created by the tree (sort of auto pruning of the tree).

While this greatly spped up the processing performance of ethereal, it makes it "dangerous" for apps that try to walk the tree directly.


rtp_analysis did not specify the fields "rtp.version" nor " rtp.ssrc" when dissecting the current packet  and as such these fields were no longer part of the tree.
This surprised rtp_analysis and a coredump resulted.


This change will add the field that we walkt the tree to find to the filter string so that they will be there.



svn path=/trunk/; revision=14200
2005-04-27 13:58:54 +00:00
Ronnie Sahlberg f229ab5733 fix for bug 107 from Greg Morris
svn path=/trunk/; revision=14199
2005-04-27 10:21:12 +00:00
Tomas Kukosa 3bb0b3a56b TFTP dissector registering
svn path=/trunk/; revision=14198
2005-04-27 06:50:04 +00:00
Gerald Combs f5e9a4101b Fix a buffer overflow. Fixes bug 100.
svn path=/trunk/; revision=14197
2005-04-27 04:09:15 +00:00
Lars Roland cac06c58a1 Reindent some parts of the sip dissector with tabs, as most parts of the dissector already use tabs. Remove also trailing white spaces.
svn path=/trunk/; revision=14196
2005-04-26 23:38:16 +00:00
Lars Roland 0c30cc130b Reindent the mgcp dissector with tabs and
remove trailing white spaces.

svn path=/trunk/; revision=14195
2005-04-26 23:14:35 +00:00
Gerald Combs 380dfa0fde Add a bunch of tvb_ensure_bytes_exist() calls. Fixes bug 106.
svn path=/trunk/; revision=14194
2005-04-26 22:19:38 +00:00
Gerald Combs 310c8a8434 Add a slew of tvb_ensure_bytes_exist() calls. This should probably be
converted to use the new-style ASN.1 code.  Fixes bug 102.

svn path=/trunk/; revision=14193
2005-04-26 22:06:04 +00:00
Gerald Combs e1a597eccf Add some tvb_ensure_bytes_exist() calls. Fixes bug 101.
svn path=/trunk/; revision=14192
2005-04-26 20:55:26 +00:00
Gerald Combs 38948db32b Add packet-bacapp.h to the distribution.
svn path=/trunk/; revision=14191
2005-04-26 14:08:30 +00:00
Ronnie Sahlberg 3a6778b8e7 fix for bug 91
make the heuristics for detecting connection-less dce/rpc a bit sharper to reduce the number of false positives



svn path=/trunk/; revision=14190
2005-04-26 09:03:30 +00:00
Ronnie Sahlberg d8dcc36d93 from anders b
diameter updates to add 3gpp vendor avp


svn path=/trunk/; revision=14189
2005-04-26 08:15:45 +00:00
Ronnie Sahlberg 0f66df8509 BACAPP updates
svn path=/trunk/; revision=14188
2005-04-26 08:03:22 +00:00
Guy Harris 5c5f1fd4e6 Make the offsets of the source address length and source address match
reality.

svn path=/trunk/; revision=14187
2005-04-25 18:04:28 +00:00
Gerald Combs 53865bb046 Don't try to access a null pointer. Found during fuzz testing.
svn path=/trunk/; revision=14186
2005-04-25 16:54:18 +00:00
Gerald Combs c993ffc6dc Add a tvb_ensure_bytes_exist(). Fixes a bug found during fuzz testing.
svn path=/trunk/; revision=14185
2005-04-25 16:23:00 +00:00
Gerald Combs 78a09d190b Fix another invalid item length. Fixes bug 98.
svn path=/trunk/; revision=14184
2005-04-25 15:28:32 +00:00
Gerald Combs a9e9262981 Don't try to tell proto_tree_add_item() that FT_UINT32s are something other
than 4 bytes.  It throws a fit when you do that.  Fixes bug 97.

svn path=/trunk/; revision=14183
2005-04-25 15:21:37 +00:00
Gerald Combs 87772809f4 Fix an infinite loop.
svn path=/trunk/; revision=14182
2005-04-25 03:02:50 +00:00
Lars Roland f78d66b0d7 From Martin Mathieson:
a first step of cleaning up the mgcp dissector:

- re-indenting/formatting the file as it was tricky to follow
- some code simplification and commenting (more to do)
- losing some unnecessary includes (not needed under linux at least...)
- show duplicate request and response fields in tree (previously hidden)
- improved duplicate response detection
- fix a couple of problems shown by fuzz testing

svn path=/trunk/; revision=14181
2005-04-25 00:51:11 +00:00
Lars Roland 118ce715a7 From Alejandro Vaquero:
improve dissection of Dynamic payload 
types used in conversations and the
codec list summary in the "Voip Calls Graph".

svn path=/trunk/; revision=14180
2005-04-24 18:43:42 +00:00
Lars Roland ca97aa1849 From Martin Mathieson:
Fix dissection of the SIP Method in the CSeq header.

svn path=/trunk/; revision=14179
2005-04-24 17:59:18 +00:00
Gerald Combs af4696c98d Fix an infinite loop.
svn path=/trunk/; revision=14178
2005-04-24 01:15:53 +00:00
Gerald Combs 103103e21c Fix a quoting bug.
svn path=/trunk/; revision=14177
2005-04-24 00:37:08 +00:00
Gerald Combs 522e204d87 Don't try to free the same memory twice.
svn path=/trunk/; revision=14176
2005-04-24 00:36:11 +00:00
Gerald Combs 640a1fcd53 Force a bunch of protocol items to be the proper length.
svn path=/trunk/; revision=14175
2005-04-23 22:13:00 +00:00
Gerald Combs a6cf86ce37 Add a few tvb_ensure_bytes_exist() calls.
svn path=/trunk/; revision=14174
2005-04-23 21:33:44 +00:00
Gerald Combs 46ebfe16b0 Don't try to free NULL. Don't overflow a buffer.
svn path=/trunk/; revision=14173
2005-04-23 21:31:25 +00:00
Gerald Combs cf23c92003 Make sure we don't exhaust system memory.
svn path=/trunk/; revision=14172
2005-04-23 20:54:59 +00:00
Gerald Combs 50d0f95328 Add more tvb_ensure_bytes_exist() calls.
svn path=/trunk/; revision=14171
2005-04-23 13:24:57 +00:00
Gerald Combs 028075b673 Add a couple of tvb_ensure_bytes_exist() calls to avoid dissector bug
exceptions.

svn path=/trunk/; revision=14170
2005-04-23 04:06:45 +00:00
Gerald Combs 082651c83e Define a maximum OID string length, and use it in a lot of places. Fixes a
buffer overflow found while fuzz testing.

svn path=/trunk/; revision=14169
2005-04-22 21:17:13 +00:00
Gerald Combs e8730eab95 Fix for the previous fix.
svn path=/trunk/; revision=14168
2005-04-22 18:06:39 +00:00
Gerald Combs 3ed50e1ae7 Don't pass a null format string to val_to_str().
svn path=/trunk/; revision=14167
2005-04-22 15:18:56 +00:00
Gerald Combs 42f80d7478 Don't pass a null format string to val_to_str().
svn path=/trunk/; revision=14166
2005-04-22 15:00:45 +00:00
Gerald Combs f2695565b4 Fix an infinite loop in dissect_rsvp_gen_uni(). Fixes bug 90. Fix up a
previous infinite loop fix.

svn path=/trunk/; revision=14165
2005-04-22 14:55:27 +00:00
Ronnie Sahlberg bf70d24df3 prettify portmapper GETPORT requests and responses
svn path=/trunk/; revision=14164
2005-04-22 05:00:02 +00:00
Gerald Combs f0795da8d6 Add some tvb_ensure_bytes_exist() calls.
svn path=/trunk/; revision=14163
2005-04-22 04:26:23 +00:00
Gerald Combs 8d914c66fd Squelch a valgrind warning.
svn path=/trunk/; revision=14162
2005-04-22 04:10:44 +00:00
Gerald Combs 1906593816 Fix a buffer overflow in isis_dissect_nlpid_clv().
svn path=/trunk/; revision=14161
2005-04-22 04:07:56 +00:00
Ronnie Sahlberg b95490206d from Olivier J
bugfix for IMPLICIT NULL in BER sequences
and gsmmap updates



svn path=/trunk/; revision=14160
2005-04-21 21:37:23 +00:00
Gerald Combs dfc96b3d23 In get_string(), throw an exception if the string is too long to
process.  Hopefully this doesn't break anything.  Add a bunch of
tvb_ensure_bytes_exist() calls.  Fixes bugs 48 - 51.

svn path=/trunk/; revision=14159
2005-04-21 18:19:38 +00:00
Gerald Combs f907a1085b Add a tvb_ensure_bytes_exist(). Fixes bug 68 and its many duplicates.
svn path=/trunk/; revision=14158
2005-04-21 15:11:38 +00:00
Guy Harris 09ed220e28 Add a comment asking about the address and mask length fields in
join/prune requests.

svn path=/trunk/; revision=14157
2005-04-20 21:55:14 +00:00
Gerald Combs ec5ec3768e Allow the locations of tethereal, editcap, and capinfos to be changed.
Limit the amount of VM the process can use (default 500 MB).  If we
can't save a capture in libpcap format, try again with the encapsulation
type set to "ether".

svn path=/trunk/; revision=14156
2005-04-20 21:00:03 +00:00
Gilbert Ramirez 5176d29243 Avoid a buffer overflow in the cseq_method field, a fixed-length character array.
svn path=/trunk/; revision=14155
2005-04-20 20:23:07 +00:00
Gerald Combs adcd4554df From Dinesh Dutt: Improve reassembly checking. Replace a match_strval()
with a val_to_str().

svn path=/trunk/; revision=14154
2005-04-20 20:07:17 +00:00