Commit graph

16738 commits

Author SHA1 Message Date
Anders Broman
7c56677cf9 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48429
2013-03-19 21:22:31 +00:00
Anders Broman
b848149964 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48428
2013-03-19 21:06:52 +00:00
Pascal Quantin
1af56ab0c7 Upgrade NAS disssectors to v11.6.0
svn path=/trunk/; revision=48427
2013-03-19 20:47:48 +00:00
Anders Broman
6bde918078 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48426
2013-03-19 20:00:52 +00:00
Anders Broman
3eb06be97d From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48425
2013-03-19 19:28:57 +00:00
Anders Broman
c3a054e6c1 Don't calculate checksum for ICMP packsets with a partial IP packet.
svn path=/trunk/; revision=48423
2013-03-19 18:51:36 +00:00
Alexis La Goutte
d16cb61d96 From chaitanya via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8497
Add support for 11R RIC IE's: Data and Descriptors for both FT-Over-Air and FT-Over-DS

Add 802.11 Tag RIC Data (57)
Add 802.11 Tag RIC Descriptor (75) (Not tested...)

From me:
- Remove tabs and whitespace
- Fix fix-encodings-args "warning"

svn path=/trunk/; revision=48421
2013-03-19 16:59:06 +00:00
Evan Huus
d70fafb0db And packet-isup.c is the first to fall to r48415.
From Anders via
https://www.wireshark.org/lists/wireshark-dev/201303/msg00183.html

svn path=/trunk/; revision=48417
2013-03-19 15:38:14 +00:00
Pascal Quantin
d31620a7bf From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :
Remove C++ incompatibilities from Bluetooth dissectors and switch to wmem API

svn path=/trunk/; revision=48414
2013-03-19 13:51:52 +00:00
Anders Broman
a10b98284c From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48412
2013-03-19 04:54:30 +00:00
Pascal Quantin
f904464fe9 Add a missing static
svn path=/trunk/; revision=48410
2013-03-18 22:58:36 +00:00
Anders Broman
d8bd66c291 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48409
2013-03-18 22:38:56 +00:00
Pascal Quantin
86eda54fe6 As suggested by Evan Huus, use extended value_strings
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
Anders Broman
a46de56e38 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

(catch the one that almost slipped away)

svn path=/trunk/; revision=48404
2013-03-18 22:16:58 +00:00
Anders Broman
077c1eb385 Update a value_string
svn path=/trunk/; revision=48401
2013-03-18 21:31:56 +00:00
Anders Broman
55c498169d From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48400
2013-03-18 21:16:23 +00:00
Anders Broman
84241f46ad From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48399
2013-03-18 20:44:36 +00:00
Pascal Quantin
94f330030d use enum values instead of hardcoded values
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)

svn path=/trunk/; revision=48397
2013-03-18 20:26:47 +00:00
Anders Broman
434aae5245 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48396
2013-03-18 19:47:33 +00:00
Pascal Quantin
847fb4ef0a Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8493 :
Use proto_tree_add_item instead of proto_tree_add_bits_item to display Used Cipher

svn path=/trunk/; revision=48393
2013-03-18 16:11:00 +00:00
Anders Broman
b0f4928ab2 From Michal Labedzki:
Use external value list for character set values
 in AVRCP

There is a special list with a lot of values so why not using it.

- From me: import packet-wap.h.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=48390
2013-03-18 06:29:57 +00:00
Anders Broman
3b24b8bbef From Michal Labedzki:
Be consistent in short name of protocols

Use prefix "BT " in short name for all Bluetooth dissectors. A reason
for that is protocol names start by "bt", Bluetooth dissectors can
be easy identificated, also DecodeBy looks better (sorted).
Please be note that "SDP" is reserved for different dissector, so using
"BT SDP" is good choice.

Also fix two naming mistakes.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=48389
2013-03-18 06:23:22 +00:00
Anders Broman
2ae1d08bbe From Michal Labedzki:
Fix issues found by fix-encoding-args.pl
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=48388
2013-03-18 06:13:09 +00:00
Anders Broman
c2976ac508 From Michal Labedzki:
Fix issues discovered by cppcheck

Also use global OUI array in AVRCP.
Thanks to Evan Huus for cppcheck.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=48387
2013-03-18 06:04:09 +00:00
Anders Broman
5726546c63 From Michal Labedzki:
Update HID to version 1.1

Also fix SDP TAP to avoid crash.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=48386
2013-03-18 05:51:01 +00:00
Anders Broman
fa1f2a2935 From Michal Labedzki:
USB: Use hfi name instead of hardcoded value.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8304

svn path=/trunk/; revision=48385
2013-03-18 05:34:39 +00:00
Anders Broman
d1f89f81d8 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48384
2013-03-18 05:18:32 +00:00
Anders Broman
b7617b32eb From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48383
2013-03-17 22:16:39 +00:00
Alexis La Goutte
aaeb101b2b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48382
2013-03-17 19:25:20 +00:00
Alexis La Goutte
824e7fd6e8 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48381
2013-03-17 19:25:08 +00:00
Alexis La Goutte
716deac16d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48380
2013-03-17 19:25:00 +00:00
Alexis La Goutte
ce5a997d99 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48379
2013-03-17 19:24:51 +00:00
Alexis La Goutte
e4f9ca4afd Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48378
2013-03-17 19:24:42 +00:00
Alexis La Goutte
edcedbfed3 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48377
2013-03-17 19:24:34 +00:00
Alexis La Goutte
0367aaaa9b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48376
2013-03-17 19:24:25 +00:00
Alexis La Goutte
086eaf58bf Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48375
2013-03-17 19:24:17 +00:00
Alexis La Goutte
55cdb2b45b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48374
2013-03-17 19:24:09 +00:00
Alexis La Goutte
64e30a1686 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48373
2013-03-17 19:24:00 +00:00
Alexis La Goutte
af50b77f78 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48372
2013-03-17 19:23:52 +00:00
Alexis La Goutte
f07cd6c974 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48371
2013-03-17 19:23:43 +00:00
Alexis La Goutte
771999b83d Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48370
2013-03-17 19:23:35 +00:00
Alexis La Goutte
01f88e9207 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48369
2013-03-17 19:23:26 +00:00
Alexis La Goutte
ac8801b396 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48368
2013-03-17 19:23:18 +00:00
Alexis La Goutte
b31873a5bd Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48367
2013-03-17 19:23:09 +00:00
Alexis La Goutte
f311e3ca64 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48366
2013-03-17 19:23:01 +00:00
Alexis La Goutte
7c6767303e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48365
2013-03-17 19:22:53 +00:00
Alexis La Goutte
88be4f8651 Remove some whitespaces
svn path=/trunk/; revision=48364
2013-03-17 19:22:44 +00:00
Alexis La Goutte
b53f1ab2f0 Add Modelines info
svn path=/trunk/; revision=48363
2013-03-17 19:22:36 +00:00
Alexis La Goutte
311a15eebe Support (TCP) fragmentation for RPKI-RTR Protocol (Using tcp_dissect_pdus)
svn path=/trunk/; revision=48362
2013-03-17 19:22:27 +00:00
Alexis La Goutte
6c6d8f1629 Enhance 802.11 FCS check - Replace proto_tree_add_* by proto_tree_add_item - Add bad FCS to colorfilters
svn path=/trunk/; revision=48361
2013-03-17 19:22:19 +00:00
Alexis La Goutte
bfe7af447d Enhance 802.11 Qos Control dissection - Replace proto_tree_add_* by proto_tree_add_item - Use Bitmask feature
svn path=/trunk/; revision=48360
2013-03-17 19:22:10 +00:00
Alexis La Goutte
1f7466aa63 Enhance 802.11 Frame control dissection - Replace proto_tree_add_* by proto_tree_add_item - Add Expert info when Retry 802.11 Frame
svn path=/trunk/; revision=48359
2013-03-17 19:22:01 +00:00
Alexis La Goutte
6dcc65e366 Enhance Vendor RSN IE - Remove hf_ieee80211_tag_interpretation... - Replace proto_tree_add_* by proto_tree_add_item
svn path=/trunk/; revision=48358
2013-03-17 19:21:52 +00:00
Alexis La Goutte
a9787be380 Add 802.11 Tag RM Enabled Capabilities (70)
svn path=/trunk/; revision=48357
2013-03-17 19:21:42 +00:00
Anders Broman
3e38475176 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48356
2013-03-17 17:52:26 +00:00
Anders Broman
81e80f2c0b From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48355
2013-03-17 16:48:47 +00:00
Gerald Combs
9a376b8cd0 Pick up changes missed by the automatic update script (which should
now be fixed).

svn path=/trunk/; revision=48354
2013-03-17 15:39:56 +00:00
Evan Huus
4f48f35dfd Remove sqloracle dissector, it wasn't being built and was full of bugs.
It's on the wiki now at: http://wiki.wireshark.org/Oracle

For discussion of this, see:
https://www.wireshark.org/lists/wireshark-dev/201303/msg00161.html

svn path=/trunk/; revision=48349
2013-03-17 12:51:24 +00:00
Anders Broman
2e52e2ac99 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48347
2013-03-17 09:11:21 +00:00
Evan Huus
e8c305fd3b From Sylvain Munaut via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487
Use enum values instead of manual constants in value_strings. This was
introduced by r47218, which was designed to fix r47209, which would have been
correct in the first place if the value_strings hadn't been full of hacks.

I think everything is correct now. Perhaps it may be worth using extended
value_strings though, since most of the tables seem to be consecutive in order?

svn path=/trunk/; revision=48345
2013-03-16 20:46:19 +00:00
Anders Broman
d456976017 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48344
2013-03-16 20:22:54 +00:00
Anders Broman
55c20aa55a #if 0 out apparently unsed code.
svn path=/trunk/; revision=48343
2013-03-16 20:00:03 +00:00
Anders Broman
263a9d0683 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48341
2013-03-16 16:25:41 +00:00
Martin Kaiser
20769a8bee no need for if(tree)
removed unnecessary initialization

svn path=/trunk/; revision=48339
2013-03-16 09:37:06 +00:00
Anders Broman
5a85b7fed2 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48338
2013-03-16 08:52:09 +00:00
Anders Broman
27744ecc2d From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48337
2013-03-16 08:12:29 +00:00
Evan Huus
1931018a58 Check for overflow in the websocket dissector payload.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8448

svn path=/trunk/; revision=48336
2013-03-16 02:56:17 +00:00
Anders Broman
43e8a22781 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48334
2013-03-15 22:40:15 +00:00
Anders Broman
f5a5b3d0fe From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48333
2013-03-15 22:39:37 +00:00
Evan Huus
7bd686fafb Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8481
Trivially wrong format string being passed to val_to_str().

svn path=/trunk/; revision=48332
2013-03-15 22:09:51 +00:00
Anders Broman
54eb4a6cec [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48319
2013-03-15 16:39:30 +00:00
Anders Broman
ec4701ae72 Make the default port zero.
svn path=/trunk/; revision=48317
2013-03-15 16:35:54 +00:00
Anders Broman
ef249623e6 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48313
2013-03-15 06:26:47 +00:00
Anders Broman
4f1f9903f4 [-Wmissing-prototypes]
explicit casts.

svn path=/trunk/; revision=48310
2013-03-15 04:52:42 +00:00
Michael Mann
3a48e7e1e2 Bugfix Decryption Key Management dialog, bug 8446 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8446)
Needed to convert use of old IEEE802.11 preference strings to UAT.  Since UAT is self-contained within its own file, the entire preference file doesn't need to be rewritten/saved when UAT values are changed.

svn path=/trunk/; revision=48308
2013-03-15 01:31:53 +00:00
Jaap Keuter
930deed11d From Tyson Key:
I have just finished slightly refactoring part of the PN532 dissector's  
with InListPassiveTarget Response handler, to resolve some issues where 
ISO 14443-A UIDs of various lengths in the aforementioned packet types 
are incorrectly dissected.

The patch also introduces basic support for identifying, and dissecting 
InListPassiveTarget Responses from cards/tokens with variable-length 
Answer To Select (ATS) payloads, such as contactless EMV payment smartcards. 

svn path=/trunk/; revision=48306
2013-03-14 23:09:58 +00:00
Anders Broman
5970ee5a65 From beroset:
remove C++ incompatibilities from packet-catapult-dct2000.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48305
2013-03-14 22:10:59 +00:00
Anders Broman
f2266d87f5 [-Wmissing-prototypes]
explicit casts.

svn path=/trunk/; revision=48302
2013-03-14 19:01:06 +00:00
Anders Broman
ffaf67b615 from Katrina Zhang:
According to the latest TS29.274 -- adding 4 IE support: H(e)NB Information Reporting[165]; IPv4 Configuration Parameters (IP4CP)[166]; Change to Report Flags[167]; Action Indication[168]

 -- cause values of IE(Cause)

svn path=/trunk/; revision=48301
2013-03-14 19:00:40 +00:00
Anders Broman
fe5848271f from Katrina Zhang:
Adding Bit 5 support of AVP(IDR-Flags)

svn path=/trunk/; revision=48300
2013-03-14 18:59:56 +00:00
Anders Broman
96e7b183fb From beroset:
patch to remove C++ incompatibilities from packet-lmp.c
renamed class to lmp_class

remove C++ incompatibilities from packet-rcpap.c
renamed class to inst_class (instruction class).

remove C++ incompatibilities from emem.c and oids.c

remove C++ incompatibilities from packet-radius.c

remove C++ incompatibilities from packet-enip.c


https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48299
2013-03-14 18:58:42 +00:00
Bill Meier
77376a2363 Change "4 space tabs" indentation to use "4 spaces" indentation.
Also:
- remove some unneeded initializers;
- remove several unneeded 'col_clear()' calls;
- guint8 --> guint to prevent a possible overflow;
- reformat for style in some cases.


svn path=/trunk/; revision=48297
2013-03-14 14:42:12 +00:00
Stig Bjørlykke
8dfa2eac7e Set correct item lengths. They cannot all be until end of buffer.
svn path=/trunk/; revision=48296
2013-03-14 12:23:05 +00:00
Stig Bjørlykke
d9aff2d872 Fixed an indent to avoid a warning: for loop has empty body [-Wempty-body]
svn path=/trunk/; revision=48294
2013-03-14 08:41:11 +00:00
Anders Broman
b539916835 [-Wmissing-prototypes]
explicit casts.

svn path=/trunk/; revision=48293
2013-03-14 07:37:13 +00:00
Martin Kaiser
3fa84d8af5 From Weston Schmidt
fix DSM-CC CRC calculation
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8466

svn path=/trunk/; revision=48292
2013-03-14 07:01:37 +00:00
Anders Broman
44be81ba93 From beroset:
changed implicit casts to explicit and substituted se_new for se_alloc

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48288
2013-03-14 06:45:23 +00:00
Anders Broman
672a54c156 From beroset:
converted implicit casts to explicit casts, moved nested structure definition outside, and changed se_alloc to se_new.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48287
2013-03-14 06:31:31 +00:00
Anders Broman
fad318ad44 From beroset:
changed implicit casts to explicit casts and corrected one erroneous cast (from void* to void**)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48286
2013-03-14 06:26:55 +00:00
Martin Kaiser
455139f4be dissect more descriptors in the AIT
svn path=/trunk/; revision=48285
2013-03-13 23:26:09 +00:00
Martin Kaiser
8772db463a actx is used, remove _U_
svn path=/trunk/; revision=48284
2013-03-13 22:54:46 +00:00
Anders Broman
04766017df - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48282
2013-03-13 21:14:20 +00:00
Alexis La Goutte
1d74daaec3 Remove unused bgp_route_refresh struct
svn path=/trunk/; revision=48278
2013-03-13 15:02:17 +00:00
Alexis La Goutte
e22e3eeb0e From chaitanya via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8354 Add support for WAPI parameter set IE dissection
Need to add support for WAPI parameter set IE in management frames.
We already have WAI frames dissection support in place.

From me:
Small changes...
- Add links to WAPI specs
- Replace tabs by space
- Remove whitespaces

svn path=/trunk/; revision=48276
2013-03-13 14:49:46 +00:00
Anders Broman
27fc641a79 - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48274
2013-03-12 23:09:37 +00:00
Martin Kaiser
f58e2cc90a dissect Application Signalling Descriptor
svn path=/trunk/; revision=48273
2013-03-12 22:04:09 +00:00
Anders Broman
221b249acd svn path=/trunk/; revision=48272 2013-03-12 21:58:04 +00:00
Martin Kaiser
7c10fd2724 use correct data type in the cast
this fixes
packet-afs.c: In function 'dissect_afs':
packet-afs.c:1539:35: error: expected expression before ')' token


svn path=/trunk/; revision=48266
2013-03-12 20:14:45 +00:00
Anders Broman
455f5c8243 - [-Wmissing-prototypes]
- explicit casts.

svn path=/trunk/; revision=48265
2013-03-12 20:00:50 +00:00
Anders Broman
97bb558394 Introduce a preference to select how Websocket text should be dissected.
svn path=/trunk/; revision=48264
2013-03-12 19:16:35 +00:00