Commit graph

111 commits

Author SHA1 Message Date
Pascal Quantin
92dce1c3f0 Do not initialize ett_tree and dtap_msg_fcn when match_strval_idx does not find a match
svn path=/trunk/; revision=48520
2013-03-24 10:09:16 +00:00
Pascal Quantin
1af56ab0c7 Upgrade NAS disssectors to v11.6.0
svn path=/trunk/; revision=48427
2013-03-19 20:47:48 +00:00
Anders Broman
6bde918078 From beroset:
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48426
2013-03-19 20:00:52 +00:00
Pascal Quantin
86eda54fe6 As suggested by Evan Huus, use extended value_strings
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
Pascal Quantin
94f330030d use enum values instead of hardcoded values
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)

svn path=/trunk/; revision=48397
2013-03-18 20:26:47 +00:00
Anders Broman
f6ce72ee04 From Joseph Chai:
Add aditional IE dissection.
From me patch cleanup and add set fence for multiple DTAP messages in one frame.

svn path=/trunk/; revision=48087
2013-03-05 17:38:44 +00:00
Pascal Quantin
ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209.
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
Pascal Quantin
0b20f855f0 Upgrade NAS disssectors to v11.5.0
svn path=/trunk/; revision=46842
2012-12-29 17:10:04 +00:00
Bill Meier
c2596fb5c7 Fix a purported [-Wshadow] warning;
Also: Do some minor whitespace and formatting changes.

svn path=/trunk/; revision=46195
2012-11-26 01:53:21 +00:00
Pascal Quantin
04ba20fa0e Upgrade NAS dissector to v11.4.0 (Release 11)
svn path=/trunk/; revision=45325
2012-10-04 21:23:06 +00:00
Pascal Quantin
8b6bc1630a Dissect Update UE Location Information message
svn path=/trunk/; revision=45047
2012-09-21 20:00:12 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Pascal Quantin
7da4784b25 Following r44648, revert part of r44162 and followups so as to have a top level gsm_a filter name
svn path=/trunk/; revision=44667
2012-08-25 13:32:41 +00:00
Bill Meier
638d74d43f Use val_to_str_const() where appropriate;
Also (for a few files):
- create/use some extended value strings;
- remove unneeded #include files;
- remove unneeded variable initialization;
- re-order fcns slightly so prefs_reg_handoff...() at end, etc

svn path=/trunk/; revision=44438
2012-08-10 22:55:02 +00:00
Pascal Quantin
6c8d938dd4 Follow-up of r44162: clean more filters
svn path=/trunk/; revision=44187
2012-08-01 14:07:18 +00:00
Pascal Quantin
8ce8431f4e Update filter names following the changes done in r44162
svn path=/trunk/; revision=44168
2012-07-31 20:44:34 +00:00
Michael Mann
175851fb40 Updated GSM dissectors display filters per checkfiltername.pl
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name.

svn path=/trunk/; revision=44162
2012-07-31 18:54:11 +00:00
Jakub Zawadzki
b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Pascal Quantin
f0a74f3a5c Upgrade GSM BSSMAP dissection to Release 9 (V9.8.0)
svn path=/trunk/; revision=43227
2012-06-12 21:36:55 +00:00
pascal
0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs)
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
pascal
254fcdfe19 Upgrade NAS dissector to Release 10 (v10.6.1)
svn path=/trunk/; revision=42728
2012-05-20 20:56:42 +00:00
Bill Meier
d53320919a Remove unneeded #includes (stdlib, stdio, ctypes, time);
In a few cases: do some whitespace, indentation cleanup & reformatting.

svn path=/trunk/; revision=42632
2012-05-15 19:23:35 +00:00
Jakub Zawadzki
80445e5a99 Fix off by one shift errors introduced in r39530 where it seemed proper[1]
[1] I'm unsure of packet-dtpt, so I haven't patch it.

svn path=/trunk/; revision=41873
2012-03-31 20:57:15 +00:00
Bill Meier
198c9ba55f FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE;
In some cases:
 Use val_to_str_const() instead of val_to_str();
 Reformat long lines;
 Do some general whitespace changes.


svn path=/trunk/; revision=41587
2012-03-16 02:00:29 +00:00
Alexis La Goutte
4c64d32a03 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41473
2012-03-10 17:51:47 +00:00
Anders Broman
f5f746f54f From Mike Morrin:
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.

There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.

The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658

svn path=/trunk/; revision=40157
2011-12-12 07:24:57 +00:00
Anders Broman
2f5fc639dd From Pascal Quantin:
updates the decoding of the Test Procedures functions
described in 3GPP 44.014, 34.109 and 36.509.
It also fixes a small issue where Wireshark was trying to decode the skip
indicator as a transaction identifier for those messages.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6638

svn path=/trunk/; revision=40064
2011-12-01 20:09:01 +00:00
Bill Meier
54b72021bb Fix encoding arg for various fcn calls:
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
Bill Meier
d7a1840204 Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string();
Fix encoding arg as needed.

svn path=/trunk/; revision=39530
2011-10-23 22:58:45 +00:00
Anders Broman
797c140887 Set ENC
svn path=/trunk/; revision=39244
2011-10-03 16:47:54 +00:00
Bill Meier
ad1efb6b9c (Trivial) Remove trailing whitespace from lines for a few files.
svn path=/trunk/; revision=39084
2011-09-21 23:42:55 +00:00
Anders Broman
eb31fad0b5 Add 3GPP Sv interface.
svn path=/trunk/; revision=38271
2011-07-30 14:05:55 +00:00
Anders Broman
0a65432f96 Use ENC_BIG_ENDIAN.
svn path=/trunk/; revision=38135
2011-07-20 14:09:19 +00:00
Anders Broman
7dce5861cc From Pascal Quantin:
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
2011-04-27 22:18:00 +00:00
Anders Broman
aaf0d277b8 Get rid of gsm_a_dtap_pinfo.
svn path=/trunk/; revision=36444
2011-04-04 14:49:14 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5 Change the msg_fcn() signature to include pinfo.
svn path=/trunk/; revision=36441
2011-04-04 07:45:34 +00:00
Anders Broman
ed66081a4d From Alexis La Goutte:
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713

svn path=/trunk/; revision=36031
2011-02-23 13:51:49 +00:00
Anders Broman
a469849210 From Pascal Quantin:
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
2011-02-22 11:56:10 +00:00
Anders Broman
0e6aa74d54 From Pascal Quantin:
NAS EPS] Fix display of Authentication (Failure) Parameter IEs

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5704

svn path=/trunk/; revision=36001
2011-02-18 18:40:29 +00:00
Anders Broman
f108c58805 Complement to
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477

svn path=/trunk/; revision=35483
2011-01-11 20:02:30 +00:00
Guy Harris
a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
b78ec52693 Use value_string_ext fcns to access certain value_string arrays;
Sort certain value_string arrays so the values are in ascending order;
Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c).
Minor whitespace cleanup.

svn path=/trunk/; revision=34794
2010-11-05 22:44:03 +00:00
Anders Broman
c522f01e2b From Pascal Quantin:
[NAS EPS] Add dissection of special conformance testing functions

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5278

svn path=/trunk/; revision=34394
2010-10-06 14:33:27 +00:00
Bill Meier
69df32fb11 #include <string.h> not needed.
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
f8d7a4c4b4 Show the substrings of AUTN and AUTS. Expert info warnings
when their lengths is not the expected one.

svn path=/trunk/; revision=31869
2010-02-12 21:57:07 +00:00
Gerasimos Dimitriadis
fab0f16c18 Create FT_BYTES fields for the RAND, AUTN, SRES, XRES
and AUTS octet strings in DTAP

svn path=/trunk/; revision=31859
2010-02-10 22:34:34 +00:00
Bill Meier
de4c6ff515 Fix a number of gcc _Wshadow warnings
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Guy Harris
68cf37f81b Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).

svn path=/trunk/; revision=31376
2009-12-28 21:58:43 +00:00