Commit graph

24176 commits

Author SHA1 Message Date
Jeff Morriss
b59322ecc1 Don't link plugins against libwireshark: any program that loads the dissector
plugins should already be linked against libwireshark.

Don't link capinfos and editcap against libwireshark: they only needed to be
because the plugins were linked against libwireshark (see rev 24123 and the
ensuing discussion on -dev).

capinfos and editcap: don't complain if plugins fail to load: dissector
plugins should fail to load because they need libwireshark.  I am assuming
here that wiretap plugins don't need libwireshark (I've never seen such a
plugin but LEGO's code and comments suggest this is the case).

(The goal of this checkin is to stop linking capinfos and editcap against
libwireshark while still allowing wiretap plugins.  Since we don't have any
such plugins in the tree I do somewhat doubt the need for all this but I don't
want to be the one to remove the functionality.)

svn path=/trunk/; revision=24650
2008-03-16 00:58:15 +00:00
Jeff Morriss
ddca4dd583 Include epan/priveleges.h for get_credential_info()
svn path=/trunk/; revision=24649
2008-03-16 00:41:10 +00:00
Jeff Morriss
d951728e6b Have started_with_special_privs() assert out if get_credential_info() was not
previously called.  This prevents the function from always returning TRUE in
programs that hadn't called get_credential_info().

Call get_credential_info() in the programs that should have been.

svn path=/trunk/; revision=24648
2008-03-16 00:32:12 +00:00
Guy Harris
6367e7c054 Oops, missed one name change.
svn path=/trunk/; revision=24647
2008-03-16 00:17:24 +00:00
Guy Harris
d589b0523b OK, now use DCCP rather than DCP for the Datagram Congestion Control
Protocol.  (Better late than never....)

svn path=/trunk/; revision=24646
2008-03-16 00:03:13 +00:00
Guy Harris
bcd666a74f Rename Distributed Checksum Clearinghouse protocol from "DCCP" to just
"DCC".  Googling for

	DCCP "Distributed Checksum Clearinghouse Protocol"

finds only hits related to Ethereal/Wireshark, either on the Ethereal or
Wireshark Web site, or on discussions where Datagram Congestion Control
Protocol developers were griping that Ethereal/Wireshark already used
DCCP for the Distributed Checksum Clearinghouse protocol.

Next step: fix the Datagram Congestion Control Protocol dissector.

svn path=/trunk/; revision=24645
2008-03-15 23:49:26 +00:00
Guy Harris
3cf6162f72 Get rid of a flag that's not used and that has no effect.
svn path=/trunk/; revision=24644
2008-03-15 23:01:12 +00:00
Jeff Morriss
689e8bd855 From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 :
Hexadecimal and octal are unsigned.  Don't let dissectors register signed
fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX)
or octal.  Fix dissectors that do that mostly by changing the fields to
unsigned though in PANA it appears the fields are meant to be signed so
change those fields to be displayed in decimal.

This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries
to create a filter using one of these mixed signed/unsigned fields (because
that routine does not know how to present the user with a signed value in
hex).

Also add FT_*INT64 to the "make sure it's not BASE_NONE" check.

svn path=/trunk/; revision=24643
2008-03-15 22:41:57 +00:00
Guy Harris
320c1117f6 Add a comment.
svn path=/trunk/; revision=24642
2008-03-15 20:14:29 +00:00
Gerald Combs
fa42bcbd7b Make the document icon brighter and clean it up.
svn path=/trunk/; revision=24641
2008-03-15 19:46:26 +00:00
Gerald Combs
46bcad885a Check in the OS X packaging patch from bug 2341, since I've had
confirmation that the OS X package works on at least one system
other than my laptop.

svn path=/trunk/; revision=24640
2008-03-15 18:31:52 +00:00
Bill Meier
dca49accfa Fix trivial spelling error
svn path=/trunk/; revision=24639
2008-03-15 18:17:52 +00:00
Anders Broman
2fbd6fcf1f Add register_ber_oid_dissector to the exported functions.
svn path=/trunk/; revision=24638
2008-03-15 11:40:49 +00:00
Gerald Combs
121e3d432e Try to fix distcheck again.
svn path=/trunk/; revision=24637
2008-03-15 00:21:02 +00:00
Gerald Combs
b1bd2972ff Fix distcheck.
svn path=/trunk/; revision=24636
2008-03-14 23:43:35 +00:00
Gerald Combs
65a999d337 Updates and fixes.
svn path=/trunk/; revision=24635
2008-03-14 22:06:05 +00:00
Gerald Combs
7519d12f8f Make sure the Infiniband plugin is properly built and packaged.
svn path=/trunk/; revision=24634
2008-03-14 21:53:16 +00:00
Jaap Keuter
74178fafda From Dustin D. Trammell:
The FIX protocol dissector uses the 6 byte string "8=FIX." at the beginning of
the data to match the beginning of a FIX version string of the format
"8=FIX.x.x" in order to determine if the data is the FIX protocol or not.
With FIX 5.x and beyond, the beginning of the data will have a version string 
of the format "8=FIXT.x.x" to indicate the FIX Transport (FIXT) version.

A simple solution is to update the current FIX dissector to only match the
first 5 bytes of the version string (see attached patch).  This will cause a
match for FIX version 4.x and prior (8=FIX.x.x) as well as 5.x and beyond
(8=FIXT.x.x).

svn path=/trunk/; revision=24633
2008-03-14 21:36:01 +00:00
Stig Bjørlykke
5d9ca601d8 Added missing Id keywords, eol-style and ignore targets.
svn path=/trunk/; revision=24632
2008-03-14 19:48:49 +00:00
Stig Bjørlykke
3351980a29 Make infiniband plugin compile.
svn path=/trunk/; revision=24631
2008-03-14 19:35:54 +00:00
Stig Bjørlykke
ccf85f3195 Added check for length in heuristic check so we don't dissect unknown
TCP packets with less than 5 bytes data as a malformed XCSL packet.

svn path=/trunk/; revision=24630
2008-03-14 19:03:56 +00:00
Gerald Combs
d63ad769ff Try out a new Windows document icon.
svn path=/trunk/; revision=24629
2008-03-14 17:57:38 +00:00
Gerald Combs
68d23708bc From Stephen Donnelly via bug 2235:
This plugin implements a dissector for Infiniband. It is released 
under the GPL v2.

Rather than using say libpcap to capture raw (unframed) IP packets 
from near the top of an IPoIB stack, this plugin dissects link level
Infiniband frames.

Infiniband trace files can be read from Endace ERF format trace 
files, or from libpcap DLT_ERF files containing ERF TYPE_INFINIBAND 
records. There is currently no native DLT_INFINIBAND in libpcap.

Each record contains a hardware timestamp, capture metadata such as 
port Id, and a complete link level Infiniband frame starting from
the Local Route Header.

svn path=/trunk/; revision=24628
2008-03-14 17:47:53 +00:00
Jaap Keuter
14e0b8f792 From Dan Messinger:
The OSD APPEND command does not use the sort order field. Wireshark is decoding it.

svn path=/trunk/; revision=24627
2008-03-14 07:45:30 +00:00
Jaap Keuter
9815fec31d Attribute Xcsl dissector.
svn path=/trunk/; revision=24626
2008-03-14 07:10:07 +00:00
Stephen Fisher
5f0021ccba Fix bug #1143 - Can't read packet details....bad color scheme forced
Change the code so we don't force a white background in the protocol tree
area, instead just unset it so it goes back to its natural background.  This
matters with color schemes that have a black background.


svn path=/trunk/; revision=24625
2008-03-14 06:15:06 +00:00
Guy Harris
ef81118b2c Update documentation information.
svn path=/trunk/; revision=24624
2008-03-14 03:28:12 +00:00
Guy Harris
7cc6cfb7ad Update documentation links.
svn path=/trunk/; revision=24623
2008-03-14 03:23:36 +00:00
Gerald Combs
335927f46f From Hannes Kalber:
This patch adds some new ENCAP and FILE types for wiretap. It also adds new
entries to pcap_to_wtap_map[] to provide a mapping of the new types to some
pcap DLTs.

svn path=/trunk/; revision=24622
2008-03-14 00:01:51 +00:00
Gerald Combs
106968d7e8 From Hariharan Ananthakrishnan:
I have added two new display filters to support filtering based on LSP-ID and
hostname for ISIS protocol. 

svn path=/trunk/; revision=24621
2008-03-13 23:45:48 +00:00
Gerald Combs
f8e75ecd32 Make the SMI preference a little more verbose. In the COPS and SNMP
preferences, tell the user where they can change the SMI settings. In
the 802.11 preferences, fix a tooltip.

svn path=/trunk/; revision=24620
2008-03-13 22:17:11 +00:00
Jaap Keuter
7ef65a5df6 Partial fix for bug 2153
AMF object ID is in the lower 6 bits of the octet

svn path=/trunk/; revision=24619
2008-03-13 18:32:10 +00:00
Gerald Combs
fea0442105 Remove leftover debug code.
svn path=/trunk/; revision=24618
2008-03-13 14:45:52 +00:00
Martin Mathieson
6328b4471a Make SABP work over registered ports.
svn path=/trunk/; revision=24617
2008-03-13 11:54:06 +00:00
Stephen Fisher
4718890a3c Fix a minor memory leak.
svn path=/trunk/; revision=24616
2008-03-13 06:25:53 +00:00
Gerald Combs
bf75c9eac6 sscanf() apparently handles negative input values, even when your
target is an unsigned int.  Adjust our bogus value check to match
the recent int -> guint change. Fixes bug 2355.

svn path=/trunk/; revision=24615
2008-03-13 05:24:21 +00:00
Stephen Fisher
7d8df3dee4 Save about 1MB of RAM that was wasted for the entire Wireshark session.
This is done by using dynamically allocated memory for tpncp field names
instead of relying on a static array of 256 bytes.  This makes a noticeable
difference because there are so many entries in tpncp/tpncp.dat.
 

svn path=/trunk/; revision=24614
2008-03-13 04:49:37 +00:00
Stig Bjørlykke
477b2c061a Fixed uint -> guint.
svn path=/trunk/; revision=24613
2008-03-12 21:43:37 +00:00
Jaap Keuter
4d3922952f Fix for bug 2344:
AMF number if a double, not a uint16.

svn path=/trunk/; revision=24612
2008-03-12 21:25:42 +00:00
Jörg Mayer
80140a78f5 + DHCP overload option parsing changes (triggered by bug 2194):
- The overloaded options are displayed at the same level as other options
  - The bootp file and server name options are displayed as overloaded if
    appropriate. To achieve this the bootp header parsing code needed to be
    moved to a later point.
+ Some signedness warning fixes.
+ Make a global variable (novell_string) static


svn path=/trunk/; revision=24611
2008-03-12 21:00:00 +00:00
Stig Bjørlykke
fa2033ab8b Fixed server and client packet count in C Array variables in
Follow TCP/UDP/SSL Stream.  This error was introduced when merging
duplicate code between TCP & SSL stream functions, r22869.

svn path=/trunk/; revision=24610
2008-03-12 08:50:09 +00:00
Stig Bjørlykke
ba7cbb5aa9 From Nathan Jennings (bug 2350):
Highlight the selected interface in the edit interfaces list.

svn path=/trunk/; revision=24609
2008-03-12 07:16:25 +00:00
Stig Bjørlykke
cf3a5d8d55 Fix some texts in the file types list.
svn path=/trunk/; revision=24608
2008-03-11 22:50:17 +00:00
Stig Bjørlykke
1aa356313e Disable the "Packet Format" when save as "C Arrays".
svn path=/trunk/; revision=24607
2008-03-11 21:06:56 +00:00
Stig Bjørlykke
d0a04bd7df Added "C Arrays" to list of file types to export.
svn path=/trunk/; revision=24606
2008-03-11 19:35:53 +00:00
Gerald Combs
b0f634c396 If we haven't found a handshake packet, say so.
svn path=/trunk/; revision=24605
2008-03-11 18:32:20 +00:00
Stig Bjørlykke
5800abad46 From Francesco Fondelli (bug 2349):
Attached is a patch to export packets data as "C Arrays".  I often have
the need to [re]send data captured with wireshark using a raw/pf_packet socket.
Output format is one char[] per packet, it looks like almost the same as
the one produced by "Follow TCP stream".

svn path=/trunk/; revision=24604
2008-03-11 18:23:16 +00:00
Stig Bjørlykke
11eda6b97b Add check for gtk 2.4 when calling gtk_tree_view_column_set_expand.
svn path=/trunk/; revision=24603
2008-03-11 17:27:41 +00:00
Anders Broman
dda91091ad Fix a typo.
svn path=/trunk/; revision=24602
2008-03-10 20:28:21 +00:00
Jaap Keuter
04e6c9f1dc From Dick Gooris:
The protocol is called Xcsl a TCP based and ASCII based protocol that is used
to control call generators. The Xcsl dissector decodes the Call Specification
Language.

svn path=/trunk/; revision=24601
2008-03-10 19:28:03 +00:00