Commit Graph

14 Commits

Author SHA1 Message Date
Gerald Combs 3a6c9ab134 Fix a format string vulneratility in the AFP dissector identified
by iDEFENSE.  Add constant format strings to proto_item_append_text()
in a bunch of other dissectors.  Copy a comment from proto.c to proto.h.

svn path=/trunk/; revision=14713
2005-06-20 19:35:58 +00:00
Guy Harris 802859d3fd Call the "new-style init" routine for plugins a "register" routine, as
it serves the same purpose as the register routine in a built-in
dissector, and don't require all dissectors to have one, as they might
just be taps.

Get rid of the stats tree's init routine, as it's just a tap, and as it
doesn't do anything.

Update the idl2eth Python script to generate plugins with register routines.

svn path=/trunk/; revision=13644
2005-03-07 02:44:41 +00:00
Lars Roland 00273300e7 Preparations for dropping the old plugin api.
Introduce a new init routine for plugins, 
which does not take the plugin api table as an 
argument and allows etheral to distinguish 
between plugins using the old and the new api.

Update README.plugins accordingly

Change all g_warnings() in epan/plugins.c to report_failue().
On windows we do not have a log console open while
loading the plugins, because a log console cannot be opened before the prefs have been read. Thus g_warnings()
does not work for reporting problems with plugins.

svn path=/trunk/; revision=13596
2005-03-05 06:28:10 +00:00
Anders Broman d86f7e48c4 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13245
2005-02-02 20:09:00 +00:00
Guy Harris 99392257b7 In "plugins/plugin_api.h", don't include stuff required for the plugin
address table if we don't need the plugin address table, so as to catch
plugin dissectors that don't directly include stuff they need -
eventually, the plugin address table stuff should completely go away, so
we don't want dissectors depending on it.

Fix those dissectors caught by this.

Don't include "simple_dialog.h" in the ASN.1 dissector - it doesn't use
it.

svn path=/trunk/; revision=12140
2004-09-29 22:20:21 +00:00
Guy Harris 8a8b883450 Set the svn:eol-style property on all text files to "native", so that
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on
Windows, not on UN*X.

svn path=/trunk/; revision=11400
2004-07-18 00:24:25 +00:00
Michael Tüxen 42279a7088 get rid of data_handle decalriation, bacause it is
defined external in irda-appl.h which is included.

svn path=/trunk/; revision=11282
2004-06-30 15:42:24 +00:00
Guy Harris 2271736636 Add the URL of the specifications page.
svn path=/trunk/; revision=10348
2004-03-08 23:19:14 +00:00
Jörg Mayer 12a17e8f96 Note to self: If you update the code, you should update the docs too.
Update README.plugins to use ENABLE_STATIC instead of __ETHEREAL_STATIC__
Update some plugins, that were created after my changes according to the
outdated docs.
Changed occurrences of
G_MODULE_EXPORT void plugin_reg_handoff(void)
into
G_MODULE_EXPORT void
plugin_reg_handoff(void)

as the one line Python version doesn't work with the Python of Suse 9.0

svn path=/trunk/; revision=10281
2004-03-02 23:45:34 +00:00
Guy Harris eaf42827f3 Give the IrDA dissector its own private value_string table for the frame
type in the IrLAP control field - on most UNIXes the dissector should be
able to use the table from the main program, but that doesn't currently
work on Windows.

svn path=/trunk/; revision=9717
2004-01-18 14:03:37 +00:00
Guy Harris 5a751f6811 Add arguments to "dissect_xdlc_control()" to specify value_string
tables, for use in the top-level item for the control field, for
unnumbered frame function codes for commands and responses.  If the
argument is null, default to the standard tables.

Use "dissect_xdlc_control()" and the #defines from "xdlc.h" for IrDA.

Use the reported length rather than the data length in the IrDA
dissector when iterating over the data in an IrDA packet.

Make "dissect_xid()" update the column information as well as the
protocol tree.  Put the slot number into the protocol tree only for
command frames - "the slot number field is undefined in discovery XID
response frames", to quote the IrLAP spec.

svn path=/trunk/; revision=9713
2004-01-18 08:32:46 +00:00
Jörg Mayer ad28a88d72 Compiling with -pedantic:
packet-irda.c:453:1: warning: C++ style comments are not allowed in ISO C90
packet-irda.c:453:1: warning: (this will be reported only once per input file)
(+ several more // disabling debug output)

svn path=/trunk/; revision=9377
2003-12-21 03:48:27 +00:00
Guy Harris e4c1c73fc5 From Jan Kiszka: add a comment explaining what the IrDA plugin does.
svn path=/trunk/; revision=9346
2003-12-18 20:34:43 +00:00
Guy Harris b8299f0b98 From Jan Kiszka: IrDA support.
svn path=/trunk/; revision=9345
2003-12-18 19:07:14 +00:00